HBASE-28407 [thirdparty] Update release instructions #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
busbey
approved these changes
Feb 28, 2024
Contributor
busbey
left a comment
busbey
left a comment
There was a problem hiding this comment.
Looks like a good start for sure.
NihalJain
reviewed
Feb 28, 2024
| have in hbase-unsafe is using old APIs that have been removed from more | ||
| modern JDKs. Due to a bug in JDK, we cannot generate this code using a more | ||
| modern version of the JDK. See | ||
| [HBASE-26773](https://issues.apache.org/jira/browse/HBASE-26773) for details. |
Contributor
There was a problem hiding this comment.
Ah I hit https://issues.apache.org/jira/browse/HBASE-28380, while trying to build with JDK17. This doc helps me understand why we have hbase-unsafe module and how to release. Very useful. Thanks a ton :)
NihalJain
approved these changes
Feb 28, 2024
ndimiduk
commented
Feb 28, 2024
Member
Author
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
Thanks for the reviews. I'll merge this after the current RC vote is finished.
chrajeshbabu
approved these changes
Feb 28, 2024
Signed-off-by: Sean Busbey <busbey@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Rajeshbabu Chintaguntla <rajeshbabu@apache.org>
ndimiduk
force-pushed
the
28407-release-instructions
branch
from
5c18bb3 to
362130d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Apache9 @busbey This is the processes that I (eventually) sorted out. Does it look about right from your recollection?