-
Notifications
You must be signed in to change notification settings - Fork 52
HBASE-28407 [thirdparty] Update release instructions #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| # HBase Thirdparty | ||
| <!--- | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| --> | ||
|
|
||
| This project packages relocated third-party libraries used by Apache HBase. | ||
|
|
||
| > DISCLAIMER: This project is for Apache HBase internal use. Included libs | ||
| > and/or their versions are subject to change at the dictate of hbase without | ||
| > regard to the concern of others! | ||
|
|
||
| We have a number of submodules, one per ornery lib -- protobuf, netty, &c. -- | ||
| where we need special-handling and then a bucket for all the rest, | ||
| hbase-shaded-miscellaneous. This latter includes protobuf-util, gson, and guava. | ||
|
|
||
| General philosophy is many modules rather than a few fat ones so we can keep | ||
| dependency narrow; a fat jar would put a load of unnecessaries on the | ||
| CLASSPATH. The hbase-shaded-miscellaneous is a sort of all-the-rest but it | ||
| is also libs that depend on each other and are awkward to disentangle. | ||
|
|
||
| All shading is done using the same relocation offset of | ||
| org.apache.hbase.thirdparty. We add this prefix to the relocated thirdparty | ||
| library class names. | ||
|
|
||
| See the pom.xml for the explicit version of each third-party lib included. | ||
|
|
||
| Note that in hbase-shaded-protobuf, we unzip the protobuf jar to src/main/java | ||
| rather than to a dir under target because the jar plugin wants src here (its | ||
| hard to convince it otherwise). We also apply some patches. Current set are: | ||
|
|
||
| ``` | ||
| HBASE-15789_V2.patch | ||
| HBASE-17087.patch | ||
| HBASE-17239.patch | ||
| ``` | ||
|
|
||
| Ideally we would be pushing this set up into protobuf project. | ||
|
|
||
| Note that this project requires JDK8. This is because a bunch of the code we | ||
| have in hbase-unsafe is using old APIs that have been removed from more | ||
| modern JDKs. Due to a bug in JDK, we cannot generate this code using a more | ||
| modern version of the JDK. See | ||
| [HBASE-26773](https://issues.apache.org/jira/browse/HBASE-26773) for details. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah I hit https://issues.apache.org/jira/browse/HBASE-28380, while trying to build with JDK17. This doc helps me understand why we have hbase-unsafe module and how to release. Very useful. Thanks a ton :) |
||
|
|
||
| ## Build/Deploy | ||
|
|
||
| To build, make sure that your environment uses JDK8, then just run: | ||
|
|
||
| ```sh | ||
| mvn clean package | ||
| ``` | ||
|
|
||
| ## Release | ||
|
|
||
| To cut a release candidate, update JIRA. The hbase-thirdparty currently uses | ||
| hbase JIRA but with versions specified with a 'thirdparty-x.y.z'. | ||
|
|
||
| Use the `dev-support/create-release` scripts found in `hbase.git:master`. This | ||
| requires having the `gpg-agent` running and configured correctly. Specify the | ||
| project name and git repo path. See `do-release-docker.sh -h` for details. For | ||
| example: | ||
|
|
||
| ```sh | ||
| % mkdir ~/tmp/hbase-thirdparty-4.1.6RC0/ | ||
| % ~/src/hbase/dev-support/create-release/do-release-docker.sh \ | ||
| -d ~/tmp/hbase-thirdparty-4.1.6RC0 \ | ||
| -p hbase-thirdparty | ||
| ``` | ||
|
|
||
| Try the new artifact by having hbase use the staged jar. Do this in your hbase pom: | ||
|
|
||
| ``` | ||
| diff --git a/pom.xml b/pom.xml | ||
| index 112f95a892..dab9e7a6bd 100755 | ||
| --- a/pom.xml | ||
| +++ b/pom.xml | ||
| @@ -1451,7 +1451,7 @@ | ||
| <spotbugs.version>3.1.0-RC3</spotbugs.version> | ||
| <wagon.ssh.version>2.12</wagon.ssh.version> | ||
| <xml.maven.version>1.0.1</xml.maven.version> | ||
| - <hbase-thirdparty.version>2.1.0</hbase-thirdparty.version> | ||
| + <hbase-thirdparty.version>2.2.0</hbase-thirdparty.version> | ||
| <!-- Intraproject jar naming properties --> | ||
| <!-- TODO this is pretty ugly, but works for the moment. | ||
| Modules are pretty heavy-weight things, so doing this work isn't too bad. --> | ||
| @@ -3774,4 +3774,11 @@ | ||
| <url>file:///tmp</url> | ||
| </site> | ||
| </distributionManagement> | ||
| + <repositories> | ||
| + <repository> | ||
| + <id>staging</id> | ||
| + <name>staging</name> | ||
| + <url>https://repository.apache.org/content/repositories/orgapachehbase-1296</url> | ||
| + </repository> | ||
| + </repositories> | ||
| </project> | ||
| ``` | ||
|
|
||
| Send out an email with details on staging repo and pointers to the uploaded | ||
| artifacts. | ||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.