HBASE-25070 : With new generic API getLogEntries, cleaning up unused …

…RPC APIs

Closes #2426

Signed-off-by: Guanghao Zhang <zghao@apache.org>

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java

@@ -2512,8 +2512,8 @@ Pair<List<String>, List<TableName>> getConfiguredNamespacesAndTablesInRSGroup(St
    * Examples include slow/large RPC logs, balancer decisions by master.
    *
    * @param serverNames servers to retrieve records from, useful in case of records maintained
-   *  by RegionServer as we can select specific server. In case of servertype=MASTER, logs will
-   *  only come from the currently active master.
+   *   by RegionServer as we can select specific server. In case of servertype=MASTER, logs will
+   *   only come from the currently active master.
    * @param logType string representing type of log records
    * @param serverType enum for server type: HMaster or RegionServer
    * @param limit put a limit to list of records that server should send in response

hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java

@@ -1714,8 +1714,8 @@ default CompletableFuture<List<OnlineLogRecord>> getSlowLogResponses(
    * Examples include slow/large RPC logs, balancer decisions by master.
    *
    * @param serverNames servers to retrieve records from, useful in case of records maintained
-   *  by RegionServer as we can select specific server. In case of servertype=MASTER, logs will
-   *  only come from the currently active master.
+   *   by RegionServer as we can select specific server. In case of servertype=MASTER, logs will
+   *   only come from the currently active master.
    * @param logType string representing type of log records
    * @param serverType enum for server type: HMaster or RegionServer
    * @param limit put a limit to list of records that server should send in response

hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto

@@ -393,12 +393,6 @@ service AdminService {
   rpc ExecuteProcedures(ExecuteProceduresRequest)
     returns(ExecuteProceduresResponse);
 
-  rpc GetSlowLogResponses(SlowLogResponseRequest)
-    returns(SlowLogResponses);
-
-  rpc GetLargeLogResponses(SlowLogResponseRequest)
-    returns(SlowLogResponses);
-
   rpc ClearSlowLogsResponses(ClearSlowLogResponseRequest)
     returns(ClearSlowLogResponses);
 

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java

@@ -3851,19 +3851,6 @@ public ExecuteProceduresResponse executeProcedures(RpcController controller,
     }
   }
 
-  @Override
-  @QosPriority(priority = HConstants.ADMIN_QOS)
-  public SlowLogResponses getSlowLogResponses(final RpcController controller,
-    final SlowLogResponseRequest request) {
-    final NamedQueueRecorder namedQueueRecorder =
-      this.regionServer.getNamedQueueRecorder();
-    final List<SlowLogPayload> slowLogPayloads = getSlowLogPayloads(request, namedQueueRecorder);
-    SlowLogResponses slowLogResponses = SlowLogResponses.newBuilder()
-      .addAllSlowLogPayloads(slowLogPayloads)
-      .build();
-    return slowLogResponses;
-  }
-
   private List<SlowLogPayload> getSlowLogPayloads(SlowLogResponseRequest request,
       NamedQueueRecorder namedQueueRecorder) {
     if (namedQueueRecorder == null) {
@@ -3881,19 +3868,6 @@ private List<SlowLogPayload> getSlowLogPayloads(SlowLogResponseRequest request,
     return slowLogPayloads;
   }
 
-  @Override
-  @QosPriority(priority = HConstants.ADMIN_QOS)
-  public SlowLogResponses getLargeLogResponses(final RpcController controller,
-      final SlowLogResponseRequest request) {
-    final NamedQueueRecorder namedQueueRecorder =
-      this.regionServer.getNamedQueueRecorder();
-    final List<SlowLogPayload> slowLogPayloads = getSlowLogPayloads(request, namedQueueRecorder);
-    SlowLogResponses slowLogResponses = SlowLogResponses.newBuilder()
-      .addAllSlowLogPayloads(slowLogPayloads)
-      .build();
-    return slowLogResponses;
-  }
-
   @Override
   @QosPriority(priority = HConstants.ADMIN_QOS)
   public ClearSlowLogResponses clearSlowLogsResponses(final RpcController controller,
@@ -3911,6 +3885,7 @@ public ClearSlowLogResponses clearSlowLogsResponses(final RpcController controll
   }
 
   @Override
+  @QosPriority(priority = HConstants.ADMIN_QOS)
   public HBaseProtos.LogEntry getLogEntries(RpcController controller,
       HBaseProtos.LogRequest request) throws ServiceException {
     try {

hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java

@@ -114,8 +114,6 @@
 import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.ReplicateWALEntryResponse;
 import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.RollWALWriterRequest;
 import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.RollWALWriterResponse;
-import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.SlowLogResponseRequest;
-import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.SlowLogResponses;
 import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.StopServerRequest;
 import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.StopServerResponse;
 import org.apache.hadoop.hbase.shaded.protobuf.generated.AdminProtos.UpdateConfigurationRequest;
@@ -679,18 +677,6 @@ public ExecuteProceduresResponse executeProcedures(RpcController controller,
     return null;
   }
 
-  @Override
-  public SlowLogResponses getSlowLogResponses(RpcController controller,
-      SlowLogResponseRequest request) throws ServiceException {
-    return null;
-  }
-
-  @Override
-  public SlowLogResponses getLargeLogResponses(RpcController controller,
-      SlowLogResponseRequest request) throws ServiceException {
-    return null;
-  }
-
   @Override
   public ClearSlowLogResponses clearSlowLogsResponses(RpcController controller,
       ClearSlowLogResponseRequest request) throws ServiceException {