HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs #2426

virajjasani · 2020-09-19T12:34:27Z

No description provided.

…PI getLogEntries

Apache-HBase · 2020-09-19T13:46:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 37s	master passed
+1 💚	checkstyle	1m 45s	master passed
+1 💚	spotbugs	6m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 23s	the patch passed
+1 💚	checkstyle	0m 11s	The patch passed checkstyle in hbase-protocol-shaded
+1 💚	checkstyle	0m 27s	hbase-client: The patch generated 0 new + 37 unchanged - 4 fixed = 37 total (was 41)
-0 ⚠️	checkstyle	1m 5s	hbase-server: The patch generated 2 new + 51 unchanged - 0 fixed = 53 total (was 51)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 21s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	2m 2s	the patch passed
+1 💚	spotbugs	7m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		47m 10s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2426
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool
uname	Linux 0813a4c695a4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `58618e3`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-19T16:00:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 7s	master passed
+1 💚	compile	2m 58s	master passed
+1 💚	shadedjars	7m 46s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 27s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 46s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 40s	the patch passed
+1 💚	compile	2m 52s	the patch passed
+1 💚	javac	2m 52s	the patch passed
+1 💚	shadedjars	7m 41s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 28s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 46s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 5s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 15s	hbase-client in the patch passed.
+1 💚	unit	136m 3s	hbase-server in the patch passed.
		176m 47s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8b558145ce29 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `58618e3`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/testReport/
Max. process+thread count	4017 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-19T17:24:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 3s	master passed
+1 💚	compile	2m 36s	master passed
+1 💚	shadedjars	7m 33s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 14s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 59s	the patch passed
+1 💚	compile	2m 13s	the patch passed
+1 💚	javac	2m 13s	the patch passed
+1 💚	shadedjars	7m 24s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 49s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 15s	hbase-client in the patch passed.
+1 💚	unit	226m 54s	hbase-server in the patch passed.
		263m 25s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 70dd684a4219 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `58618e3`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/testReport/
Max. process+thread count	3362 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-19T18:22:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 28s	master passed
+1 💚	checkstyle	1m 58s	master passed
+1 💚	spotbugs	7m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-protocol-shaded
+1 💚	checkstyle	0m 29s	hbase-client: The patch generated 0 new + 37 unchanged - 4 fixed = 37 total (was 41)
+1 💚	checkstyle	1m 17s	The patch passed checkstyle in hbase-server
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	hbaseprotoc	2m 19s	the patch passed
+1 💚	spotbugs	8m 38s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		55m 46s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2426
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle cc hbaseprotoc prototool
uname	Linux 9571cb6ddd12 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4c9a92d`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-19T20:19:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 24s	master passed
+1 💚	compile	2m 5s	master passed
+1 💚	shadedjars	6m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 12s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	2m 3s	the patch passed
+1 💚	javac	2m 3s	the patch passed
+1 💚	shadedjars	6m 27s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 46s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 3s	hbase-client in the patch passed.
+1 💚	unit	141m 37s	hbase-server in the patch passed.
		173m 12s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux acd706d82cbf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4c9a92d`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/testReport/
Max. process+thread count	4038 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-09-19T21:18:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 47s	master passed
+1 💚	compile	2m 43s	master passed
+1 💚	shadedjars	7m 24s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 25s	hbase-client in master failed.
-0 ⚠️	javadoc	0m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	2m 42s	the patch passed
+1 💚	javac	2m 42s	the patch passed
+1 💚	shadedjars	7m 23s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 25s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 41s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 4s	hbase-protocol-shaded in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
+1 💚	unit	193m 19s	hbase-server in the patch passed.
		231m 44s

Subsystem	Report/Notes
Docker	Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2426
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 74a89c65f6f0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `4c9a92d`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/testReport/
Max. process+thread count	3401 (vs. ulimit of 12500)
modules	C: hbase-protocol-shaded hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2426/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

infraio · 2020-09-21T00:23:01Z

Remove public API? When this API was added?

virajjasani · 2020-09-21T07:10:30Z

Remove public API? When this API was added?

Not exactly public API, it's our internal RPC API. New RPC API was added as part of HBASE-24528 and is applicable to 2.4+ only. So this change is also planned for master and branch-2 only.

virajjasani · 2020-09-25T08:39:12Z

@infraio this sounds good to you?

infraio · 2020-09-25T09:47:09Z

Got it. The client api was implemented by new rpc. These not used anymore. But one problem is: the old client cannot access new server?

virajjasani · 2020-09-25T12:58:32Z

Old client for this use-case would be 2.3.x releases and yes they would not be able to access new RPC.

So the question is this might be an issue for any deprecated RPC API right? Our RsRpcServices and MasterRpcServices are IA.Private, which means we can remove APIs from these endpoints even in minor releases, and this could be a problem for any old client (which cannot access removed Rpc API).

Do we follow any guidelines for Rpc implementations w.r.t client compatibility? e.g not remove deprecated RPCs from Master.proto and admin.proto in minor releases?

virajjasani · 2020-09-27T18:03:38Z

I think old client capable of using old RPC should be a valid case of minor releases, let me just target for master branch for this change. Thought @infraio ?

infraio · 2020-09-28T00:31:10Z

bq. Do we follow any guidelines for Rpc implementations w.r.t client compatibility? e.g not remove deprecated RPCs from Master.proto and admin.proto in minor releases?

This is descripted in http://hbase.apache.org/book.html#hbase.versioning.post10 . This is about "Client-Server wire protocol compatibility". And it can be breaked between major version. "Only land to master branch" is ok.

infraio

+1 only for master branch.

virajjasani · 2020-09-28T06:23:46Z

Thanks @infraio . Wondering if we should change RsRpcServices and MasterRpcServices to IA.LimitedPrivate instead of IA.Private.

HBASE-25070 : Cleanup of unused RPC APIs in the presence of generic A…

1877881

…PI getLogEntries

virajjasani changed the title ~~HBASE-25070 : Cleanup of unused RPC APIs in the presence of generic API getLogEntries~~ HBASE-25070 : With new generic API getLogEntries, cleanup of unused RPC APIs Sep 19, 2020

checkstyle

4f03823

virajjasani changed the title ~~HBASE-25070 : With new generic API getLogEntries, cleanup of unused RPC APIs~~ HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs Sep 19, 2020

virajjasani requested review from infraio, apurtell, wchevreuil, busbey and Apache9 September 20, 2020 07:03

infraio approved these changes Sep 28, 2020

View reviewed changes

infraio assigned virajjasani Sep 28, 2020

virajjasani closed this in 80ffac2 Sep 28, 2020

virajjasani deleted the HBASE-25070-trunk branch September 28, 2020 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs #2426

HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs #2426

virajjasani commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

infraio commented Sep 21, 2020

virajjasani commented Sep 21, 2020 •

edited

Loading

virajjasani commented Sep 25, 2020

infraio commented Sep 25, 2020

virajjasani commented Sep 25, 2020

virajjasani commented Sep 27, 2020

infraio commented Sep 28, 2020

infraio left a comment •

edited

Loading

virajjasani commented Sep 28, 2020

HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs #2426

HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs #2426

Conversation

virajjasani commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

Apache-HBase commented Sep 19, 2020

infraio commented Sep 21, 2020

virajjasani commented Sep 21, 2020 • edited Loading

virajjasani commented Sep 25, 2020

infraio commented Sep 25, 2020

virajjasani commented Sep 25, 2020

virajjasani commented Sep 27, 2020

infraio commented Sep 28, 2020

infraio left a comment • edited Loading

Choose a reason for hiding this comment

virajjasani commented Sep 28, 2020

virajjasani commented Sep 21, 2020 •

edited

Loading

infraio left a comment •

edited

Loading