HBASE-19386 HBase UnsafeAvailChecker returns false on Arm64 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Arm64, java.nio.Bits.unaligned() wrongly returns false due to a JDK bug. This causes HBase UnsafeAvailChecker wrongly returning false on Arm64. And it slso cause FuzzyRowFilter Unit test failed. Fix it by providing a hard-code to enbale Arm64 unaligned support. Jira: HBASE-19386 Change-Id: I3ab821dacbe42b18cd515080da1fa3dc1f1e1d28 Signed-off-by: Yuqi Gu <yuqi.gu@arm.com>
|
This PR is slated to be closed as a part of HBASE-20391 because the referenced JIRA has since closed. If this is incorrect and you are still interested in working on the issue please comment there and/or reopen the PR. |
YiannisGkoufas
pushed a commit
to ibm-research-ireland/hbaquet
that referenced
this pull request
May 4, 2018
* closes apache#51 - > 1 month since notification * closes apache#61 - HBASE-18928 has already closed * closes apache#62 - HBASE-18929 has already closed * closes apache#67 - HBASE-19386 has already closed * closes apache#68 - HBASE-19387 has already closed Also adds a section to the committer guide in the reference guide about closing PRs. Signed-off-by: Mike Drob <mdrob@apache.org>
This was referenced Sep 4, 2019
Merged
Merged
This was referenced Sep 12, 2019
This was referenced Jul 10, 2021
Merged
This was referenced Jul 19, 2021
This was referenced Jul 27, 2021
ndimiduk
pushed a commit
to ndimiduk/hbase
that referenced
this pull request
Feb 29, 2024
…lContext (apache#67) Co-authored-by: Charles Connell <cconnell@hubspot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Arm64, java.nio.Bits.unaligned() wrongly returns false due to a JDK bug.
This causes HBase UnsafeAvailChecker wrongly returning false on Arm64.
And it slso cause FuzzyRowFilter Unit test failed.
Fix it by providing a hard-code to enbale Arm64 unaligned support.
Jira: HBASE-19386
Change-Id: I3ab821dacbe42b18cd515080da1fa3dc1f1e1d28
Signed-off-by: Yuqi Gu yuqi.gu@arm.com