Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HBASE-23000] Backport HBASE-18150 to branch-1.3 #608

Merged
merged 2 commits into from
Sep 12, 2019
Merged

[HBASE-23000] Backport HBASE-18150 to branch-1.3 #608

merged 2 commits into from
Sep 12, 2019

Conversation

shahrs87
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 1m 14s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
💚 mvninstall 7m 12s branch-1.3 passed
💚 compile 0m 40s branch-1.3 passed
💚 checkstyle 1m 43s branch-1.3 passed
💔 shadedjars 0m 13s branch has 10 errors when building our shaded downstream artifacts.
💚 javadoc 0m 36s branch-1.3 passed
💙 spotbugs 2m 20s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 2m 18s branch-1.3 passed
_ Patch Compile Tests _
💚 mvninstall 1m 48s the patch passed
💚 compile 0m 40s the patch passed
💚 javac 0m 40s the patch passed
💔 checkstyle 1m 40s hbase-server: The patch generated 2 new + 26 unchanged - 0 fixed = 28 total (was 26)
💚 whitespace 0m 0s The patch has no whitespace issues.
💔 shadedjars 0m 14s patch has 10 errors when building our shaded downstream artifacts.
💚 hadoopcheck 9m 43s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
💚 javadoc 0m 29s the patch passed
💚 findbugs 2m 14s the patch passed
_ Other Tests _
💚 unit 113m 24s hbase-server in the patch passed.
💚 asflicense 0m 28s The patch does not generate ASF License warnings.
146m 9s
Subsystem Report/Notes
Docker Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/1/artifact/out/Dockerfile
GITHUB PR #608
JIRA Issue HBASE-23000
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 8f8d4326274b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-608/out/precommit/personality/provided.sh
git revision branch-1.3 / 64c0ac5
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/1/artifact/out/branch-shadedjars.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/1/artifact/out/diff-checkstyle-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/1/artifact/out/patch-shadedjars.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/1/testReport/
Max. process+thread count 4091 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/1/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
💙 reexec 0m 48s Docker mode activated.
_ Prechecks _
💚 dupname 0m 0s No case conflicting files found.
💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
💚 @author 0m 0s The patch does not contain any @author tags.
💛 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1.3 Compile Tests _
💚 mvninstall 7m 37s branch-1.3 passed
💚 compile 0m 40s branch-1.3 passed
💚 checkstyle 1m 36s branch-1.3 passed
💔 shadedjars 0m 12s branch has 10 errors when building our shaded downstream artifacts.
💚 javadoc 0m 42s branch-1.3 passed
💙 spotbugs 2m 32s Used deprecated FindBugs config; considering switching to SpotBugs.
💚 findbugs 2m 28s branch-1.3 passed
_ Patch Compile Tests _
💚 mvninstall 1m 45s the patch passed
💚 compile 0m 41s the patch passed
💚 javac 0m 41s the patch passed
💚 checkstyle 1m 39s the patch passed
💚 whitespace 0m 0s The patch has no whitespace issues.
💔 shadedjars 0m 12s patch has 10 errors when building our shaded downstream artifacts.
💚 hadoopcheck 10m 6s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.5 2.7.7.
💚 javadoc 0m 35s the patch passed
💚 findbugs 2m 32s the patch passed
_ Other Tests _
💔 unit 101m 46s hbase-server in the patch failed.
💚 asflicense 0m 22s The patch does not generate ASF License warnings.
135m 7s
Reason Tests
Failed junit tests hadoop.hbase.master.cleaner.TestSnapshotFromMaster
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/Dockerfile
GITHUB PR #608
JIRA Issue HBASE-23000
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f6f7512ed469 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-608/out/precommit/personality/provided.sh
git revision branch-1.3 / 64c0ac5
Default Java 1.8.0_222
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/branch-shadedjars.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/patch-shadedjars.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/testReport/
Max. process+thread count 4004 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-608/2/console
versions git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@shahrs87
Copy link
Contributor Author

@jatsakthi could you please review this PR ? Thank you !

@the-sakthi
Copy link
Member

Thanks for the patch @shahrs87 let me give it a look

the-sakthi
the-sakthi reviewed Sep 11, 2019
View reviewed changes
Copy link
Member

@the-sakthi the-sakthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch LGTM. Unfortunately all 4 tests (TestLogRollAbort, TestBlockReorder, TestHRegionServerBulkLoad, TestMasterFileSystemWithWALDir) that this patch intends to fix, were skipped in the UT runs of the QA. Did you try running these tests after the patch, locally?

@the-sakthi
Copy link
Member

Let me run this patch in our adhoc testing framework to crosscheck

@the-sakthi
Copy link
Member

Running [TestLogRollAbort, TestBlockReorder, TestHRegionServerBulkLoad, TestMasterFileSystemWithWALDir] - https://builds.apache.org/view/H-L/view/HBase/job/HBase-adhoc-run-tests/30/console

@the-sakthi
Copy link
Member

The tests passed continuously around ~15 times. I think we are good here. Let me merge this in. Thanks @shahrs87

@the-sakthi the-sakthi merged commit 009882b into apache:branch-1.3 Sep 12, 2019
@shahrs87
Copy link
Contributor Author

Thank you @jatsakthi for the review and commit !

@shahrs87 shahrs87 deleted the HBASE-23000 branch September 12, 2019 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-sakthi the-sakthi the-sakthi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahrs87 @Apache-HBase @the-sakthi