-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22927 Upgrade Mockito version for jdk11 #593
Conversation
…ignore class of pom. Error while rebasing so creating new one.
💔 -1 overall
This message was automatically generated. |
OK, seems good. Only one question, why not just upgrade to 2.28.2? |
Okay @Apache9 I will update the version to 2.28.2 and run the test. |
…-info is still in ignoreclass.
💔 -1 overall
This message was automatically generated. |
Oh, seems 2.28.2 is not good? |
💔 -1 overall
This message was automatically generated. |
We still need the ignore class when using Mockito 2.28.2 |
Added the module-info in ignore class again. |
💔 -1 overall
This message was automatically generated. |
Still test is failing with same error as previous one even though module-info.class was added in ignoreClass. |
We ended up doing the same thing over in the ex: |
…extra enforcer rules
Made the changes @busbey . Hopefully this will pass the test. |
💔 -1 overall
This message was automatically generated. |
…n the extra-enforcer part
💔 -1 overall
This message was automatically generated. |
…om and use the same version as parent
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 8869b8e) Change-Id: Iaacf3c68b7247c7f3ff84a762908ee4ea2e78a0e
Original PR: #584 Added module-info class in ignore class as suggested in #584 (comment). Creating a new one and hopefully this will pass the test.