HBASE-26076 Support favoredNodes when do compaction offload #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@Apache9 sir, mind help take a look at your convenience. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Aug 12, 2021
...e-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java
Show resolved
Hide resolved
| @@ -344,14 +344,27 @@ private StoreContext initializeStoreContext(ColumnFamilyDescriptor family) throw | |||
| } | |||
|
|
|||
| private InetSocketAddress[] getFavoredNodes() { | |||
| InetSocketAddress[] favoredNodes = null; | |||
There was a problem hiding this comment.
Does the code still compile after you remove this line? This is a behavior change? We have a favoredNodes class field in HStore?
| private InetSocketAddress[] favoredNodes = null; | ||
|
|
||
| public void setFavoredNodes( | ||
| List<org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos.ServerName> favoredNodes) { |
There was a problem hiding this comment.
Just use HBaseProtos.ServerName?
|
|
||
| public void setFavoredNodes( | ||
| List<org.apache.hadoop.hbase.shaded.protobuf.generated.HBaseProtos.ServerName> favoredNodes) { | ||
| if (favoredNodes != null && favoredNodes.size() > 0) { |
There was a problem hiding this comment.
CollectionUtils.isNotEmpty?
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@Apache9 mind help take a look at your convenience. |
Apache9
approved these changes
Aug 16, 2021
| if (region.getRegionServerServices() != null) { | ||
| favoredNodes = region.getRegionServerServices().getFavoredNodesForRegion( | ||
| region.getRegionInfo().getEncodedName()); | ||
| return region.getRegionServerServices() |
There was a problem hiding this comment.
So this means, if on a region server, we will get the favored nodes from region server, otherwise, use the one set by compaction server?
There was a problem hiding this comment.
Yes, the logic is like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.If we have favoredNodes for region, We use this policy
2.If we not have favoredNodes, we add the regionServer request compaction as favoredNodes when do compact on compaction server, to guarantee locality