HBASE-22238 Fix TestRpcControllerFactory #147

Apache9 · 2019-04-14T13:33:48Z

No description provided.

Apache-HBase · 2019-04-14T14:15:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	166	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21512 Compile Tests _
+1	mvninstall	254	HBASE-21512 passed
+1	compile	25	HBASE-21512 passed
+1	checkstyle	13	HBASE-21512 passed
+1	shadedjars	256	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	38	HBASE-21512 passed
+1	javadoc	14	HBASE-21512 passed
		_ Patch Compile Tests _
+1	mvninstall	243	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	13	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	261	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	505	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	45	the patch passed
+1	javadoc	14	the patch passed
		_ Other Tests _
-1	unit	446	hbase-endpoint in the patch failed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		2405

Reason	Tests
Failed junit tests	hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/2/artifact/out/Dockerfile
GITHUB PR	#147
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d173a24ec8ed 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `f47f6df`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/2/artifact/out/patch-unit-hbase-endpoint.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/2/testReport/
Max. process+thread count	3044 (vs. ulimit of 10000)
modules	C: hbase-endpoint U: hbase-endpoint
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-04-14T14:19:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	287	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21512 Compile Tests _
+1	mvninstall	285	HBASE-21512 passed
+1	compile	23	HBASE-21512 passed
+1	checkstyle	11	HBASE-21512 passed
+1	shadedjars	263	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	42	HBASE-21512 passed
+1	javadoc	14	HBASE-21512 passed
		_ Patch Compile Tests _
+1	mvninstall	268	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
+1	checkstyle	10	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	252	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	501	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	51	the patch passed
+1	javadoc	12	the patch passed
		_ Other Tests _
-1	unit	565	hbase-endpoint in the patch failed.
+1	asflicense	9	The patch does not generate ASF License warnings.
		2686

Reason	Tests
Failed junit tests	hadoop.hbase.coprocessor.TestRegionServerCoprocessorEndpoint

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/1/artifact/out/Dockerfile
GITHUB PR	#147
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e32c37092806 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `f47f6df`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/1/artifact/out/patch-unit-hbase-endpoint.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/1/testReport/
Max. process+thread count	2923 (vs. ulimit of 10000)
modules	C: hbase-endpoint U: hbase-endpoint
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

openinx · 2019-04-16T03:30:28Z

hbase-endpoint/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java

@@ -85,32 +86,15 @@ public HBaseRpcController newController(final List<CellScannable> cellIterables)

    private static Multiset<Integer> GROUPED_PRIORITY = ConcurrentHashMultiset.create();
    private static AtomicInteger INT_PRIORITY = new AtomicInteger();
-    private static AtomicInteger TABLE_PRIORITY = new AtomicInteger();


For what purpose, we need to remove the table priroirty counter ? don't understand here ...

We do not call the setPriority(TableName) method any more in async client, we will decide the priority outside the RpcController and then set with the setPriority(int) method. This is why we need to change the UT itself.

Apache-HBase · 2019-04-16T09:22:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	47	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ HBASE-21512 Compile Tests _
+1	mvninstall	264	HBASE-21512 passed
+1	compile	25	HBASE-21512 passed
+1	checkstyle	14	HBASE-21512 passed
+1	shadedjars	291	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	38	HBASE-21512 passed
+1	javadoc	14	HBASE-21512 passed
		_ Patch Compile Tests _
+1	mvninstall	248	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	14	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	272	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	523	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	44	the patch passed
+1	javadoc	14	the patch passed
		_ Other Tests _
+1	unit	252	hbase-endpoint in the patch passed.
+1	asflicense	11	The patch does not generate ASF License warnings.
		2168

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/3/artifact/out/Dockerfile
GITHUB PR	#147
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f5a601f0921e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `d8fe1bb`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/3/testReport/
Max. process+thread count	3000 (vs. ulimit of 10000)
modules	C: hbase-endpoint U: hbase-endpoint
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-147/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 force-pushed the HBASE-22238 branch from 51aa39e to 3f0a27b Compare April 14, 2019 13:34

Apache9 changed the title ~~Hbase 22238~~ HBASE-22238 Fix TestRpcControllerFactory Apr 14, 2019

openinx reviewed Apr 16, 2019

View reviewed changes

openinx approved these changes Apr 16, 2019

View reviewed changes

asfgit force-pushed the HBASE-21512 branch from 27d9e71 to d8fe1bb Compare April 16, 2019 08:27

HBASE-22238 Fix TestRpcControllerFactory

c116cca

Apache9 force-pushed the HBASE-22238 branch from 3f0a27b to c116cca Compare April 16, 2019 08:45

Apache9 merged commit 0aaf9d9 into apache:HBASE-21512 Apr 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22238 Fix TestRpcControllerFactory #147

HBASE-22238 Fix TestRpcControllerFactory #147

Apache9 commented Apr 14, 2019

Apache-HBase commented Apr 14, 2019

Apache-HBase commented Apr 14, 2019

openinx Apr 16, 2019

Apache9 Apr 16, 2019

Apache-HBase commented Apr 16, 2019

HBASE-22238 Fix TestRpcControllerFactory #147

HBASE-22238 Fix TestRpcControllerFactory #147

Conversation

Apache9 commented Apr 14, 2019

Apache-HBase commented Apr 14, 2019

Apache-HBase commented Apr 14, 2019

openinx Apr 16, 2019

Choose a reason for hiding this comment

Apache9 Apr 16, 2019

Choose a reason for hiding this comment

Apache-HBase commented Apr 16, 2019