HBASE-26122: Implement an optional maximum size for Gets, after which a partial result is returned #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bbeaudreault
force-pushed
the
max_get_size_master
branch
from
941bbfc to
4adafe7
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bbeaudreault
force-pushed
the
max_get_size_master
branch
from
4adafe7 to
3fd01e6
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
bbeaudreault
force-pushed
the
max_get_size_master
branch
from
3fd01e6 to
2b20954
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Want to make this same as the branch-2 pushed PR @bbeaudreault and then I'll commit (I couldn't forward port the branch-2 PR w/o conflict. |
… a partial result is returned
bbeaudreault
force-pushed
the
max_get_size_master
branch
from
2b20954 to
ed5d846
Compare
|
@saintstack I updated the PR to include the change from branch-2. Also see #3576, with an addendum for branch-2 |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Aug 16, 2021
There was a problem hiding this comment.
This PR seems to be doing the suggestion I made of not making a scanner context unless 'needed' (But you found out that we make a scanner context always so my suggestion was of no use). This PR needs updating @bbeaudreault ? Thanks.
|
Hey @saintstack, sorry I've been distracted by internal stuff the last few work days. But will be getting back to this this week. Yes, this PR needs to be updated based on our convo in the other PR. |
|
Do we really need to add such complexity to Gets? |
|
Thank you for your comment Anoop. The problem we face is that we have hundreds of engineers using hbase in innumerable ways, on multi-tenant clusters. People shift teams, leave, get hired, etc. When you set out to read a row from hbase, you don't always know how large that row will be. Yes I agree with you, if someone knew they were going to fetch a large row, they should do a Scan. But given the above, people often don't. This new feature acts as a guardrail against causing RegionServer pain in those cases. The way we've used this feature is we have our own TableFactory that everyone must use to get tables. The returned Table objects are wrapped. When a Get is submitted, the wrapper uses this to limit the max result size. When data is returned, we inspect the Result and throw an exception if it's a partial result. At that point the user can rewrite their query to use a Scan or add a filter, etc. We also have an escape hatch for urgent issues to allow them to go through, but that is audited. That said, I just noticed |
|
Given the above and the fact that changes are needed here anyway, I'm going to close this for now while we investigate setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of #3532 which applies against master branch. When I created the previous PR I didn't realize the convention of doing master first. That PR did not cleanly apply to master due to changes in hbase-protocol vs hbase-protocol-shaded and minor differences in HRegion.