Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-27583 Remove -X option when building protoc check in nightly an… #4988

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Jan 21, 2023

…d pre commit job

@Apache9 Apache9 self-assigned this Jan 21, 2023
@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console in case of problems.

2 similar comments
@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console in case of problems.

@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console in case of problems.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 46s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
_ Other Tests _
4m 1s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4988
Optional Tests
uname Linux 75890fd051be 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d450d
Max. process+thread count 33 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 4s Maven dependency ordering for patch
+1 💚 shellcheck 0m 1s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 39s patch has no errors when running spotless:check.
_ Other Tests _
+0 🆗 asflicense 0m 1s ASF License check generated no output?
5m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4988
Optional Tests dupname asflicense spotless shellcheck shelldocs
uname Linux fe5f95d38220 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d450d
Max. process+thread count 44 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console
versions git=2.34.1 maven=3.8.6 shellcheck=0.8.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 56s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 5s Maven dependency ordering for patch
_ Other Tests _
6m 3s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4988
Optional Tests
uname Linux d8527789d70a 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 83d450d
Max. process+thread count 42 (vs. ulimit of 30000)
modules C: U:
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4988/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bbeaudreault bbeaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change makes sense to me. -X is incredibly verbose, so not sure it's useful unless explicitly debugging.

I wonder if we should enable -X when someone checks this checkbox:

Screen Shot 2023-01-24 at 9 45 17 AM

I have no idea how we'd pipe that through, so feel free to disregard. Just a thought.

@Apache9
Copy link
Contributor Author

Apache9 commented Jan 24, 2023

this change makes sense to me. -X is incredibly verbose, so not sure it's useful unless explicitly debugging.

I wonder if we should enable -X when someone checks this checkbox:

Screen Shot 2023-01-24 at 9 45 17 AM

I have no idea how we'd pipe that through, so feel free to disregard. Just a thought.

We could check if we could do this later. Let's solve the space problem first. And IIRC we do have some places to add the -X option when DEBUG is enabled.

@Apache9 Apache9 merged commit 5bdf264 into apache:master Jan 24, 2023
Apache9 added a commit that referenced this pull request Jan 24, 2023
…d pre commit job (#4988)

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 5bdf264)
Apache9 added a commit that referenced this pull request Jan 24, 2023
…d pre commit job (#4988)

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 5bdf264)
Apache9 added a commit that referenced this pull request Jan 24, 2023
…d pre commit job (#4988)

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 5bdf264)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…d pre commit job (apache#4988)

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
(cherry picked from commit 5bdf264)
(cherry picked from commit 45d0df7)
Change-Id: Idfe2929d68a5f943ac2735a7f593918147e60033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants