HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator #140

Apache9 · 2019-04-12T09:54:31Z

No description provided.

Apache-HBase · 2019-04-12T13:08:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	24	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ HBASE-21512 Compile Tests _
0	mvndep	33	Maven dependency ordering for branch
+1	mvninstall	246	HBASE-21512 passed
+1	compile	76	HBASE-21512 passed
+1	checkstyle	98	HBASE-21512 passed
+1	shadedjars	260	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	213	HBASE-21512 passed
+1	javadoc	54	HBASE-21512 passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	236	the patch passed
+1	compile	72	the patch passed
+1	javac	72	the patch passed
-1	checkstyle	29	hbase-client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	252	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	489	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	254	the patch passed
+1	javadoc	53	the patch passed
		_ Other Tests _
+1	unit	193	hbase-client in the patch passed.
-1	unit	8677	hbase-server in the patch failed.
+1	asflicense	55	The patch does not generate ASF License warnings.
		11492

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
	hadoop.hbase.client.TestBufferedMutator
	hadoop.hbase.client.TestHbck

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/artifact/out/Dockerfile
GITHUB PR	#140
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 746e25029f57 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `f47f6df`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/artifact/out/diff-checkstyle-hbase-client.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/testReport/
Max. process+thread count	4785 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-04-12T17:34:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	18	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ HBASE-21512 Compile Tests _
0	mvndep	13	Maven dependency ordering for branch
+1	mvninstall	261	HBASE-21512 passed
+1	compile	79	HBASE-21512 passed
+1	checkstyle	104	HBASE-21512 passed
+1	shadedjars	272	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	246	HBASE-21512 passed
+1	javadoc	55	HBASE-21512 passed
		_ Patch Compile Tests _
0	mvndep	13	Maven dependency ordering for patch
+1	mvninstall	254	the patch passed
+1	compile	78	the patch passed
+1	javac	78	the patch passed
+1	checkstyle	105	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	275	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	533	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	298	the patch passed
+1	javadoc	62	the patch passed
		_ Other Tests _
+1	unit	202	hbase-client in the patch passed.
-1	unit	9160	hbase-server in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		12186

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
	hadoop.hbase.replication.TestReplicationDroppedTables
	hadoop.hbase.client.TestHbck

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/2/artifact/out/Dockerfile
GITHUB PR	#140
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9badbcb24f6d 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `f47f6df`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/2/testReport/
Max. process+thread count	4893 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet

Because you deprecated some stuff, could you please add since which version it is deprecated and in which version it will be removed. An example:

@deprecated Since 2.0.0. Will be removed in 3.0.0. Use {@link CompareOperator} instead.

Apache-HBase · 2019-04-14T17:29:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	44	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 2 new or modified test files.
		_ HBASE-21512 Compile Tests _
0	mvndep	27	Maven dependency ordering for branch
+1	mvninstall	268	HBASE-21512 passed
+1	compile	81	HBASE-21512 passed
+1	checkstyle	108	HBASE-21512 passed
+1	shadedjars	280	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	289	HBASE-21512 passed
+1	javadoc	61	HBASE-21512 passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	270	the patch passed
+1	compile	86	the patch passed
+1	javac	86	the patch passed
+1	checkstyle	108	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	285	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	546	Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1	findbugs	267	the patch passed
+1	javadoc	56	the patch passed
		_ Other Tests _
+1	unit	194	hbase-client in the patch passed.
-1	unit	14635	hbase-server in the patch failed.
+1	asflicense	51	The patch does not generate ASF License warnings.
		17766

Reason	Tests
Failed junit tests	hadoop.hbase.quotas.TestSpaceQuotas
	hadoop.hbase.master.procedure.TestSCPWithReplicas

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/artifact/out/Dockerfile
GITHUB PR	#140
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7cf768ed521d 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	HBASE-21512 / `f47f6df`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/testReport/
Max. process+thread count	4640 (vs. ulimit of 10000)
modules	C: hbase-client hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-140/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Apache9 · 2019-04-15T14:30:58Z

Ping @HorizonNet . Any other concerns? Thanks.

HorizonNet · 2019-04-15T14:36:27Z

@Apache9 No, my points are addressed.

Apache9 force-pushed the HBASE-21725 branch from 58e1a3c to 4210ca9 Compare April 12, 2019 13:53

HorizonNet requested changes Apr 13, 2019

View reviewed changes

HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator

6c5ebff

Apache9 force-pushed the HBASE-21725 branch from 4210ca9 to 6c5ebff Compare April 14, 2019 12:32

Apache9 requested a review from HorizonNet April 15, 2019 07:51

infraio approved these changes Apr 15, 2019

View reviewed changes

HorizonNet approved these changes Apr 15, 2019

View reviewed changes

Apache9 merged commit 27d9e71 into apache:HBASE-21512 Apr 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator #140

HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator #140

Apache9 commented Apr 12, 2019

Apache-HBase commented Apr 12, 2019

Apache-HBase commented Apr 12, 2019

HorizonNet left a comment

Apache-HBase commented Apr 14, 2019

Apache9 commented Apr 15, 2019

HorizonNet commented Apr 15, 2019

HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator #140

HBASE-21725 Implement BufferedMutator Based on AsyncBufferedMutator #140

Conversation

Apache9 commented Apr 12, 2019

Apache-HBase commented Apr 12, 2019

Apache-HBase commented Apr 12, 2019

HorizonNet left a comment

Choose a reason for hiding this comment

Apache-HBase commented Apr 14, 2019

Apache9 commented Apr 15, 2019

HorizonNet commented Apr 15, 2019