-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22275 Removed deprecated getRegionInfo in HRegionLocation #170
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch looks great. Approved pending question answer is that classes changed are private and not public.
hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
Show resolved
Hide resolved
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
Show resolved
Hide resolved
Go for it @HorizonNet Thanks for answering my question. |
No problem. Currently waiting for a +1 from the build. I think the failing test is not related, but just want to play safe. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Updated the PR to fix the failing shell tests. |
💔 -1 overall
This message was automatically generated. |
Fixed the Rubocop warnings from the last build. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Will wait on this one until HBASE-22358 is in, which should solve the rubocop issue. |
738097f
to
b054fa2
Compare
💔 -1 overall
This message was automatically generated. |
No description provided.