Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-28120 Switch that allows avoiding reopening all regions when altering table #5482

Closed
wants to merge 4 commits into from
Closed

HBASE-28120 Switch that allows avoiding reopening all regions when altering table #5482

wants to merge 4 commits into from

Conversation

gourabtaparia
Copy link

  • This is to prevent RIT storms.
  • The changes have been made in both alter and alter sync commands.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 43s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 8s Maven dependency ordering for branch
+1 💚 mvninstall 3m 12s branch-2 passed
+1 💚 compile 5m 52s branch-2 passed
+1 💚 checkstyle 1m 49s branch-2 passed
+1 💚 spotless 0m 52s branch has no errors when running spotless:check.
+1 💚 spotbugs 6m 15s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 3m 14s the patch passed
+1 💚 compile 5m 4s the patch passed
+1 💚 cc 5m 4s the patch passed
+1 💚 javac 5m 4s the patch passed
-0 ⚠️ checkstyle 0m 20s hbase-client: The patch generated 3 new + 11 unchanged - 0 fixed = 14 total (was 11)
-0 ⚠️ checkstyle 0m 40s hbase-server: The patch generated 3 new + 9 unchanged - 0 fixed = 12 total (was 9)
-0 ⚠️ rubocop 0m 12s The patch generated 9 new + 419 unchanged - 5 fixed = 428 total (was 424)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 15m 31s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚 hbaseprotoc 2m 36s the patch passed
-1 ❌ spotless 0m 23s patch has 65 errors when running spotless:check, run spotless:apply to fix.
+1 💚 spotbugs 7m 46s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
59m 16s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5482
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux 0e1a673f6d6c 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Eclipse Adoptium-11.0.17+8
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 82 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 27s branch-2 passed
+1 💚 compile 1m 44s branch-2 passed
+1 💚 shadedjars 4m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 10s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 8s the patch passed
+1 💚 compile 1m 47s the patch passed
+1 💚 javac 1m 47s the patch passed
+1 💚 shadedjars 4m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 9s the patch passed
_ Other Tests _
+1 💚 unit 0m 23s hbase-protocol-shaded in the patch passed.
+1 💚 unit 7m 48s hbase-client in the patch passed.
+1 💚 unit 205m 18s hbase-server in the patch passed.
+1 💚 unit 6m 54s hbase-thrift in the patch passed.
+1 💚 unit 7m 39s hbase-shell in the patch passed.
254m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5482
Optional Tests javac javadoc unit shadedjars compile
uname Linux dfbd08ad8056 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/testReport/
Max. process+thread count 4591 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 15s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 46s branch-2 passed
+1 💚 compile 2m 23s branch-2 passed
+1 💚 shadedjars 4m 54s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 36s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 2m 34s the patch passed
+1 💚 compile 2m 22s the patch passed
+1 💚 javac 2m 22s the patch passed
+1 💚 shadedjars 4m 53s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 32s the patch passed
_ Other Tests _
+1 💚 unit 0m 35s hbase-protocol-shaded in the patch passed.
+1 💚 unit 8m 25s hbase-client in the patch passed.
+1 💚 unit 210m 28s hbase-server in the patch passed.
+1 💚 unit 7m 7s hbase-thrift in the patch passed.
+1 💚 unit 9m 25s hbase-shell in the patch passed.
265m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5482
Optional Tests javac javadoc unit shadedjars compile
uname Linux 504b62217693 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/testReport/
Max. process+thread count 4526 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 50s branch-2 passed
+1 💚 compile 4m 43s branch-2 passed
+1 💚 checkstyle 1m 39s branch-2 passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
+1 💚 spotbugs 5m 18s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 2m 36s the patch passed
+1 💚 compile 4m 43s the patch passed
+1 💚 cc 4m 43s the patch passed
+1 💚 javac 4m 43s the patch passed
-0 ⚠️ checkstyle 0m 36s hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️ rubocop 0m 10s The patch generated 10 new + 419 unchanged - 5 fixed = 429 total (was 424)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 29s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚 hbaseprotoc 1m 53s the patch passed
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
+1 💚 spotbugs 5m 49s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
50m 31s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5482
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux ad92df725f4d 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Eclipse Adoptium-11.0.17+8
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil
wchevreuil reviewed Oct 30, 2023
View reviewed changes
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java Outdated
Comment on lines 1532 to 1539
@Deprecated
default void modifyTable(TableName tableName, TableDescriptor td, boolean reopenRegions)
throws IOException {
if (!tableName.equals(td.getTableName())) {
throw new IllegalArgumentException("the specified table name '" + tableName
+ "' doesn't match with the HTD one: " + td.getTableName());
}
modifyTable(td, reopenRegions);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add a new method already marked as deprecated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wchevreuil The existing deprecated method needs to be passed an extra argument from, hence added this - but I see that i can reuse the logic in the existing method, and just call that from this method.

Btw, in my local refactoring, i now am not even calling this method - and directly making use of the "modifyTableAsync(TableDescriptor td, boolean reopenRegions)" method - so i can remove this altogether.

let me make that change. Thanks

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 39s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 24s branch-2 passed
+1 💚 compile 2m 3s branch-2 passed
+1 💚 shadedjars 4m 33s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 20s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 12s the patch passed
+1 💚 compile 2m 3s the patch passed
+1 💚 javac 2m 3s the patch passed
+1 💚 shadedjars 4m 31s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 21s the patch passed
_ Other Tests _
+1 💚 unit 0m 28s hbase-protocol-shaded in the patch passed.
+1 💚 unit 7m 57s hbase-client in the patch passed.
+1 💚 unit 220m 11s hbase-server in the patch passed.
+1 💚 unit 7m 45s hbase-thrift in the patch passed.
+1 💚 unit 7m 1s hbase-shell in the patch passed.
273m 23s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5482
Optional Tests javac javadoc unit shadedjars compile
uname Linux a7318fbf6d51 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/testReport/
Max. process+thread count 4853 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 49s branch-2 passed
+1 💚 compile 2m 21s branch-2 passed
+1 💚 shadedjars 4m 56s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 36s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 2m 39s the patch passed
+1 💚 compile 2m 23s the patch passed
+1 💚 javac 2m 23s the patch passed
+1 💚 shadedjars 4m 56s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 35s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s hbase-protocol-shaded in the patch passed.
+1 💚 unit 7m 28s hbase-client in the patch passed.
+1 💚 unit 221m 24s hbase-server in the patch passed.
+1 💚 unit 8m 45s hbase-thrift in the patch passed.
+1 💚 unit 7m 7s hbase-shell in the patch passed.
274m 42s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5482
Optional Tests javac javadoc unit shadedjars compile
uname Linux 643e14923839 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/testReport/
Max. process+thread count 4767 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/2/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 prototool 0m 0s prototool was not available.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 34s branch-2 passed
+1 💚 compile 4m 47s branch-2 passed
+1 💚 checkstyle 1m 35s branch-2 passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
+1 💚 spotbugs 5m 13s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 37s the patch passed
+1 💚 compile 4m 43s the patch passed
+1 💚 cc 4m 43s the patch passed
+1 💚 javac 4m 43s the patch passed
-0 ⚠️ checkstyle 0m 37s hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9)
-0 ⚠️ rubocop 0m 8s The patch generated 10 new + 419 unchanged - 5 fixed = 429 total (was 424)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 13m 21s Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6.
+1 💚 hbaseprotoc 1m 53s the patch passed
+1 💚 spotless 0m 43s patch has no errors when running spotless:check.
+1 💚 spotbugs 5m 54s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
49m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5482
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile cc hbaseprotoc prototool rubocop
uname Linux f701707aa208 5.4.0-156-generic #173-Ubuntu SMP Tue Jul 11 07:25:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Eclipse Adoptium-11.0.17+8
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 80 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 43s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 29s branch-2 passed
+1 💚 compile 1m 47s branch-2 passed
+1 💚 shadedjars 5m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 13s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 1m 52s the patch passed
+1 💚 javac 1m 52s the patch passed
+1 💚 shadedjars 5m 10s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 12s the patch passed
_ Other Tests _
+1 💚 unit 0m 24s hbase-protocol-shaded in the patch passed.
+1 💚 unit 7m 54s hbase-client in the patch passed.
+1 💚 unit 211m 38s hbase-server in the patch passed.
+1 💚 unit 6m 42s hbase-thrift in the patch passed.
+1 💚 unit 7m 47s hbase-shell in the patch passed.
261m 7s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5482
Optional Tests javac javadoc unit shadedjars compile
uname Linux b87c318ee715 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/testReport/
Max. process+thread count 4520 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 16s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 53s branch-2 passed
+1 💚 compile 2m 22s branch-2 passed
+1 💚 shadedjars 4m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 35s branch-2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 2m 35s the patch passed
+1 💚 compile 2m 22s the patch passed
+1 💚 javac 2m 22s the patch passed
+1 💚 shadedjars 4m 55s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 35s the patch passed
_ Other Tests _
+1 💚 unit 0m 35s hbase-protocol-shaded in the patch passed.
+1 💚 unit 8m 26s hbase-client in the patch passed.
+1 💚 unit 208m 54s hbase-server in the patch passed.
+1 💚 unit 7m 10s hbase-thrift in the patch passed.
+1 💚 unit 9m 16s hbase-shell in the patch passed.
263m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5482
Optional Tests javac javadoc unit shadedjars compile
uname Linux 11df3c444e7f 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2 / 4f3e63e
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/testReport/
Max. process+thread count 4407 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5482/3/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
Copy link
Contributor

Closing this, as it was decided to cherry-pick HBASE-25549 into branch-2.

@wchevreuil wchevreuil closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wchevreuil wchevreuil wchevreuil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gourabtaparia @Apache-HBase @wchevreuil