-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should closing flag be set false in HRegion.java #105
Conversation
refer: HBASE-21593
@zhengxle Could you please update the commit message to include the Jira ticket ID? See the appropriate documentation for more details. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I should close out this PR since it has been around a while unaddressed.
@@ -1710,6 +1710,7 @@ public void setTimeoutForWriteLock(long timeoutForWriteLock) { | |||
LOG.info("Closed " + this); | |||
return result; | |||
} finally { | |||
this.closing.set(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this addresses problem in the issue and what the benefit is here?
Closed old PR that has gone months w/o update. |
refer: HBASE-21593