HBASE-27923 NettyRpcServer may hange if it should skip initial sasl h… #5281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Jun 9, 2023
| @@ -125,7 +125,9 @@ protected void initChannel(Channel ch) throws Exception { | |||
| initSSL(pipeline, conf.getBoolean(HBASE_SERVER_NETTY_TLS_SUPPORTPLAINTEXT, true)); | |||
| } | |||
| pipeline.addLast(NettyRpcServerPreambleHandler.DECODER_NAME, preambleDecoder) | |||
| .addLast(createNettyRpcServerPreambleHandler()); | |||
| .addLast(createNettyRpcServerPreambleHandler()) | |||
| .addLast(NettyRpcServerResponseEncoder.HANDLER_NAME, | |||
There was a problem hiding this comment.
Better add some comments to say that why we need to add encoder here
There was a problem hiding this comment.
@Apache9 , thanks for review，already added some comments.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Jun 9, 2023
| @@ -31,6 +31,8 @@ | |||
| @InterfaceAudience.Private | |||
| class NettyRpcServerResponseEncoder extends ChannelOutboundHandlerAdapter { | |||
|
|
|||
| static final String HANDLER_NAME = "NettyRpcServerResponseEncoder"; | |||
There was a problem hiding this comment.
nit: rename it as "ENCODER_NAME"?
There was a problem hiding this comment.
@wchevreuil, thanks for review，here I did not name it as "ENCODER_NAME" because it is misleading and is also inconsistent with the naming conventions of other netty handlers, here this name represents NettyRpcServerResponseEncoder itself，but for other netty handler such as NettyRpcServerPreambleHandle,NettyRpcServerPreambleHandler.DECODER_NAME represents decoder handler before it, not represents itself. I have ready renamed it as "NAME" to keep consistent with the naming conventions of other netty handlers. What is your opinion？
Apache9
approved these changes
Jun 10, 2023
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thank you @comnetwork, you are planning to merge this to all active branches (till 2.4), correct? |
|
@virajjasani , I think this problem only exists on 2.6+, because it is introduced by HBASE-27279 and HBASE-27185，which only applied to 2.6+ . However, I would apply the UT to branch-2.4 and branch-2.5 |
asfgit
pushed a commit
that referenced
this pull request
Jun 12, 2023
#5281) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Wellington Chevreuil <wchevreuil@apache.rog>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…andshake