HBASE-27874 Problem in flakey generated report causes pre-commit run to fail #5244

wchevreuil · 2023-05-18T15:03:02Z

No description provided.

…to fail Change-Id: I68aca8c5216e03120a848ee9bfc020a9b5cdcbc2

Apache-HBase · 2023-05-18T15:12:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 4s	Maven dependency ordering for patch
		_ Other Tests _
		2m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5244
Optional Tests
uname	Linux 987ad9387732 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `2fc7358`
Max. process+thread count	37 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-18T15:12:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 3s	Maven dependency ordering for patch
		_ Other Tests _
		1m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5244
Optional Tests
uname	Linux 00f4ff9de6b8 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `2fc7358`
Max. process+thread count	30 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-18T15:14:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 5s	Maven dependency ordering for patch
+1 💚	pylint	0m 3s	There were no new pylint issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
		_ Other Tests _
+0 🆗	asflicense	0m 1s	ASF License check generated no output?
		3m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5244
Optional Tests	dupname asflicense spotless pylint
uname	Linux 757152d118e7 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `2fc7358`
Max. process+thread count	45 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/1/console
versions	git=2.34.1 maven=3.8.6 pylint=2.15.5
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Kota-SH

LGTM, thank you!

petersomogyi

Why is this targeted for branch-2? Isn't it required on master as well?

Apache9

Better add some comments to explain the logic? And this should be applied to master as well?

wchevreuil · 2023-05-19T15:10:54Z

Why is this targeted for branch-2? Isn't it required on master as well?

So far, I had only seen this in branch-2, but it may also affect master. It all depends on the maven output for last nightly build, if that comes with a malformed line like below, then the issue would surface:

[INFO] Running org.apache.hadoop.hbase.conf.TestConfigurationManagerWARNING: package jdk.internal.util.random not in java.base

Change-Id: Ib9165a994185f364387f78087a5585cac5ee562e

Apache-HBase · 2023-05-19T15:36:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 3s	Maven dependency ordering for patch
		_ Other Tests _
		1m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5244
Optional Tests
uname	Linux 7efed48e6565 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `e70b468`
Max. process+thread count	40 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-19T15:37:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 4s	Maven dependency ordering for patch
		_ Other Tests _
		1m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5244
Optional Tests
uname	Linux 93821fc6197b 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `e70b468`
Max. process+thread count	32 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-19T15:39:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 6s	Maven dependency ordering for branch
+1 💚	spotless	0m 49s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 4s	Maven dependency ordering for patch
+1 💚	pylint	0m 3s	There were no new pylint issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 55s	patch has no errors when running spotless:check.
		_ Other Tests _
+0 🆗	asflicense	0m 0s	ASF License check generated no output?
		3m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5244
Optional Tests	dupname asflicense spotless pylint
uname	Linux a059b2da1d50 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `e70b468`
Max. process+thread count	43 (vs. ulimit of 30000)
modules	C: U:
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5244/2/console
versions	git=2.34.1 maven=3.8.6 pylint=2.15.5
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2023-05-22T02:51:37Z

Anyway, let's merge this to branch-2 first and then forward cherry-pick to master, as now branch-2 nightly is failing.

…to fail (#5244) Forward cherry-pick from branch-2. Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewew-by: Kota-SH <shanmukhaharipriya@gmail.com> (cherry picked from commit 0ba562a)

…to fail (#5244) Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewew-by: Kota-SH <shanmukhaharipriya@gmail.com> (cherry picked from commit 0ba562a)

…to fail (apache#5244) Signed-off-by: Peter Somogyi <psomogyi@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> Reviewew-by: Kota-SH <shanmukhaharipriya@gmail.com> (cherry picked from commit 0ba562a) (cherry picked from commit 4348695) Change-Id: I9d9518893b6559cb25addd843e537281c7ad6b9c

HBASE-27874 Problem in flakey generated report causes pre-commit run …

21ebe8a

…to fail Change-Id: I68aca8c5216e03120a848ee9bfc020a9b5cdcbc2

Kota-SH approved these changes May 18, 2023

View reviewed changes

petersomogyi approved these changes May 19, 2023

View reviewed changes

Apache9 reviewed May 19, 2023

View reviewed changes

added comments

7f55a2c

Change-Id: Ib9165a994185f364387f78087a5585cac5ee562e

petersomogyi approved these changes May 21, 2023

View reviewed changes

Apache9 changed the base branch from branch-2 to master May 22, 2023 02:50

Apache9 changed the base branch from master to branch-2 May 22, 2023 02:51

Apache9 approved these changes May 22, 2023

View reviewed changes

Apache9 merged commit 0ba562a into apache:branch-2 May 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27874 Problem in flakey generated report causes pre-commit run to fail #5244

HBASE-27874 Problem in flakey generated report causes pre-commit run to fail #5244

wchevreuil commented May 18, 2023

Apache-HBase commented May 18, 2023

Apache-HBase commented May 18, 2023

Apache-HBase commented May 18, 2023

Kota-SH left a comment

petersomogyi left a comment

Apache9 left a comment

wchevreuil commented May 19, 2023 •

edited

Loading

Apache-HBase commented May 19, 2023

Apache-HBase commented May 19, 2023

Apache-HBase commented May 19, 2023

Apache9 commented May 22, 2023

HBASE-27874 Problem in flakey generated report causes pre-commit run to fail #5244

HBASE-27874 Problem in flakey generated report causes pre-commit run to fail #5244

Conversation

wchevreuil commented May 18, 2023

Apache-HBase commented May 18, 2023

Apache-HBase commented May 18, 2023

Apache-HBase commented May 18, 2023

Kota-SH left a comment

Choose a reason for hiding this comment

petersomogyi left a comment

Choose a reason for hiding this comment

Apache9 left a comment

Choose a reason for hiding this comment

wchevreuil commented May 19, 2023 • edited Loading

Apache-HBase commented May 19, 2023

Apache-HBase commented May 19, 2023

Apache-HBase commented May 19, 2023

Apache9 commented May 22, 2023

wchevreuil commented May 19, 2023 •

edited

Loading