-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform #5286
Conversation
…ith mac m1 platfrom
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
What if we just change the original dockerfile? It will break normal x86 or arm platform? |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Any updates here? |
Ping @wchevreuil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all a sudden I upgraded my laptop and found this ....PR and fixed my issue, so +1
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
FROM --platform=linux/amd64 ubuntu:22.04 AS base_image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--platform=linux/amd64
should be the only change, so it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right way to do things. Instead, you should provide --platform
to the docker command line invocation when building the image. That will cause it to pull down the ubuntu image of the specified platform.
I left a comment on the Jira with an example of how to do a multi-platform docker image. It's not the only way to do it, but it's the style I've been using in the kustomize repo. Yetus project may have an alternative example of how to achieve this.
@wchevreuil maybe you can fix the style issue? |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
No description provided.