HBASE-27498: Added logic in ConnectionImplementation.getKeepAliveMasterService to avoid expensive rpc calls in synchronized block #4889

vaijosh · 2022-11-19T07:46:39Z

No description provided.

…on't need to make expensive rpc calls in synchronize block.

Apache-HBase · 2022-11-19T08:08:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 30s	branch-2.5 passed
+1 💚	compile	0m 17s	branch-2.5 passed
+1 💚	shadedjars	3m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 6s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	3m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 31s	hbase-client in the patch passed.
		18m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 483470f8d88a 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `4bf0523`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/testReport/
Max. process+thread count	164 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-19T08:10:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 52s	branch-2.5 passed
+1 💚	compile	0m 21s	branch-2.5 passed
+1 💚	shadedjars	4m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 21s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	3m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 51s	hbase-client in the patch passed.
		19m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cdcff9774e2a 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `4bf0523`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/testReport/
Max. process+thread count	191 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-19T08:16:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 55s	branch-2.5 passed
+1 💚	compile	0m 47s	branch-2.5 passed
+1 💚	checkstyle	0m 18s	branch-2.5 passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 53s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 43s	the patch passed
-0 ⚠️	javac	0m 43s	hbase-client generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111)
-0 ⚠️	checkstyle	0m 19s	hbase-client: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 41s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
-1 ❌	spotless	0m 19s	patch has 57 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	0m 57s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		26m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ec575946b40e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `4bf0523`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	76 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-19T09:08:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 54s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 19s	branch-2.5 passed
+1 💚	compile	0m 17s	branch-2.5 passed
+1 💚	shadedjars	3m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 16s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	3m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 38s	hbase-client in the patch passed.
		17m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6ebef91fca9d 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `4bf0523`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/testReport/
Max. process+thread count	173 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-19T09:09:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 29s	branch-2.5 passed
+1 💚	compile	0m 21s	branch-2.5 passed
+1 💚	shadedjars	3m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	0m 21s	the patch passed
+1 💚	javac	0m 21s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 19s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 56s	hbase-client in the patch passed.
		19m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d21d1785dd34 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `4bf0523`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/testReport/
Max. process+thread count	192 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-19T09:15:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 31s	branch-2.5 passed
+1 💚	compile	0m 43s	branch-2.5 passed
+1 💚	checkstyle	0m 19s	branch-2.5 passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 47s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 28s	the patch passed
+1 💚	compile	0m 45s	the patch passed
-0 ⚠️	javac	0m 45s	hbase-client generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111)
+1 💚	checkstyle	0m 18s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 22s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 55s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		25m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 8f71a996622f 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `4bf0523`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu

mostly LGTM, but IMO this feature may be better to disable by default.

please also add unit tests for when it's enabled and disabled, such we use it as a regression test.

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java

bbeaudreault · 2022-11-21T23:26:05Z

I was wondering if we should just convert to AsyncAdmin. We did a similar conversion to AsyncTable in Replication recently.

Apache-HBase · 2022-11-25T06:24:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 49s	branch-2.5 passed
+1 💚	compile	0m 21s	branch-2.5 passed
+1 💚	shadedjars	3m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 52s	hbase-client in the patch passed.
		19m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0a90a583a149 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/testReport/
Max. process+thread count	196 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T06:26:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	3m 31s	branch-2.5 passed
+1 💚	compile	0m 22s	branch-2.5 passed
+1 💚	shadedjars	4m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 18s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 56s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	4m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 46s	hbase-client in the patch passed.
		21m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d30b140d9595 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/testReport/
Max. process+thread count	171 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…e timeout is 0 i.e. legacy behavior. 2.Added integration test around new property

Apache-HBase · 2022-11-25T06:35:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+1 💚	mvninstall	2m 50s	branch-2.5 passed
+1 💚	compile	0m 45s	branch-2.5 passed
+1 💚	checkstyle	0m 20s	branch-2.5 passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 51s	branch-2.5 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	0m 43s	the patch passed
-0 ⚠️	javac	0m 43s	hbase-client generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111)
+1 💚	checkstyle	0m 18s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 48s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		30m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 1c44f591814c 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

vaijosh · 2022-11-25T06:35:47Z

@bbeaudreault

I was wondering if we should just convert to AsyncAdmin. We did a similar conversion to AsyncTable in Replication recently.
Thanks for the feedback. Yes Async is the right approach. In fact in master branch we Async implementation. But I believe it was not implemented in 2.5 branch because its major change. So I think point fix here will make more sense.

Apache-HBase · 2022-11-25T06:58:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 18s	branch-2.5 passed
+1 💚	compile	0m 35s	branch-2.5 passed
+1 💚	shadedjars	4m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 19s	the patch passed
+1 💚	compile	0m 33s	the patch passed
+1 💚	javac	0m 33s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 42s	hbase-client in the patch passed.
+1 💚	unit	1m 26s	hbase-it in the patch passed.
		21m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 97e7e497b17f 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/testReport/
Max. process+thread count	773 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T06:58:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 40s	branch-2.5 passed
+1 💚	compile	0m 41s	branch-2.5 passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	0m 42s	the patch passed
+1 💚	javac	0m 42s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 51s	hbase-client in the patch passed.
+1 💚	unit	1m 3s	hbase-it in the patch passed.
		22m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 512b1db034a6 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/testReport/
Max. process+thread count	813 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T07:04:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 36s	branch-2.5 passed
+1 💚	compile	1m 10s	branch-2.5 passed
+1 💚	checkstyle	0m 30s	branch-2.5 passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 12s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	1m 9s	the patch passed
-0 ⚠️	javac	0m 43s	hbase-client generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111)
-0 ⚠️	javac	0m 26s	hbase-it generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)
+1 💚	checkstyle	0m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 34s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
-1 ❌	spotless	0m 19s	patch has 25 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		28m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 17f4a4216e52 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	75 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T07:56:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 16s	branch-2.5 passed
+1 💚	compile	0m 34s	branch-2.5 passed
+1 💚	shadedjars	4m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 25s	the patch passed
+1 💚	compile	0m 35s	the patch passed
+1 💚	javac	0m 35s	the patch passed
+1 💚	shadedjars	3m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 37s	hbase-client in the patch passed.
+1 💚	unit	1m 26s	hbase-it in the patch passed.
		21m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 73a5540361dd 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/testReport/
Max. process+thread count	785 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T07:58:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 31s	branch-2.5 passed
+1 💚	compile	0m 41s	branch-2.5 passed
+1 💚	shadedjars	3m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	0m 41s	the patch passed
+1 💚	javac	0m 41s	the patch passed
+1 💚	shadedjars	3m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 55s	hbase-client in the patch passed.
+1 💚	unit	1m 35s	hbase-it in the patch passed.
		22m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f8516e6d90b5 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/testReport/
Max. process+thread count	826 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T08:03:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s	branch-2.5 passed
+1 💚	compile	1m 10s	branch-2.5 passed
+1 💚	checkstyle	0m 29s	branch-2.5 passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 13s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	compile	1m 11s	the patch passed
-0 ⚠️	javac	0m 44s	hbase-client generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111)
-0 ⚠️	javac	0m 27s	hbase-it generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)
+1 💚	checkstyle	0m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 33s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
-1 ❌	spotless	0m 39s	patch has 21 errors when running spotless:check, run spotless:apply to fix.
+1 💚	spotbugs	1m 29s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		28m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 6d835965c2b5 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/6/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T08:42:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s	branch-2.5 passed
+1 💚	compile	0m 39s	branch-2.5 passed
+1 💚	shadedjars	3m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	0m 42s	the patch passed
+1 💚	javac	0m 42s	the patch passed
+1 💚	shadedjars	3m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 57s	hbase-client in the patch passed.
+1 💚	unit	1m 3s	hbase-it in the patch passed.
		22m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 91b2e789701f 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/testReport/
Max. process+thread count	811 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T08:45:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 56s	branch-2.5 passed
+1 💚	compile	0m 40s	branch-2.5 passed
+1 💚	shadedjars	4m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	0m 39s	the patch passed
+1 💚	javac	0m 39s	the patch passed
+1 💚	shadedjars	4m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 52s	hbase-client in the patch passed.
-1 ❌	unit	1m 55s	hbase-it in the patch failed.
		25m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 94e01deedac8 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-it.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/testReport/
Max. process+thread count	794 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-25T08:49:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 33s	branch-2.5 passed
+1 💚	compile	1m 13s	branch-2.5 passed
+1 💚	checkstyle	0m 30s	branch-2.5 passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 11s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	1m 11s	the patch passed
-0 ⚠️	javac	0m 44s	hbase-client generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111)
-0 ⚠️	javac	0m 27s	hbase-it generated 1 new + 30 unchanged - 0 fixed = 31 total (was 30)
+1 💚	checkstyle	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 24s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 29s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		28m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b6b33871eb0b 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2171cdd`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/artifact/yetus-general-check/output/diff-compile-javac-hbase-it.txt
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/7/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-02T14:05:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 49s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 23s	branch-2.5 passed
+1 💚	compile	0m 31s	branch-2.5 passed
+1 💚	shadedjars	3m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
-1 ❌	mvninstall	2m 5s	root in the patch failed.
-1 ❌	compile	0m 15s	hbase-it in the patch failed.
-0 ⚠️	javac	0m 15s	hbase-it in the patch failed.
+1 💚	shadedjars	3m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 34s	hbase-client in the patch passed.
-1 ❌	unit	0m 15s	hbase-it in the patch failed.
		20m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c29d224638b9 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1bfc58a`
Default Java	Temurin-1.8.0_352-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-it.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-it.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-it.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/testReport/
Max. process+thread count	173 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-02T14:07:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 39s	branch-2.5 passed
+1 💚	compile	0m 41s	branch-2.5 passed
+1 💚	shadedjars	3m 52s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 33s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
-1 ❌	mvninstall	2m 34s	root in the patch failed.
-1 ❌	compile	0m 20s	hbase-it in the patch failed.
-0 ⚠️	javac	0m 20s	hbase-it in the patch failed.
+1 💚	shadedjars	3m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 52s	hbase-client in the patch passed.
-1 ❌	unit	0m 19s	hbase-it in the patch failed.
		21m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0e954361eae8 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1bfc58a`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-it.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-it.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-it.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/testReport/
Max. process+thread count	198 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-02T14:08:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 39s	branch-2.5 passed
+1 💚	compile	1m 10s	branch-2.5 passed
+1 💚	checkstyle	0m 30s	branch-2.5 passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 12s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
-1 ❌	mvninstall	2m 39s	root in the patch failed.
-1 ❌	compile	0m 20s	hbase-it in the patch failed.
-0 ⚠️	javac	0m 42s	hbase-client generated 1 new + 110 unchanged - 1 fixed = 111 total (was 111)
-0 ⚠️	javac	0m 20s	hbase-it in the patch failed.
+1 💚	checkstyle	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	1m 52s	The patch causes 16 errors with Hadoop v2.10.2.
-1 ❌	hadoopcheck	4m 8s	The patch causes 16 errors with Hadoop v3.2.4.
-1 ❌	hadoopcheck	6m 28s	The patch causes 16 errors with Hadoop v3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 19s	hbase-it in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 17s	The patch does not generate ASF License warnings.
		22m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 61147aaa0341 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1bfc58a`
Default Java	Eclipse Adoptium-11.0.17+8
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/patch-compile-hbase-it.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/patch-compile-hbase-it.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/patch-javac-2.10.2.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/artifact/yetus-general-check/output/patch-spotbugs-hbase-it.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/8/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-02T15:04:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 3s	branch-2.5 passed
+1 💚	compile	0m 31s	branch-2.5 passed
+1 💚	shadedjars	3m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 1s	the patch passed
+1 💚	compile	0m 31s	the patch passed
+1 💚	javac	0m 31s	the patch passed
+1 💚	shadedjars	3m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 29s	hbase-client in the patch passed.
+1 💚	unit	0m 46s	hbase-it in the patch passed.
		19m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/9/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5d3124485213 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1bfc58a`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/9/testReport/
Max. process+thread count	774 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/9/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-02T15:07:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 41s	branch-2.5 passed
+1 💚	compile	0m 43s	branch-2.5 passed
+1 💚	shadedjars	3m 50s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 42s	the patch passed
+1 💚	javac	0m 42s	the patch passed
+1 💚	shadedjars	3m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 51s	hbase-client in the patch passed.
+1 💚	unit	0m 53s	hbase-it in the patch passed.
		21m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/9/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 74eb28bd79a9 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1bfc58a`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/9/testReport/
Max. process+thread count	805 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/9/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-12-02T15:13:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 33s	branch-2.5 passed
+1 💚	compile	1m 9s	branch-2.5 passed
+1 💚	checkstyle	0m 29s	branch-2.5 passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 12s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	1m 8s	the patch passed
+1 💚	javac	1m 8s	the patch passed
+1 💚	checkstyle	0m 28s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 22s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 28s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		28m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/9/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4889
JIRA Issue	HBASE-27498
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 0d5e31868838 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `1bfc58a`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	77 (vs. ulimit of 30000)
modules	C: hbase-client hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4889/9/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu

LGTM, thanks for making this change, please see if you can porting it to branch-2 as well

…erService to avoid expensive rpc calls in synchronized block (apache#4889) Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>

…erService to avoid expensive rpc calls in synchronized block (#4889) Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>

…erService to avoid expensive rpc calls in synchronized block (apache#4889) Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org> (cherry picked from commit ccd1d8a) Change-Id: I8305168b782f70d1fe7150fe3b1c22d7bbf01b7a

HBASE-27498-Added a logic to cache master state so that all threads d…

eb23af3

…on't need to make expensive rpc calls in synchronize block.

HBASE-27498-Fixed formatting errors using "mvn spotless:apply"

e3700d1

taklwu reviewed Nov 21, 2022

View reviewed changes

hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java Outdated Show resolved Hide resolved

vaijosh force-pushed the HBASE-27498 branch 2 times, most recently from 84749b0 to e3700d1 Compare November 25, 2022 06:03

HBASE-27498 : Implemented Review comments 1.Default master state cach…

f90f0f2

…e timeout is 0 i.e. legacy behavior. 2.Added integration test around new property

HBASE-27498 : Fixed Spotless formatting issue.

9b2ef31

HBASE-27498 : Fixed Spotless formatting issue.

be30d7c

HBASE-27498 : Fixed flaky test TestConnectionImplementation

467395e

vaijosh requested a review from taklwu December 2, 2022 13:39

HBASE-27498 : Minor changes to fix flaky test

fb56dba

taklwu approved these changes Dec 8, 2022

View reviewed changes

taklwu merged commit 748ec45 into apache:branch-2.5 Dec 8, 2022

taklwu pushed a commit that referenced this pull request Dec 9, 2022

HBASE-27498: Added logic in ConnectionImplementation.getKeepAliveMast…

ccd1d8a

…erService to avoid expensive rpc calls in synchronized block (#4889) Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27498: Added logic in ConnectionImplementation.getKeepAliveMasterService to avoid expensive rpc calls in synchronized block #4889

HBASE-27498: Added logic in ConnectionImplementation.getKeepAliveMasterService to avoid expensive rpc calls in synchronized block #4889

vaijosh commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

taklwu left a comment

bbeaudreault commented Nov 21, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

vaijosh commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

taklwu left a comment

HBASE-27498: Added logic in ConnectionImplementation.getKeepAliveMasterService to avoid expensive rpc calls in synchronized block #4889

HBASE-27498: Added logic in ConnectionImplementation.getKeepAliveMasterService to avoid expensive rpc calls in synchronized block #4889

Conversation

vaijosh commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

Apache-HBase commented Nov 19, 2022

taklwu left a comment

Choose a reason for hiding this comment

bbeaudreault commented Nov 21, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

vaijosh commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Nov 25, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

Apache-HBase commented Dec 2, 2022

taklwu left a comment

Choose a reason for hiding this comment