Skip to content

Commit

Permalink
HBASE-22715 All scan requests should be handled by scan handler threa…
Browse files Browse the repository at this point in the history
…ds in RWQueueRpcExecutor (#393)

Signed-off-by: Andrew Purtell <apurtell@apache.org>

Conflicts:
	hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
  • Loading branch information
Jeongdae Kim authored and apurtell committed Jul 24, 2019
1 parent 77c1267 commit c468aee
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,7 @@ private boolean isWriteRequest(final RequestHeader header, final Message param)
}

private boolean isScanRequest(final RequestHeader header, final Message param) {
if (param instanceof ScanRequest) {
// The first scan request will be executed as a "short read"
ScanRequest request = (ScanRequest)param;
return request.hasScannerId();
}
return false;
return param instanceof ScanRequest;
}

/*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ public void testScanQueues() throws Exception {

CallRunner scanCallTask = mock(CallRunner.class);
ServerCall scanCall = mock(ServerCall.class);
scanCall.param = ScanRequest.newBuilder().setScannerId(1).build();
scanCall.param = ScanRequest.newBuilder().build();
RequestHeader scanHead = RequestHeader.newBuilder().setMethodName("scan").build();
when(scanCallTask.getRpcCall()).thenReturn(scanCall);
when(scanCall.getHeader()).thenReturn(scanHead);
Expand Down

0 comments on commit c468aee

Please sign in to comment.