-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22715 Use scan queues/executors for scans, when RWQueueRpcExecutor used #393
Conversation
💔 -1 overall
This message was automatically generated. |
It seems that failed Tests below are not related to this patch. (and not reproduced in my local test)
@Apache9 Could you take a look at this PR? |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This needs to be committed master -> branch-2s -> branch-1 -> branch-1.4 so please don't merge directly.
💔 -1 overall
This message was automatically generated. |
Any further comments? |
…ds in RWQueueRpcExecutor (#393) Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
…ds in RWQueueRpcExecutor (#393) Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
…ds in RWQueueRpcExecutor (#393) Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
…ds in RWQueueRpcExecutor (#393) Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
…ds in RWQueueRpcExecutor (#393) Signed-off-by: Andrew Purtell <apurtell@apache.org>
…ds in RWQueueRpcExecutor (#393) Signed-off-by: Andrew Purtell <apurtell@apache.org>
…ds in RWQueueRpcExecutor (#393) Signed-off-by: Andrew Purtell <apurtell@apache.org>
…er threads in RWQueueRpcExecutor (#393)" This reverts commit 55bd5ec. Incorrect application to branch-1.3. HBASE-22715 is relevant only where HBASE-17508 was committed.
🎊 +1 overall
This message was automatically generated. |
…ds in RWQueueRpcExecutor (apache#393) Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java
…ds in RWQueueRpcExecutor (apache#393) Signed-off-by: Andrew Purtell <apurtell@apache.org> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestSimpleRpcScheduler.java (cherry picked from commit c468aee) Change-Id: Ia60512f2a58d8fdecaf04bd0390c59abd5c46333
No extra RPC only for opening a scanner anymore. So, we don't need to use read queue/handler when opening scanner.
More details in HBASE-22715