-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-28683 Only allow one TableProcedureInterface for a single table…
… to run at the same time for some special procedure types (#6046) (#6084) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 50a495f) (cherry picked from commit 855410f)
- Loading branch information
Showing
8 changed files
with
241 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
...er/src/main/java/org/apache/hadoop/hbase/master/procedure/TableProcedureWaitingQueue.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.master.procedure; | ||
|
|
||
| import java.util.ArrayDeque; | ||
| import java.util.Optional; | ||
| import java.util.Queue; | ||
| import java.util.function.Function; | ||
| import org.apache.hadoop.hbase.procedure2.Procedure; | ||
| import org.apache.yetus.audience.InterfaceAudience; | ||
|
|
||
| import org.apache.hbase.thirdparty.com.google.common.base.Preconditions; | ||
|
|
||
| /** | ||
| * To prevent multiple Create/Modify/Disable/Enable table procedures run at the same time, we will | ||
| * keep table procedure in this queue first before actually enqueuing it to | ||
| * MasterProcedureScheduler's tableQueue. See HBASE-28683 for more details | ||
| */ | ||
| @InterfaceAudience.Private | ||
| class TableProcedureWaitingQueue { | ||
|
|
||
| private final Function<Long, Procedure<?>> procedureRetriever; | ||
|
|
||
| // whether there is already a table procedure enqueued in ProcedureScheduler. | ||
| private Procedure<?> enqueuedProc; | ||
|
|
||
| private final Queue<Procedure<?>> queue = new ArrayDeque<>(); | ||
|
|
||
| TableProcedureWaitingQueue(Function<Long, Procedure<?>> procedureRetriever) { | ||
| this.procedureRetriever = procedureRetriever; | ||
| } | ||
|
|
||
| private boolean isSubProcedure(Procedure<?> proc) { | ||
| while (proc.hasParent()) { | ||
| if (proc.getParentProcId() == enqueuedProc.getProcId()) { | ||
| return true; | ||
| } | ||
| proc = Preconditions.checkNotNull(procedureRetriever.apply(proc.getParentProcId()), | ||
| "can not find parent procedure pid=%s", proc.getParentProcId()); | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * Return whether we can enqueue this procedure to ProcedureScheduler. | ||
| * <p> | ||
| * If returns {@code true}, you should enqueue this procedure, otherwise you just need to do | ||
| * nothing, as we will queue it in the waitingQueue, and you will finally get it again by calling | ||
| * {@link #procedureCompleted(Procedure)} method in the future. | ||
| */ | ||
| boolean procedureSubmitted(Procedure<?> proc) { | ||
| if (enqueuedProc == null) { | ||
| // no procedure enqueued yet, record it and return | ||
| enqueuedProc = proc; | ||
| return true; | ||
| } | ||
| if (proc == enqueuedProc) { | ||
| // the same procedure is enqueued again, this usually because the procedure comes back from | ||
| // WAITING state, such as all child procedures are finished | ||
| return true; | ||
| } | ||
| // check whether this is a sub procedure of the enqueued procedure | ||
| if (isSubProcedure(proc)) { | ||
| return true; | ||
| } | ||
| queue.add(proc); | ||
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * Return the next procedure which can be enqueued to ProcedureScheduler. | ||
| */ | ||
| Optional<Procedure<?>> procedureCompleted(Procedure<?> proc) { | ||
| Preconditions.checkState(enqueuedProc != null, "enqueued procedure should not be null"); | ||
| if (enqueuedProc == proc) { | ||
| if (!queue.isEmpty()) { | ||
| enqueuedProc = queue.poll(); | ||
| return Optional.of(enqueuedProc); | ||
| } else { | ||
| enqueuedProc = null; | ||
| return Optional.empty(); | ||
| } | ||
| } else { | ||
| Preconditions.checkState(isSubProcedure(proc), | ||
| "procedure %s is not a sub procedure of enqueued procedure %s", proc, enqueuedProc); | ||
| return Optional.empty(); | ||
| } | ||
| } | ||
|
|
||
| boolean isEmpty() { | ||
| return enqueuedProc == null; | ||
| } | ||
|
|
||
| int waitingSize() { | ||
| return queue.size(); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "TableProcedureWaitingQueue [enqueuedProc=" + enqueuedProc + ", queue=" + queue + "]"; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.