HBASE-28683 Only allow one TableProcedureInterface for a single table… #6046

Apache9 · 2024-07-04T15:46:00Z

… to run at the same time for some special procedure types

Apache9 · 2024-07-04T15:46:32Z

Let's see if it could pass all the UTs.

If so, let me see how to add some UTs for it.

Apache-HBase · 2024-07-04T16:25:48Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	3m 28s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 8s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s		master passed
+1 💚	compile	3m 18s		master passed
+1 💚	checkstyle	0m 49s		master passed
+1 💚	spotbugs	1m 53s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 47s		the patch passed
+1 💚	compile	3m 17s		the patch passed
+1 💚	javac	3m 17s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 39s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
+1 💚	spotbugs	2m 7s		the patch passed
+1 💚	hadoopcheck	5m 4s		Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 21s		The patch does not generate ASF License warnings.
		35m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 64b371397e84 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f9a413`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-04T16:53:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 55s		master passed
+1 💚	compile	1m 24s		master passed
+1 💚	javadoc	0m 42s		master passed
+1 💚	shadedjars	8m 13s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 21s		the patch passed
+1 💚	compile	1m 50s		the patch passed
+1 💚	javac	1m 50s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed
+1 💚	shadedjars	6m 38s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 39s		hbase-procedure in the patch passed.
-1 ❌	unit	29m 32s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		62m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 974ff2b3c308 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `7f9a413`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/1/testReport/
Max. process+thread count	1833 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-06T03:07:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 52s		master passed
+1 💚	compile	3m 16s		master passed
+1 💚	checkstyle	0m 47s		master passed
+1 💚	spotbugs	1m 54s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 50s		the patch passed
+1 💚	compile	3m 18s		the patch passed
+1 💚	javac	3m 18s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 38s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 4 new + 1 unchanged - 1 fixed = 5 total (was 2)
+1 💚	spotbugs	2m 8s		the patch passed
+1 💚	hadoopcheck	4m 59s		Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		32m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 1edc3171a1d9 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `047cf1b`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-06T03:13:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s		master passed
+1 💚	compile	1m 9s		master passed
+1 💚	javadoc	0m 38s		master passed
+1 💚	shadedjars	5m 45s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	1m 8s		the patch passed
+1 💚	javac	1m 8s		the patch passed
+1 💚	javadoc	0m 37s		the patch passed
+1 💚	shadedjars	5m 41s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 30s		hbase-procedure in the patch passed.
-1 ❌	unit	12m 35s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		38m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 4e980a5300c4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `047cf1b`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/2/testReport/
Max. process+thread count	1836 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-07T15:07:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 51s		master passed
+1 💚	compile	3m 17s		master passed
+1 💚	checkstyle	0m 49s		master passed
+1 💚	spotbugs	1m 53s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 46s		the patch passed
+1 💚	compile	3m 22s		the patch passed
+1 💚	javac	3m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 38s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 4 new + 1 unchanged - 1 fixed = 5 total (was 2)
+1 💚	spotbugs	2m 7s		the patch passed
+1 💚	hadoopcheck	4m 59s		Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		32m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 1e2d9d215490 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8e10c45`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	91 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-07T18:40:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 39s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s		master passed
+1 💚	compile	1m 9s		master passed
+1 💚	javadoc	0m 37s		master passed
+1 💚	shadedjars	5m 43s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 1s		the patch passed
+1 💚	compile	1m 10s		the patch passed
+1 💚	javac	1m 10s		the patch passed
+1 💚	javadoc	0m 37s		the patch passed
+1 💚	shadedjars	5m 42s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 27s		hbase-procedure in the patch passed.
-1 ❌	unit	213m 46s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		244m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 9a39adc2edf6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8e10c45`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/3/testReport/
Max. process+thread count	4628 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/3/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-08T09:48:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 47s		master passed
+1 💚	compile	3m 16s		master passed
+1 💚	checkstyle	0m 50s		master passed
+1 💚	spotbugs	1m 56s		master passed
+1 💚	spotless	0m 43s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 49s		the patch passed
+1 💚	compile	3m 16s		the patch passed
+1 💚	javac	3m 16s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 38s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 4 new + 1 unchanged - 2 fixed = 5 total (was 3)
+1 💚	spotbugs	2m 8s		the patch passed
-1 ❌	hadoopcheck	5m 40s		The patch causes 10 errors with Hadoop v3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		27m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux bfc8eb278b3a 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f7e8b51`
Default Java	Eclipse Adoptium-17.0.11+9
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/4/artifact/yetus-general-check/output/patch-javac-3.4.0.txt
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/4/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-08T13:19:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 20s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 56s		master passed
+1 💚	compile	1m 10s		master passed
+1 💚	javadoc	0m 37s		master passed
+1 💚	shadedjars	5m 42s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 58s		the patch passed
+1 💚	compile	1m 10s		the patch passed
+1 💚	javac	1m 10s		the patch passed
+1 💚	javadoc	0m 37s		the patch passed
+1 💚	shadedjars	5m 44s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 29s		hbase-procedure in the patch passed.
+1 💚	unit	211m 26s		hbase-server in the patch passed.
		239m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 5f4c965d7a0e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f7e8b51`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/4/testReport/
Max. process+thread count	5366 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/4/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-07-09T13:12:38Z

@virajjasani PTAL.

This is for addressing the problem for HBASE-28522, where we need to make sure that even if we release the exclusive lock after a step in DisableTableProcedure, no other table procedure can acquire the lock and cause trouble.

Thanks.

Apache9 · 2024-07-09T13:13:19Z

The failed hadoop 3.4.0 hadoop check will be fixed by HBASE-28714.

Apache-HBase · 2024-07-10T03:43:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 57s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 47s		master passed
+1 💚	compile	3m 52s		master passed
+1 💚	checkstyle	0m 51s		master passed
+1 💚	spotbugs	2m 11s		master passed
+1 💚	spotless	1m 8s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 28s		the patch passed
+1 💚	compile	5m 29s		the patch passed
+1 💚	javac	5m 29s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 3s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 4 new + 1 unchanged - 2 fixed = 5 total (was 3)
+1 💚	spotbugs	3m 24s		the patch passed
+1 💚	hadoopcheck	13m 33s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	1m 6s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 30s		The patch does not generate ASF License warnings.
		52m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 9e79d791bafe 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76c78d9`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-10T06:55:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 58s		master passed
+1 💚	compile	1m 23s		master passed
+1 💚	javadoc	0m 43s		master passed
+1 💚	shadedjars	6m 36s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 44s		the patch passed
+1 💚	compile	1m 20s		the patch passed
+1 💚	javac	1m 20s		the patch passed
+1 💚	javadoc	0m 43s		the patch passed
+1 💚	shadedjars	6m 12s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 38s		hbase-procedure in the patch passed.
+1 💚	unit	211m 56s		hbase-server in the patch passed.
		244m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 5beb6ea1797e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `76c78d9`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/5/testReport/
Max. process+thread count	5061 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-07-11T01:20:44Z

@virajjasani I think the patch is good to go, there are already plenty of tests to verify the concurrent execution of table related procedures.

Could you please take a look at this?

Thanks.

virajjasani · 2024-07-11T06:07:02Z

...erver/src/main/java/org/apache/hadoop/hbase/master/procedure/TableProcedureWaitingQueue.java

+ * MasterProcedureScheduler's tableQueue. See HBASE-28683 for more details
+ */
+@InterfaceAudience.Private
+class TableProcedureWaitingQueue {


Nice, this looks promising, let me take detailed look tomorrow

...-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java

...erver/src/main/java/org/apache/hadoop/hbase/master/procedure/TableProcedureWaitingQueue.java

… to run at the same time for some special procedure types

Apache9 · 2024-07-15T15:19:23Z

@virajjasani Any other concerns?

Thanks.

Apache-HBase · 2024-07-15T15:59:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 3s		master passed
+1 💚	compile	3m 22s		master passed
+1 💚	checkstyle	0m 51s		master passed
+1 💚	spotbugs	1m 55s		master passed
+1 💚	spotless	0m 46s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	3m 20s		the patch passed
+1 💚	javac	3m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 38s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 4 new + 1 unchanged - 2 fixed = 5 total (was 3)
+1 💚	spotbugs	2m 11s		the patch passed
+1 💚	hadoopcheck	10m 42s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 21s		The patch does not generate ASF License warnings.
		38m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux aca9087e8a0d 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3790b08`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/6/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-15T19:28:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 37s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 28s		master passed
+1 💚	compile	1m 12s		master passed
+1 💚	javadoc	0m 40s		master passed
+1 💚	shadedjars	5m 52s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	1m 11s		the patch passed
+1 💚	javac	1m 11s		the patch passed
+1 💚	javadoc	0m 38s		the patch passed
+1 💚	shadedjars	5m 49s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 31s		hbase-procedure in the patch passed.
-1 ❌	unit	218m 7s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		247m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux a21e083b0847 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3790b08`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/6/testReport/
Max. process+thread count	4701 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

Pending checkstyle fix, +1 otherwise

Apache9 · 2024-07-16T06:28:53Z

Pending checkstyle fix, +1 otherwise

Spotless just formats the code like this, I have no way to fix it...

Maybe we could try to update the checkstyle issue to eliminate the warnings...

virajjasani · 2024-07-16T06:59:56Z

Got it, no worries. It's upto you :)

Apache-HBase · 2024-07-16T07:08:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 55s		master passed
+1 💚	compile	3m 19s		master passed
+1 💚	checkstyle	0m 50s		master passed
+1 💚	spotbugs	1m 57s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 56s		the patch passed
+1 💚	compile	3m 19s		the patch passed
+1 💚	javac	3m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 39s	/results-checkstyle-hbase-server.txt	hbase-server: The patch generated 4 new + 1 unchanged - 2 fixed = 5 total (was 3)
+1 💚	spotbugs	2m 20s		the patch passed
+1 💚	hadoopcheck	10m 29s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 43s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 20s		The patch does not generate ASF License warnings.
		38m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 86f79796b842 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3790b08`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/7/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-07-16T10:34:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 49s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 23s		master passed
+1 💚	compile	1m 12s		master passed
+1 💚	javadoc	0m 38s		master passed
+1 💚	shadedjars	5m 52s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 2s		the patch passed
+1 💚	compile	1m 11s		the patch passed
+1 💚	javac	1m 11s		the patch passed
+1 💚	javadoc	0m 38s		the patch passed
+1 💚	shadedjars	5m 53s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	1m 31s		hbase-procedure in the patch passed.
+1 💚	unit	215m 46s		hbase-server in the patch passed.
		244m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6046
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux f4d29ec31f31 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3790b08`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/7/testReport/
Max. process+thread count	5528 (vs. ulimit of 30000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6046/7/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

… to run at the same time for some special procedure types (apache#6046) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 50a495f)

… to run at the same time for some special procedure types (#6046) (#6084) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 50a495f)

… to run at the same time for some special procedure types (#6046) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 50a495f) (cherry picked from commit 83fb64f)

… to run at the same time for some special procedure types (#6046) (#6084) Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 50a495f) (cherry picked from commit 855410f)

Apache9 self-assigned this Jul 4, 2024

Apache9 force-pushed the HBASE-28683 branch from 047cf1b to 8e10c45 Compare July 7, 2024 14:31

Apache9 force-pushed the HBASE-28683 branch from 8e10c45 to f7e8b51 Compare July 8, 2024 09:15

Apache9 requested a review from virajjasani July 9, 2024 13:11

Apache9 force-pushed the HBASE-28683 branch from f7e8b51 to 76c78d9 Compare July 10, 2024 02:37

virajjasani reviewed Jul 11, 2024

View reviewed changes

HBASE-28683 Only allow one TableProcedureInterface for a single table…

3790b08

… to run at the same time for some special procedure types

Apache9 force-pushed the HBASE-28683 branch from 76c78d9 to 3790b08 Compare July 15, 2024 15:15

virajjasani approved these changes Jul 15, 2024

View reviewed changes

Apache9 merged commit 50a495f into apache:master Jul 16, 2024
1 check passed

Apache9 mentioned this pull request Jul 16, 2024

HBASE-28683 Only allow one TableProcedureInterface for a single table… #6084

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28683 Only allow one TableProcedureInterface for a single table… #6046

HBASE-28683 Only allow one TableProcedureInterface for a single table… #6046

Apache9 commented Jul 4, 2024

Apache9 commented Jul 4, 2024

Apache-HBase commented Jul 4, 2024

Apache-HBase commented Jul 4, 2024

Apache-HBase commented Jul 6, 2024

Apache-HBase commented Jul 6, 2024

Apache-HBase commented Jul 7, 2024

Apache-HBase commented Jul 7, 2024

Apache-HBase commented Jul 8, 2024

Apache-HBase commented Jul 8, 2024

Apache9 commented Jul 9, 2024

Apache9 commented Jul 9, 2024

Apache-HBase commented Jul 10, 2024

Apache-HBase commented Jul 10, 2024

Apache9 commented Jul 11, 2024

virajjasani Jul 11, 2024

Apache9 commented Jul 15, 2024

Apache-HBase commented Jul 15, 2024

Apache-HBase commented Jul 15, 2024

virajjasani left a comment

Apache9 commented Jul 16, 2024

virajjasani commented Jul 16, 2024

Apache-HBase commented Jul 16, 2024

Apache-HBase commented Jul 16, 2024

HBASE-28683 Only allow one TableProcedureInterface for a single table… #6046

HBASE-28683 Only allow one TableProcedureInterface for a single table… #6046

Conversation

Apache9 commented Jul 4, 2024

Apache9 commented Jul 4, 2024

Apache-HBase commented Jul 4, 2024

Apache-HBase commented Jul 4, 2024

Apache-HBase commented Jul 6, 2024

Apache-HBase commented Jul 6, 2024

Apache-HBase commented Jul 7, 2024

Apache-HBase commented Jul 7, 2024

Apache-HBase commented Jul 8, 2024

Apache-HBase commented Jul 8, 2024

Apache9 commented Jul 9, 2024

Apache9 commented Jul 9, 2024

Apache-HBase commented Jul 10, 2024

Apache-HBase commented Jul 10, 2024

Apache9 commented Jul 11, 2024

virajjasani Jul 11, 2024

Choose a reason for hiding this comment

Apache9 commented Jul 15, 2024

Apache-HBase commented Jul 15, 2024

Apache-HBase commented Jul 15, 2024

virajjasani left a comment

Choose a reason for hiding this comment

Apache9 commented Jul 16, 2024

virajjasani commented Jul 16, 2024

Apache-HBase commented Jul 16, 2024

Apache-HBase commented Jul 16, 2024