HBASE-23664 Upgrade JUnit to 4.13 #1010

ndimiduk · 2020-01-09T17:23:38Z

Backport of #1004 to branch-1.

saintstack

Doesn't seem to be a junit5 issue open. Follow-up?

ndimiduk · 2020-01-09T19:39:14Z

Doesn't seem to be a junit5 issue open. Follow-up?

https://issues.apache.org/jira/browse/HBASE-23671

Apache-HBase · 2020-01-09T21:29:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	8m 22s	branch-1 passed
+1 💚	compile	1m 48s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	1m 57s	branch-1 passed with JDK v1.7.0_242
+1 💚	shadedjars	3m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 13s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	4m 5s	branch-1 passed with JDK v1.7.0_242
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	1m 48s	the patch passed with JDK v1.8.0_232
+1 💚	javac	1m 48s	the patch passed
+1 💚	compile	1m 56s	the patch passed with JDK v1.7.0_242
+1 💚	javac	1m 56s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	xml	0m 0s	The patch has 1 ill-formed XML file(s).
+1 💚	shadedjars	3m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 11s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	2m 5s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	4m 7s	the patch passed with JDK v1.7.0_242
		_ Other Tests _
-1 ❌	unit	186m 22s	root in the patch failed.
+1 💚	asflicense	0m 34s	The patch does not generate ASF License warnings.
		238m 52s

Reason	Tests
XML	Parsing Error(s):
	pom.xml
Failed junit tests	hadoop.hbase.client.TestSnapshotTemporaryDirectory
	hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
	hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.client.replication.TestReplicationAdminWithClusters
	hadoop.hbase.client.TestAdmin1
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.regionserver.TestCompactionState
	hadoop.hbase.client.TestAdmin2

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/artifact/out/Dockerfile
GITHUB PR	#1010
Optional Tests	dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname	Linux 4e1a2e21534f 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1010/out/precommit/personality/provided.sh
git revision	branch-1 / `6b940ae`
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
xml	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/artifact/out/xml.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/artifact/out/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/testReport/
Max. process+thread count	3896 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/1/console
versions	git=1.9.1 maven=3.0.5
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2020-01-10T15:23:44Z

That's a lot of failures. Kicking the PR job to try again.

Apache-HBase · 2020-01-10T18:42:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	7m 11s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ branch-1 Compile Tests _
+1 💚	mvninstall	8m 43s	branch-1 passed
+1 💚	compile	1m 42s	branch-1 passed with JDK v1.8.0_232
+1 💚	compile	1m 49s	branch-1 passed with JDK v1.7.0_242
+1 💚	shadedjars	2m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 13s	branch-1 passed with JDK v1.8.0_232
+1 💚	javadoc	3m 46s	branch-1 passed with JDK v1.7.0_242
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 1s	the patch passed
+1 💚	compile	1m 42s	the patch passed with JDK v1.8.0_232
+1 💚	javac	1m 42s	the patch passed
+1 💚	compile	1m 45s	the patch passed with JDK v1.7.0_242
+1 💚	javac	1m 45s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	xml	0m 1s	The patch has 1 ill-formed XML file(s).
+1 💚	shadedjars	2m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	5m 0s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	javadoc	2m 7s	the patch passed with JDK v1.8.0_232
+1 💚	javadoc	3m 48s	the patch passed with JDK v1.7.0_242
		_ Other Tests _
-1 ❌	unit	147m 38s	root in the patch failed.
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		198m 52s

Reason	Tests
XML	Parsing Error(s):
	pom.xml
Failed junit tests	hadoop.hbase.client.TestAdmin2
	hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
	hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
	hadoop.hbase.regionserver.TestCompactionState
	hadoop.hbase.security.token.TestGenerateDelegationToken

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/artifact/out/Dockerfile
GITHUB PR	#1010
Optional Tests	dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile
uname	Linux 84529f3a5ea7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1010/out/precommit/personality/provided.sh
git revision	branch-1 / `6b940ae`
Default Java	1.7.0_242
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242
xml	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/artifact/out/xml.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/artifact/out/patch-unit-root.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/testReport/
Max. process+thread count	4560 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1010/2/console
versions	git=1.9.1 maven=3.0.5
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

This reverts commit 248d80b.

HBASE-23664 Upgrade JUnit to 4.13

d6a3395

saintstack approved these changes Jan 9, 2020

View reviewed changes

ndimiduk merged commit 248d80b into apache:branch-1 Jan 10, 2020

ndimiduk deleted the 23664-junit-4.13-branch-1 branch January 10, 2020 21:24

JeongDaeKim mentioned this pull request Jan 13, 2020

HBASE-23254 Release replication buffer quota correctly, when batch includes bulk loaded hfiles #792

Merged

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 13, 2020

Revert "HBASE-23664 Upgrade JUnit to 4.13 (apache#1010)"

b753cd2

This reverts commit 248d80b.

ndimiduk added a commit that referenced this pull request Jan 13, 2020

Revert "HBASE-23664 Upgrade JUnit to 4.13 (#1010)" (#1031)

b5d0da7

This reverts commit 248d80b.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23664 Upgrade JUnit to 4.13 #1010

HBASE-23664 Upgrade JUnit to 4.13 #1010

ndimiduk commented Jan 9, 2020

saintstack left a comment

ndimiduk commented Jan 9, 2020

Apache-HBase commented Jan 9, 2020

ndimiduk commented Jan 10, 2020

Apache-HBase commented Jan 10, 2020

HBASE-23664 Upgrade JUnit to 4.13 #1010

HBASE-23664 Upgrade JUnit to 4.13 #1010

Conversation

ndimiduk commented Jan 9, 2020

saintstack left a comment

Choose a reason for hiding this comment

ndimiduk commented Jan 9, 2020

Apache-HBase commented Jan 9, 2020

ndimiduk commented Jan 10, 2020

Apache-HBase commented Jan 10, 2020