Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24148: Upgrade Thrift to 0.13.0 #1462

Closed
wants to merge 1 commit into from
Closed

HBASE-24148: Upgrade Thrift to 0.13.0 #1462

wants to merge 1 commit into from

Conversation

tamaashu
Copy link
Contributor

@tamaashu tamaashu commented Apr 8, 2020

Upgrade thrift, adopt Java code where needed.

Change-Id: I8d78f6bd04ed3c7787b8f9beaf370dfdac9574cb

@tamaashu
HBASE-24148: Upgrade Thrift to 0.13.0
6b56c8a 
Upgrade thrift, adopt Java code where needed.

Change-Id: I8d78f6bd04ed3c7787b8f9beaf370dfdac9574cb
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 44s Maven dependency ordering for branch
-1 ❌ mvninstall 4m 16s root in master failed.
-0 ⚠️ checkstyle 2m 2s The patch fails to run checkstyle in root
-1 ❌ spotbugs 7m 4s root in master failed.
-1 ❌ spotbugs 0m 21s hbase-mapreduce in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 5m 1s the patch passed
-0 ⚠️ checkstyle 2m 19s root: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 10m 22s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 13m 4s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
55m 8s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1462
JIRA Issue HBASE-24148
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml
uname Linux 51ee3e438b13 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb7df04
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-general-check/output//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1462@2/yetus-general-check/output/maven-branch-checkstyle-root.txt
spotbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-general-check/output/branch-spotbugs-root.txt
spotbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-mapreduce.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
Max. process+thread count 93 (vs. ulimit of 10000)
modules C: hbase-mapreduce hbase-thrift . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 43s Maven dependency ordering for branch
-1 ❌ mvninstall 4m 18s root in master failed.
-1 ❌ compile 1m 48s root in master failed.
-1 ❌ shadedjars 3m 55s branch has 16 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 1m 57s root in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 5m 6s the patch passed
+1 💚 compile 2m 51s the patch passed
+1 💚 javac 2m 51s root generated 0 new + 34 unchanged - 4 fixed = 34 total (was 38)
+1 💚 shadedjars 4m 28s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 2m 36s root generated 72 new + 15 unchanged - 0 fixed = 87 total (was 15)
_ Other Tests _
+1 💚 unit 163m 21s root in the patch passed.
196m 18s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1462
JIRA Issue HBASE-24148
Optional Tests javac javadoc unit shadedjars compile
uname Linux a7e449387982 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb7df04
Default Java 1.8.0_232
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk8-hadoop2-check/output/branch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk8-hadoop2-check/output/branch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/testReport/
Max. process+thread count 4446 (vs. ulimit of 10000)
modules C: hbase-mapreduce hbase-thrift . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 9s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 39s Maven dependency ordering for branch
-1 ❌ mvninstall 5m 42s root in master failed.
-1 ❌ compile 2m 36s root in master failed.
-1 ❌ shadedjars 4m 59s branch has 16 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s root in master failed.
-0 ⚠️ javadoc 0m 18s hbase-mapreduce in master failed.
-0 ⚠️ javadoc 0m 56s hbase-thrift in master failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 6m 47s the patch passed
+1 💚 compile 4m 0s the patch passed
+1 💚 javac 4m 0s root generated 0 new + 34 unchanged - 4 fixed = 34 total (was 38)
+1 💚 shadedjars 5m 42s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 19s hbase-mapreduce in the patch failed.
-0 ⚠️ javadoc 0m 56s hbase-thrift in the patch failed.
-0 ⚠️ javadoc 0m 18s root in the patch failed.
_ Other Tests _
+1 💚 unit 247m 43s root in the patch passed.
285m 10s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1462
JIRA Issue HBASE-24148
Optional Tests javac javadoc unit shadedjars compile
uname Linux ebb093013a07 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / eb7df04
Default Java 2020-01-14
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-root.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-mapreduce.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/testReport/
Max. process+thread count 3383 (vs. ulimit of 10000)
modules C: hbase-mapreduce hbase-thrift . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1462/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani reviewed Apr 9, 2020
View reviewed changes
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshotAdjunct.java
@@ -119,8 +119,7 @@ public void testExportRetry() throws Exception {
conf.setBoolean(ExportSnapshot.Testing.CONF_TEST_FAILURE, true);
conf.setInt(ExportSnapshot.Testing.CONF_TEST_FAILURE_COUNT, 2);
conf.setInt("mapreduce.map.maxattempts", 3);
TestExportSnapshot.testExportFileSystemState(conf, tableName,
Bytes.toBytes(snapshotName), Bytes.toBytes(snapshotName),
TestExportSnapshot.testExportFileSystemState(conf, tableName, snapshotName, snapshotName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts, this one is taken care of.
Thanks

saintstack
saintstack reviewed Apr 10, 2020
View reviewed changes
pom.xml
@@ -1529,7 +1529,7 @@
<external.protobuf.version>2.5.0</external.protobuf.version>
<protobuf.plugin.version>0.6.1</protobuf.plugin.version>
<thrift.path>thrift</thrift.path>
<thrift.version>0.12.0</thrift.version>
<thrift.version>0.13.0</thrift.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the guarantees regards thrift 0.13 talking to a 0.12 server and vice-versa? Needs callout in the release notes on this JIRA at least.

Otherwise patch is good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, do you have to regenerate the thrift files with this update? Will that happen as part of the build? (I forgot how this works)

@saintstack
Copy link
Contributor

saintstack commented Apr 15, 2020 •
edited
Loading

Closing. Wrapped @tamaashu 's patch into a fatter one in a new PR that includes regeneration of java files from thrift IDLs. See #1519

@saintstack saintstack closed this Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani left review comments

@saintstack saintstack saintstack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tamaashu @Apache-HBase @saintstack @virajjasani