HBASE-22700 (addendum): Clarify ZK session timeout doc #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I stumbled up on this because a colleague of mine got confused with the wording. I think its good to clarify this. I created an addendum commit since the change is minor and very much relevant to the original jira created for this purpose. Let me know if anyone thinks I should create a separate jira for this. |
|
🎊 +1 overall
This message was automatically generated. |
HorizonNet
reviewed
May 20, 2020
apurtell
requested changes
May 20, 2020
| @@ -1142,7 +1142,10 @@ Disable Nagle’s algorithm. Delayed ACKs can add up to ~200ms to RPC round trip | |||
| Detect regionserver failure as fast as reasonable. Set the following parameters: | |||
|
|
|||
| * In `hbase-site.xml`, set `zookeeper.session.timeout` to 30 seconds or less to bound failure detection (20-30 seconds is a good start). | |||
| - Notice: the `sessionTimeout` of zookeeper is limited between 2 times and 20 times the `tickTime`(the basic time unit in milliseconds used by ZooKeeper.the default value is 2000ms.It is used to do heartbeats and the minimum session timeout will be twice the tickTime). | |||
| - Note: Zookeeper clients negotiate a session timeout with the server during client init. Server enforces this timeout to be in the | |||
| range of 2 times `tickTime` and 20 times `tickTime` unless `minSessionTimeout` and `maxSessionTimeout` are configured in the Zookeeper | |||
There was a problem hiding this comment.
You should also explain what minSessionTimeout and maxSessionTimeout offer in alternative.
There was a problem hiding this comment.
Reworded it slightly, LMKWYT.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
HorizonNet
approved these changes
May 20, 2020
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
apurtell
requested changes
May 26, 2020
| @@ -1142,7 +1142,11 @@ Disable Nagle’s algorithm. Delayed ACKs can add up to ~200ms to RPC round trip | |||
| Detect regionserver failure as fast as reasonable. Set the following parameters: | |||
|
|
|||
| * In `hbase-site.xml`, set `zookeeper.session.timeout` to 30 seconds or less to bound failure detection (20-30 seconds is a good start). | |||
| - Notice: the `sessionTimeout` of zookeeper is limited between 2 times and 20 times the `tickTime`(the basic time unit in milliseconds used by ZooKeeper.the default value is 2000ms.It is used to do heartbeats and the minimum session timeout will be twice the tickTime). | |||
| - Note: Zookeeper clients negotiate a session timeout with the server during client init. Server enforces this timeout to be in the | |||
| range [`minSessionTimeout`, `maxSessionTimeout`] and both these timeouts are configurable in Zookeeper service configuration. | |||
There was a problem hiding this comment.
What are these? Milliseconds? We have to assume it otherwise, so why not mention it?
There was a problem hiding this comment.
Added the time unit.
The current wording gives an impression the session timeout range on the ZK side is forced to be in the range [2 * tickTime, 20 * tickTime]. This range is configurable on the ZK service side using minSessionTimeout and maxSessionTimeout. Clarified that.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
apurtell
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current wording gives an impression the session timeout range
on the ZK side is forced to be in the range [2 * tickTime, 20 * tickTime].
This range is configurable on the ZK service side using minSessionTimeout
and maxSessionTimeout. Clarified that.