HBASE-24752 NPE/500 accessing webui on master startup #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
reviewed
Jul 27, 2020
| @@ -224,6 +225,11 @@ AssignmentManager assignmentManager = master.getAssignmentManager(); | |||
| <& AssignmentManagerStatusTmpl; assignmentManager=master.getAssignmentManager()&> | |||
| </%if> | |||
| <%if !master.isInMaintenanceMode() %> | |||
| <%java> | |||
| while (master.getMasterCoprocessorHost() == null) { | |||
| Threads.sleep(50); | |||
There was a problem hiding this comment.
Let's also print some message which we can removed after getting out of this while loop?
There was a problem hiding this comment.
I researched it and it seems I can’t
There was a problem hiding this comment.
Would the whole page not load (display) when master.getMasterCoprocessorHost() == null ?
There was a problem hiding this comment.
Good question, the only concern is what will the page display when master.getMasterCoprocessorHost() is null?
Is this situation reproable by any chance? If not, it's fine, this fix looks good anyways.
There was a problem hiding this comment.
As of commit 82d0990 in master branch, I don't see the master.getMasterCoprocessorHost().findCoprocessor() call below.
One option is to find the commit which removed master.getMasterCoprocessorHost().findCoprocessor() call.
Another option is to use code similar to existing one:
<td><% master.getMasterCoprocessorHost() == null ? "[]" :
java.util.Arrays.toString(master.getMasterCoprocessors()) %></td>
There was a problem hiding this comment.
my negligence, there are some similar problems and solutions in front
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
tedyu
reviewed
Jul 28, 2020
| @@ -223,7 +223,7 @@ AssignmentManager assignmentManager = master.getAssignmentManager(); | |||
| <%if master.getAssignmentManager() != null %> | |||
| <& AssignmentManagerStatusTmpl; assignmentManager=master.getAssignmentManager()&> | |||
| </%if> | |||
| <%if !master.isInMaintenanceMode() %> | |||
| <%if !master.isInMaintenanceMode() && master.getMasterCoprocessorHost() != null %> | |||
There was a problem hiding this comment.
lgtm
nit: double space between && and 'master'
There was a problem hiding this comment.
thanks for reminding
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
+1 |
|
Pending QA of latest build. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
virajjasani
pushed a commit
that referenced
this pull request
Jul 29, 2020
Closes #2148 Signed-off-by: Ted Yu <yuzhihong@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
Jul 29, 2020
Closes #2148 Signed-off-by: Ted Yu <yuzhihong@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani
pushed a commit
that referenced
this pull request
Jul 29, 2020
Closes #2148 Signed-off-by: Ted Yu <yuzhihong@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
Closes apache#2148 Signed-off-by: Ted Yu <yuzhihong@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
May 24, 2021
Closes apache#2148 Signed-off-by: Ted Yu <yuzhihong@gmail.com> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit 6fba086) Change-Id: I95ae9e133877ed30adcb923b6fb3780136171bfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.