HBASE-25002 Create simple pattern matching query for retrieving metri… #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs matching the pattern
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Sep 10, 2020
anoopsjohn
reviewed
Sep 10, 2020
| @@ -125,11 +130,13 @@ public int write(MBeanServer mBeanServer, ObjectName qry, String attribute, | |||
| */ | |||
| private static int write(JsonWriter writer, MBeanServer mBeanServer, ObjectName qry, | |||
| String attribute, boolean description) throws IOException { | |||
| LOG.trace("Listing beans for " + qry); | |||
| LOG.debug("Listing beans for " + qry); | |||
There was a problem hiding this comment.
Wanted this log level change?
There was a problem hiding this comment.
I changed it so that later we can debug it to know what is the query. Generally setting debug level is what we do for debugging so I just changed it. I can revert it if needed.
There was a problem hiding this comment.
Ok to change. Can u also change to use {} format log line. Anyways that will be nice to have
| Set<ObjectName> names = null; | ||
| names = mBeanServer.queryNames(qry, null); | ||
| writer.name("beans").beginArray(); | ||
| Iterator<ObjectName> it = names.iterator(); | ||
| boolean pattern = false; |
There was a problem hiding this comment.
You can avoid this boolean. Just use String[] and check for null value and call diff write methods?
| if (pattern != null) { | ||
| boolean matchFound = false; | ||
| for (String patt : pattern) { | ||
| Pattern compile = Pattern.compile(patt); |
There was a problem hiding this comment.
We are compiling this pattern for each and every MBean attribute. This will be costly. we could have compiled the attribute and kept that in an Array at 1st step itself (instead of keeping the regex patterns in String[])
There was a problem hiding this comment.
Ya ok . I did not do it thinking we are not doing this thing much often. May be once a while. I can change it though.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
anoopsjohn
approved these changes
Sep 10, 2020
| @@ -125,11 +130,13 @@ public int write(MBeanServer mBeanServer, ObjectName qry, String attribute, | |||
| */ | |||
| private static int write(JsonWriter writer, MBeanServer mBeanServer, ObjectName qry, | |||
| String attribute, boolean description) throws IOException { | |||
| LOG.trace("Listing beans for " + qry); | |||
| LOG.debug("Listing beans for " + qry); | |||
There was a problem hiding this comment.
Ok to change. Can u also change to use {} format log line. Anyways that will be nice to have
| @@ -216,7 +239,12 @@ private static int write(JsonWriter writer, MBeanServer mBeanServer, ObjectName | |||
| } else { | |||
| MBeanAttributeInfo[] attrs = minfo.getAttributes(); | |||
| for (int i = 0; i < attrs.length; i++) { | |||
| writeAttribute(writer, mBeanServer, oname, description, attrs[i]); | |||
| if (matchingPattern != null) { | |||
There was a problem hiding this comment.
Infact u can see we dont need such if else, end of the day we call same writeAttribute which is having Pattern[] arg and we have null check there anyways.
| @@ -225,8 +253,14 @@ private static int write(JsonWriter writer, MBeanServer mBeanServer, ObjectName | |||
| return 0; | |||
| } | |||
|
|
|||
| private static void writeAttribute(final JsonWriter jg, final MBeanServer mBeanServer, | |||
There was a problem hiding this comment.
Ya even this also not needed.
|
|
||
| if (pattern != null) { | ||
| boolean matchFound = false; | ||
| for (Pattern compile : pattern) { |
There was a problem hiding this comment.
Call its pattern : patterns?
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thanks for the reviews @saintstack and @anoopsjohn . |
ramkrish86
added a commit
to ramkrish86/hbase
that referenced
this pull request
Sep 14, 2020
apache#2370) * HBASE-25002 Create simple pattern matching query for retrieving metrics matching the pattern * Address review comments * Final set of comments addressed * Address checkstyle comments
ramkrish86
added a commit
that referenced
this pull request
Sep 14, 2020
#2370) (#2398) * HBASE-25002 Create simple pattern matching query for retrieving metrics matching the pattern * Address review comments * Final set of comments addressed * Address checkstyle comments
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
apache#2370) (apache#2398) * HBASE-25002 Create simple pattern matching query for retrieving metrics matching the pattern * Address review comments * Final set of comments addressed * Address checkstyle comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports a pattern for getting a JMX metrics. This is helpful when we have multiple metrics under a the Tables category, then fetching the entire metric under Tables may be very big. So this helps to fetch a certain pattern of metrics alone and returns them as JSON.
The format is
http://../jmx?get=Hadoop:service=HBase,name=RegionServer,sub=Tables::[a-zA-z_0-9]*memStoreSize,[a-zA-z_0-9]*storeFileSize