Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-25048 [HBCK2] Bypassed parent procedures are not updated in store #2410

Merged
merged 1 commit into from
Oct 5, 2020
Merged

HBASE-25048 [HBCK2] Bypassed parent procedures are not updated in store #2410

merged 1 commit into from
Oct 5, 2020

Conversation

ArthurSXL8
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 21s master passed
+1 💚 compile 0m 22s master passed
+1 💚 shadedjars 6m 37s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 21s hbase-procedure in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 shadedjars 6m 37s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s hbase-procedure in the patch failed.
_ Other Tests _
+1 💚 unit 1m 38s hbase-procedure in the patch passed.
26m 16s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2410
Optional Tests javac javadoc unit shadedjars compile
uname Linux 292724f89e18 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1bb19e0
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/testReport/
Max. process+thread count 293 (vs. ulimit of 12500)
modules C: hbase-procedure U: hbase-procedure
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 53s master passed
+1 💚 compile 0m 22s master passed
+1 💚 shadedjars 7m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 18s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 13s the patch passed
+1 💚 compile 0m 20s the patch passed
+1 💚 javac 0m 20s the patch passed
+1 💚 shadedjars 7m 18s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 18s the patch passed
_ Other Tests _
+1 💚 unit 1m 59s hbase-procedure in the patch passed.
28m 51s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2410
Optional Tests javac javadoc unit shadedjars compile
uname Linux 44ad4ecbf8be 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1bb19e0
Default Java 1.8.0_232
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/testReport/
Max. process+thread count 373 (vs. ulimit of 12500)
modules C: hbase-procedure U: hbase-procedure
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 4m 18s master passed
+1 💚 checkstyle 0m 16s master passed
+1 💚 spotbugs 0m 42s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 21s the patch passed
+1 💚 checkstyle 0m 16s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 40s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚 spotbugs 0m 45s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
32m 55s
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2410
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux 355250e08f14 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 1bb19e0
Max. process+thread count 94 (vs. ulimit of 12500)
modules C: hbase-procedure U: hbase-procedure
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2410/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this manifests? On restart the procedure shows up as alive again?

Fix looks good though.

@ArthurSXL8
Copy link
Contributor Author

I wonder how this manifests? On restart the procedure shows up as alive again?

Fix looks good though.

I asked Mei, the reporter of this jira, and she found it when reading code about HBCK. Let me add a UT to reproduce it.

@infraio infraio added the bug label Sep 27, 2020
@saintstack
Copy link
Contributor

@Joseph295 any progress on this nice fix?

@ArthurSXL8
Copy link
Contributor Author

@Joseph295 any progress on this nice fix?

I am trying to add ut, tried several times, but didn't succeed. on holiday now, will continue after holiday.

@saintstack
Copy link
Contributor

Its ok @Joseph295 The fix is 'obviously' correct. If hard adding test, that is ok. Enjoy your holday. Let me merge this.

@saintstack saintstack merged commit a8096b3 into apache:master Oct 5, 2020
saintstack pushed a commit that referenced this pull request Oct 5, 2020
@ArthurSXL8 @saintstack
HBASE-25048 [HBCK2] Bypassed parent procedures are not updated in sto…
a04baf5 
…re (#2410)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
saintstack pushed a commit that referenced this pull request Oct 5, 2020
@ArthurSXL8 @saintstack
HBASE-25048 [HBCK2] Bypassed parent procedures are not updated in sto…
0a3b6f4 
…re (#2410)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
petersomogyi pushed a commit that referenced this pull request Oct 5, 2020
@ArthurSXL8 @petersomogyi
HBASE-25048 [HBCK2] Bypassed parent procedures are not updated in sto…
3fedb7c 
…re (#2410)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@ArthurSXL8 @clarax
HBASE-25048 [HBCK2] Bypassed parent procedures are not updated in sto…
2f8f84b 
…re (apache#2410)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@ArthurSXL8 @petersomogyi
HBASE-25048 [HBCK2] Bypassed parent procedures are not updated in sto…
fbee97b 
…re (apache#2410)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: stack <stack@apache.org>
(cherry picked from commit 3fedb7c)

Change-Id: Ia8d7071a309376b6b0efe5a9ab11f099d0bf31c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

@saintstack saintstack saintstack approved these changes

Assignees

@ArthurSXL8 ArthurSXL8

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArthurSXL8 @Apache-HBase @saintstack @Apache9 @infraio