Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-23959 Fix javadoc for JDK11 #2500

Merged
merged 1 commit into from
Oct 8, 2020
Merged

HBASE-23959 Fix javadoc for JDK11 #2500

merged 1 commit into from
Oct 8, 2020

Conversation

semensanyok
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 11m 37s Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
_ Other Tests _
+1 💚 asflicense 0m 18s The patch does not generate ASF License warnings.
20m 23s
Subsystem Report/Notes
Docker Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2500
Optional Tests dupname asflicense hadoopcheck xml
uname Linux ed7839a4380d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a8096b3
Max. process+thread count 76 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 23s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 15s master passed
+1 💚 compile 2m 47s master passed
+1 💚 shadedjars 6m 39s branch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 18s root in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 57s the patch passed
+1 💚 compile 2m 46s the patch passed
+1 💚 javac 2m 46s the patch passed
+1 💚 shadedjars 6m 35s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 2m 43s root generated 175 new + 0 unchanged - 0 fixed = 175 total (was 0)
_ Other Tests _
-1 ❌ unit 11m 54s root in the patch failed.
44m 55s
Subsystem Report/Notes
Docker Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2500
Optional Tests javac javadoc unit shadedjars compile
uname Linux 028ec930eae4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a8096b3
Default Java 2020-01-14
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-root.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/testReport/
Max. process+thread count 775 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 13s master passed
+1 💚 compile 3m 11s master passed
+1 💚 shadedjars 7m 47s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 36s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 6s the patch passed
+1 💚 compile 2m 43s the patch passed
+1 💚 javac 2m 43s the patch passed
+1 💚 shadedjars 7m 46s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 24s the patch passed
_ Other Tests _
-1 ❌ unit 270m 14s root in the patch failed.
308m 44s
Subsystem Report/Notes
Docker Client=19.03.13 Server=19.03.13 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2500
Optional Tests javac javadoc unit shadedjars compile
uname Linux 442f48702f42 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a8096b3
Default Java 1.8.0_232
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/testReport/
Max. process+thread count 3638 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2500/1/console
versions git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@HorizonNet HorizonNet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Issue seems to be resolved according to build logs. Build failure seems to be unrelated.

@ndimiduk Can you please also take a look at it?

@HorizonNet HorizonNet requested a review from ndimiduk October 5, 2020 22:46
@saintstack saintstack merged commit 2fc79e2 into apache:master Oct 8, 2020
saintstack
saintstack approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally. javadoc compile works w/ this in place.

saintstack pushed a commit that referenced this pull request Oct 8, 2020
@semensanyok @saintstack
HBASE-23959 Fix javadoc for JDK11 (#2500)
ee5988a 
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: stack <stack@apache.org>
clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020
@semensanyok @clarax
HBASE-23959 Fix javadoc for JDK11 (apache#2500)
8c3718b 
Signed-off-by: Jan Hentschel <jan.hentschel@ultratendency.com>
Signed-off-by: stack <stack@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorizonNet HorizonNet HorizonNet approved these changes

@saintstack saintstack saintstack approved these changes

@ndimiduk ndimiduk Awaiting requested review from ndimiduk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semensanyok @Apache-HBase @saintstack @HorizonNet