HBASE-22509 Address findbugs/spotbugs complaints (branch-1.4) #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurtell
commented
May 31, 2019
| @@ -7963,7 +7963,9 @@ public Result append(Append mutate, long nonceGroup, long nonce) throws IOExcept | |||
| for (Map.Entry<Store, List<Cell>> entry: removedCellsForMemStore.entrySet()) { | |||
| entry.getKey().add(entry.getValue()); | |||
| } | |||
| if (we != null) mvcc.complete(we); | |||
| if (we != null) { | |||
There was a problem hiding this comment.
Changes to this file are a carrying forward of formatting changes from the branch-1.3 changes proposed on HBASE-22508 (#275). They don't address a findbugs issue, only try to keep the code as consistent as possible between branches.
|
💔 -1 overall
This message was automatically generated. |
|
The precommit results looks environmental in nature. Failures begin with ZK session timeouts. This patch is almost identical to the 1.3 and branch-1 patches, both of which had good precommit results. I' still waiting for a valid result on the JIRA (https://issues.apache.org/jira/browse/HBASE-22509). Let me recommit and force push to trigger another run here. |
apurtell
force-pushed
the
HBASE-22509-branch-1.4
branch
from
e9670d7 to
a6dadec
Compare
|
💔 -1 overall
This message was automatically generated. |
|
QA result over on JIRA: https://issues.apache.org/jira/browse/HBASE-22509?focusedCommentId=16853428&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16853428 hadoopcheck failures are due to another change that introduced test code that twiddles with log levels. Let me follow up separately on that. Unit test failure here is unrelated to patch: The reported checkstyle issues are javadoc nits which are not introduced by this change. |
|
those hadoop check versions look wrong. branch-1.4 isn't expected to work with Hadoop < 2.7. Looks like the personality is treating it like branch-1.2 and branch-1.3. |
busbey
approved these changes
Jun 1, 2019
Signed-off-by: Sean Busbey <busbey@apache.org>
apurtell
force-pushed
the
HBASE-22509-branch-1.4
branch
from
a6dadec to
21ab426
Compare
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.