HBASE-25445: Use WAL FS instead of master FS in SplitWALManager #2844

dasanjan1296 · 2021-01-05T05:01:54Z

If 'hbase.wal.dir' and 'hbase.rootdir' are configured to different filesystem instances, SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using wrong fs instance. SplitWALManager should use WAL corresponding fs instance.

pankaj72981

+1

ramkrish86

Any test case to capture this regression? Else LGTM.

dasanjan1296 · 2021-01-05T05:27:35Z

@ramkrish86 I have added some testing details in the corresponding JIRA for reproducing the error.

Apache-HBase · 2021-01-05T05:37:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 18s	master passed
+1 💚	compile	1m 6s	master passed
+1 💚	shadedjars	6m 42s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 45s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 6s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	6m 43s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
-1 ❌	unit	7m 7s	hbase-server in the patch failed.
		34m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 12cca84bd54a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `600be60`
Default Java	AdoptOpenJDK-11.0.6+10
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/testReport/
Max. process+thread count	726 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-05T05:51:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	7m 13s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 14s	master passed
+1 💚	checkstyle	1m 11s	master passed
+1 💚	spotbugs	2m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 56s	the patch passed
+1 💚	checkstyle	1m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 5s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		49m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux e6622e37ddf6 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `600be60`
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1, pending QA

Apache-HBase · 2021-01-05T08:10:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 48s	master passed
+1 💚	checkstyle	1m 6s	master passed
+1 💚	spotbugs	2m 3s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 29s	the patch passed
+1 💚	checkstyle	1m 3s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 18s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 10s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		39m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 52dc52e1b1cb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `600be60`
Max. process+thread count	94 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-05T10:10:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 23s	master passed
+1 💚	compile	1m 5s	master passed
+1 💚	shadedjars	6m 41s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 6s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	6m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
+1 💚	unit	131m 9s	hbase-server in the patch passed.
		159m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9b7b4a69420e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `600be60`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/2/testReport/
Max. process+thread count	4183 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-05T10:17:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 27s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	shadedjars	6m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 32s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	6m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	140m 41s	hbase-server in the patch passed.
		166m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 5e76a7572c56 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `600be60`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/2/testReport/
Max. process+thread count	4396 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil

Please add a UT at TestSplitWALManager for this condition, as already suggested by @ramkrish86 . This is a simple, yet an important fix, we should safeguard SplitWALManager from inadvertent changes that could suppress this fix.

Apache-HBase · 2021-01-07T06:20:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 58s	master passed
+1 💚	checkstyle	1m 22s	master passed
+1 💚	spotbugs	2m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 55s	the patch passed
-0 ⚠️	checkstyle	1m 24s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	22m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 40s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		50m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux a1e5e14b038f 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

Nice test, just a couple of nits

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java

…me local variables

virajjasani

+1, Thanks @dasanjan1296

virajjasani · 2021-01-07T07:06:16Z

Once QA results are in, will merge this PR.

virajjasani · 2021-01-07T07:47:23Z

I think there seems some problem with Jenkins, the recent build is aborted and I am not able to schedule a new build.

virajjasani · 2021-01-07T08:04:50Z

New build is triggered

Apache-HBase · 2021-01-07T08:28:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 52s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 11s	master passed
+1 💚	checkstyle	1m 30s	master passed
+1 💚	spotbugs	2m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 53s	the patch passed
-0 ⚠️	checkstyle	1m 39s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 0s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 18s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		47m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 03e7bcf25404 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-07T08:29:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 5s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	shadedjars	7m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
+1 💚	shadedjars	6m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	151m 43s	hbase-server in the patch passed.
		179m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 56c2d55b32e7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
Default Java	AdoptOpenJDK-1.8.0_232-b09
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/3/testReport/
Max. process+thread count	4277 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-07T08:29:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 28s	master passed
+1 💚	compile	1m 26s	master passed
+1 💚	shadedjars	9m 26s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 11s	the patch passed
+1 💚	compile	1m 21s	the patch passed
+1 💚	javac	1m 21s	the patch passed
+1 💚	shadedjars	9m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 50s	the patch passed
		_ Other Tests _
-1 ❌	unit	8m 28s	hbase-server in the patch failed.
		48m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6e9755005681 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/testReport/
Max. process+thread count	582 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-07T09:34:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 17s	master passed
+1 💚	compile	1m 0s	master passed
+1 💚	shadedjars	7m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	7m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
-1 ❌	unit	9m 16s	hbase-server in the patch failed.
		37m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6d9facbeff13 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
Default Java	AdoptOpenJDK-1.8.0_232-b09
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/testReport/
Max. process+thread count	529 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-01-07T09:41:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 59s	master passed
+1 💚	checkstyle	1m 12s	master passed
+1 💚	spotbugs	2m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 52s	the patch passed
-0 ⚠️	checkstyle	1m 12s	hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 55s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		44m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 0bd34b12de67 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/console
versions	git=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2021-01-07T09:57:32Z

Build is taking more time. Let me merge this PR, I have validated test locally and we also have result available here https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/5/testReport/org.apache.hadoop.hbase.master/TestSplitWALManager/

Signed-off-by: Pankaj <pankajkumar@apache.org> Signed-off-by: ramkrish86 <ramkrishna@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org>

Apache-HBase · 2021-01-07T11:45:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 19s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	shadedjars	6m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	6m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	138m 44s	hbase-server in the patch passed.
		167m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2844
JIRA Issue	HBASE-25445
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 578792f21d92 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `a414361`
Default Java	AdoptOpenJDK-11.0.6+10
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/testReport/
Max. process+thread count	3991 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2844/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil

I had some nits regarding the current UT, but since this got merged already, we may follow on another jira.

wchevreuil · 2021-01-07T12:06:12Z

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java

@@ -86,6 +98,58 @@ public void teardown() throws Exception {
    TEST_UTIL.shutdownMiniCluster();
  }

+  @Test
+  public void testWALArchiveWithDifferentWalAndRootFS() throws Exception{
+    HBaseTestingUtility test_util_2 = new HBaseTestingUtility();


nit: non static variables should follow camel case style.

wchevreuil · 2021-01-07T12:06:54Z

hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java

+    }
+    executor.submitProcedure(splitProcedure);
+    LOG.info("Submitted SplitProcedure.");
+    test_util_2.waitFor(30000, () -> executor.getProcedures().stream()


Shouldn't we filter by the split procedure submitted and assert it has completed success?

…he#2844) Signed-off-by: Pankaj <pankajkumar@apache.org> Signed-off-by: ramkrish86 <ramkrishna@apache.org> Signed-off-by: Viraj Jasani <vjasani@apache.org> (cherry picked from commit cb720e0) Change-Id: I5a1f7bf4ce1bcfcd7e3534f4e7d516869df304dd

HBASE-25445: Use WAL FS instead of master FS

513b6b4

dasanjan1296 closed this Jan 5, 2021

dasanjan1296 reopened this Jan 5, 2021

pankaj72981 approved these changes Jan 5, 2021

View reviewed changes

ramkrish86 approved these changes Jan 5, 2021

View reviewed changes

virajjasani previously approved these changes Jan 5, 2021

View reviewed changes

wchevreuil reviewed Jan 5, 2021

View reviewed changes

HBASE-25445: Add UT for splitWALManager archive

df2b027

dasanjan1296 requested a review from wchevreuil January 7, 2021 05:33

Rectify LOG line

d03125f

virajjasani reviewed Jan 7, 2021

View reviewed changes

dasanjan1296 requested a review from virajjasani January 7, 2021 06:51

HBASE-25445: Address feedback; Remove un-needed result variable; Rena…

59ca6d1

…me local variables

dasanjan1296 force-pushed the HBASE-25445 branch from 73e53f7 to 59ca6d1 Compare January 7, 2021 06:55

virajjasani approved these changes Jan 7, 2021

View reviewed changes

virajjasani merged commit 4b62152 into apache:master Jan 7, 2021

wchevreuil reviewed Jan 7, 2021

View reviewed changes

dasanjan1296 mentioned this pull request Jan 7, 2021

HBASE-25475: Improve UT added as part of HBASE-25445 in TestSplitWALManager #2855

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25445: Use WAL FS instead of master FS in SplitWALManager #2844

HBASE-25445: Use WAL FS instead of master FS in SplitWALManager #2844

dasanjan1296 commented Jan 5, 2021

pankaj72981 left a comment

ramkrish86 left a comment

dasanjan1296 commented Jan 5, 2021

Apache-HBase commented Jan 5, 2021

Apache-HBase commented Jan 5, 2021

virajjasani left a comment •

edited

Loading

Apache-HBase commented Jan 5, 2021

Apache-HBase commented Jan 5, 2021

Apache-HBase commented Jan 5, 2021

wchevreuil left a comment •

edited

Loading

Apache-HBase commented Jan 7, 2021

virajjasani left a comment

virajjasani left a comment

virajjasani commented Jan 7, 2021

virajjasani commented Jan 7, 2021

virajjasani commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

virajjasani commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

wchevreuil left a comment

wchevreuil Jan 7, 2021

wchevreuil Jan 7, 2021

HBASE-25445: Use WAL FS instead of master FS in SplitWALManager #2844

HBASE-25445: Use WAL FS instead of master FS in SplitWALManager #2844

Conversation

dasanjan1296 commented Jan 5, 2021

pankaj72981 left a comment

Choose a reason for hiding this comment

ramkrish86 left a comment

Choose a reason for hiding this comment

dasanjan1296 commented Jan 5, 2021

Apache-HBase commented Jan 5, 2021

Apache-HBase commented Jan 5, 2021

virajjasani left a comment • edited Loading

Choose a reason for hiding this comment

Apache-HBase commented Jan 5, 2021

Apache-HBase commented Jan 5, 2021

Apache-HBase commented Jan 5, 2021

wchevreuil left a comment • edited Loading

Choose a reason for hiding this comment

Apache-HBase commented Jan 7, 2021

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani commented Jan 7, 2021

virajjasani commented Jan 7, 2021

virajjasani commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

virajjasani commented Jan 7, 2021

Apache-HBase commented Jan 7, 2021

wchevreuil left a comment

Choose a reason for hiding this comment

wchevreuil Jan 7, 2021

Choose a reason for hiding this comment

wchevreuil Jan 7, 2021

Choose a reason for hiding this comment

virajjasani left a comment •

edited

Loading

wchevreuil left a comment •

edited

Loading