Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-25463 fix comment error of append.rb #2845

Merged
merged 1 commit into from
Jan 5, 2021
Merged

HBASE-25463 fix comment error of append.rb #2845

merged 1 commit into from
Jan 5, 2021

Conversation

whua3
Copy link
Contributor

@whua3 whua3 commented Jan 5, 2021

fix comment error of append.rb

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 rubocop 0m 3s There were no new rubocop issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
5m 36s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2845/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2845
Optional Tests dupname asflicense rubocop
uname Linux 30f394c56644 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8584263
Max. process+thread count 47 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2845/1/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 46s master passed
+1 💚 javadoc 0m 17s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
+1 💚 unit 7m 0s hbase-shell in the patch passed.
16m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2845/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2845
Optional Tests javac javadoc unit
uname Linux 589a909489b5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8584263
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2845/1/testReport/
Max. process+thread count 2193 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2845/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 10s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 23s master passed
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 6s the patch passed
+1 💚 javadoc 0m 14s the patch passed
_ Other Tests _
+1 💚 unit 6m 55s hbase-shell in the patch passed.
18m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2845/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2845
Optional Tests javac javadoc unit
uname Linux 87f46b651b9f 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8584263
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2845/1/testReport/
Max. process+thread count 2362 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2845/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani merged commit 90ff550 into apache:master Jan 5, 2021
virajjasani pushed a commit that referenced this pull request Jan 5, 2021
@whua3 @virajjasani
HBASE-25463 fix comment error of append.rb (#2845)
cec9f18 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Jan 5, 2021
@whua3 @virajjasani
HBASE-25463 fix comment error of append.rb (#2845)
3f2b9b3 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Jan 5, 2021
@whua3 @virajjasani
HBASE-25463 fix comment error of append.rb (#2845)
a94ebd7 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Jan 5, 2021
@whua3 @virajjasani
HBASE-25463 fix comment error of append.rb (#2845)
20a9bad 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Jan 5, 2021
@whua3 @virajjasani
HBASE-25463 fix comment error of append.rb (#2845)
e37ec1b 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
@whua3 @virajjasani
HBASE-25463 fix comment error of append.rb (apache#2845)
d8148aa 
Signed-off-by: Viraj Jasani <vjasani@apache.org>
(cherry picked from commit 20a9bad)

Change-Id: I3ed35ea0ad1a23ae633fca45cb7bd917da904ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whua3 @Apache-HBase @virajjasani