HBASE-25459 WAL can't be cleaned in some scenes #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchevreuil
reviewed
Jan 6, 2021
| for (Long sid: sequenceids.values()) { | ||
| for (Map.Entry<? , Long> entry : sequenceids.entrySet()){ | ||
| if (entry.getKey() instanceof ImmutableByteArray && entry.getKey().toString().equals("METAFAMILY")){ | ||
| LOG.info("ColumnFamily is METAFAMILY! continue ..."); |
There was a problem hiding this comment.
Should we rather do trace here?
There was a problem hiding this comment.
no, I think. delete it at a new commit
| @@ -250,7 +250,12 @@ void updateStore(byte[] encodedRegionName, byte[] familyName, Long sequenceId, | |||
| */ | |||
| private static long getLowestSequenceId(Map<?, Long> sequenceids) { | |||
| long lowest = HConstants.NO_SEQNUM; | |||
| for (Long sid: sequenceids.values()) { | |||
| for (Map.Entry<? , Long> entry : sequenceids.entrySet()){ | |||
| if (entry.getKey() instanceof ImmutableByteArray && entry.getKey().toString().equals("METAFAMILY")){ | |||
There was a problem hiding this comment.
Do we need this extra entry.getKey() instanceof ImmutableByteArray check? Wouldn't entry.getKey().toString().equals("METAFAMILY") already gives false in the cases entry.getKey() isn't a ImmutableByteArray?
There was a problem hiding this comment.
entry.getKey() instanceof ImmutableByteArray is for future, but it's no need at now , I has deleted it !
wchevreuil
reviewed
Jan 6, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
the UT has updated, pelease review again! @wchevreuil |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Jan 7, 2021
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
wchevreuil
pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
wchevreuil
pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 6a401d8)
wchevreuil
pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 6a401d8)
wchevreuil
pushed a commit
that referenced
this pull request
Jan 11, 2021
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 6a401d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.