-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25910 - Fix port assignment test #3308
Conversation
disabling the port auto assignment and check the exception root cause against BindException.
test succeeded with hdfs cache being disabled.
🎊 +1 overall
This message was automatically generated. |
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments, almost there. Nice work @vli02
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java
Outdated
Show resolved
Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending with one last comment. Once done, will merge it.
hbase-server/src/test/java/org/apache/hadoop/hbase/TestClusterPortAssignment.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: David Manning <david.manning@salesforce.com> Signed-off-by: Viraj Jasani <vjasani@apache.org>
Disabled port auto assignment when port is in use.
Disabled hdfs cache as restart mini cluster will fail in one jvm if hdfs cache is enabled.
Use exception root case to determine address/port in use with BindException.