-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25950 add basic compaction server metric #3350
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@Apache9 mind help review this PR,sir? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big concerns just some minor but annoying nits...
private long compactingCellCount; | ||
private long compactedCellCount; | ||
private long totalNumberOfRequests; | ||
@Nullable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nullable but we initialize it with an empty array?
hbase-client/src/main/java/org/apache/hadoop/hbase/CompactionServerMetricsBuilder.java
Show resolved
Hide resolved
hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/CompactionServerListTmpl.jamon
Show resolved
Hide resolved
int inconsistentNodeNum = 0; | ||
String masterVersion = VersionInfo.getVersion(); | ||
for(ServerName serverName:serverNames) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a new line?
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
the ServerLoad has RegionLoad, ReplicationLoadSource/ReplicationLoadSink metrics, which is nothing to do with Compaction server. So, introduce CompactionServerLoad, only has compaction related metircs