Add unit tests for org.apache.hadoop.hbase.util.Strings #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
petersomogyi
requested changes
Jul 9, 2019
There was a problem hiding this comment.
Could you fix the Checkstyle issues related to indentation? HBase project uses 2 spaces instead of 4.
You can check our Checkstyle rules here and import it to your favorite IDE. :)
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestStrings.java
Show resolved
Hide resolved
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestStrings.java
Show resolved
Hide resolved
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestStrings.java
Outdated
Show resolved
Hide resolved
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestStrings.java
Outdated
Show resolved
Hide resolved
|
Please create an HBASE Jira for this change at https://issues.apache.org/jira/secure/Dashboard.jspa and use it in the commit name. |
EricHetti
force-pushed
the
add-diffblue-tests
branch
from
810b02e to
07eee10
Compare
|
🎊 +1 overall
This message was automatically generated. |
These tests were written using Diffblue Cover.
EricHetti
force-pushed
the
add-diffblue-tests
branch
from
07eee10 to
910bfb5
Compare
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
approved these changes
Jul 10, 2019
asfgit
pushed a commit
that referenced
this pull request
Jul 10, 2019
…363) These tests were written using Diffblue Cover.
asfgit
pushed a commit
that referenced
this pull request
Jul 10, 2019
…363) These tests were written using Diffblue Cover.
asfgit
pushed a commit
that referenced
this pull request
Jul 10, 2019
…363) These tests were written using Diffblue Cover.
asfgit
pushed a commit
that referenced
this pull request
Jul 10, 2019
…363) These tests were written using Diffblue Cover.
asfgit
pushed a commit
that referenced
this pull request
Jul 10, 2019
…363) These tests were written using Diffblue Cover.
asfgit
pushed a commit
that referenced
this pull request
Jul 10, 2019
…363) These tests were written using Diffblue Cover.
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…pache#363) These tests were written using Diffblue Cover. (cherry picked from commit f5cff4b) Change-Id: Ida942c2efe1c69e3eec2f70a6dc0e3fb86c63753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've analysed your codebase and noticed that
org.apache.hadoop.hbase.util.Stringsis not fully tested.I've written some tests for the methods in this class with the help of Diffblue Cover.
Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.