Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes #374

Merged
merged 2 commits into from
Aug 5, 2019
Merged

HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRangeUtils and Classes #374

merged 2 commits into from
Aug 5, 2019
+136 −0

Conversation

EricHetti
Copy link
Contributor

I've analysed your codebase and noticed that org.apache.hadoop.hbase.util.ByteRangeUtils and Classes is not fully tested.
I've written some tests for the methods in this class with the help of Diffblue Cover.

Hopefully, these tests will help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other classes that you consider important in a subsequent PR.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 36 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 286 master passed
+1 compile 23 master passed
+1 checkstyle 25 master passed
+1 shadedjars 286 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 48 master passed
+1 javadoc 21 master passed
_ Patch Compile Tests _
+1 mvninstall 275 the patch passed
+1 compile 24 the patch passed
+1 javac 24 the patch passed
+1 checkstyle 26 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 298 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 855 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 56 the patch passed
+1 javadoc 21 the patch passed
_ Other Tests _
-1 unit 177 hbase-common in the patch failed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2793
Reason Tests
Failed junit tests hadoop.hbase.util.TestClasses
hadoop.hbase.util.TestByteRangeUtils
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/1/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d28bb9f87450 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 438bf32
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/1/artifact/out/patch-unit-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/1/testReport/
Max. process+thread count 109 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@EricHetti EricHetti force-pushed the add-diffblue-tests-2 branch from 7dc8d6d to 6f0496f Compare July 15, 2019 08:18
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 173 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 252 master passed
+1 compile 22 master passed
+1 checkstyle 24 master passed
+1 shadedjars 268 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 40 master passed
+1 javadoc 21 master passed
_ Patch Compile Tests _
+1 mvninstall 238 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
+1 checkstyle 23 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 269 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 735 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 48 the patch passed
+1 javadoc 20 the patch passed
_ Other Tests _
+1 unit 185 hbase-common in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2667
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/2/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d2a82951eeff 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 74731c2
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/2/testReport/
Max. process+thread count 337 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 57 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 351 master passed
+1 compile 27 master passed
+1 checkstyle 31 master passed
+1 shadedjars 356 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 49 master passed
+1 javadoc 25 master passed
_ Patch Compile Tests _
+1 mvninstall 313 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
+1 checkstyle 30 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 345 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1005 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 61 the patch passed
+1 javadoc 23 the patch passed
_ Other Tests _
+1 unit 205 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3294
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b50697b62218 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / cc38de1
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/testReport/
Max. process+thread count 342 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@EricHetti
Copy link
Contributor Author

Hi @HorizonNet Is there any other changes you would like me to make to this PR?

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 65 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 257 master passed
+1 compile 23 master passed
+1 checkstyle 22 master passed
+1 shadedjars 262 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 39 master passed
+1 javadoc 20 master passed
_ Patch Compile Tests _
-1 mvninstall 245 root in the patch failed.
+1 compile 20 the patch passed
+1 javac 20 the patch passed
+1 checkstyle 22 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 259 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 236 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 495 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 758 The patch causes 10 errors with Hadoop v3.1.2.
+1 findbugs 46 the patch passed
+1 javadoc 20 the patch passed
_ Other Tests _
+1 unit 176 hbase-common in the patch passed.
+1 asflicense 10 The patch does not generate ASF License warnings.
2320
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux caf17aafa6cf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 72e58a8
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/artifact/out/patch-mvninstall-root.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/testReport/
Max. process+thread count 325 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 69 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 290 master passed
+1 compile 21 master passed
+1 checkstyle 22 master passed
+1 shadedjars 266 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 40 master passed
+1 javadoc 20 master passed
_ Patch Compile Tests _
+1 mvninstall 256 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
+1 checkstyle 23 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 275 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 777 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 51 the patch passed
+1 javadoc 19 the patch passed
_ Other Tests _
+1 unit 181 hbase-common in the patch passed.
+1 asflicense 9 The patch does not generate ASF License warnings.
2668
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 34b677a06d68 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 00075ea
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/testReport/
Max. process+thread count 292 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 67 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 237 master passed
+1 compile 22 master passed
+1 checkstyle 24 master passed
+1 shadedjars 258 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 19 master passed
0 spotbugs 51 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 49 master passed
_ Patch Compile Tests _
+1 mvninstall 235 the patch passed
+1 compile 20 the patch passed
+1 javac 20 the patch passed
+1 checkstyle 23 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 260 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 733 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 18 the patch passed
+1 findbugs 54 the patch passed
_ Other Tests _
+1 unit 180 hbase-common in the patch passed.
+1 asflicense 10 The patch does not generate ASF License warnings.
2507
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0c621ff85b68 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / c9293b0
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/testReport/
Max. process+thread count 347 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@EricHetti
Copy link
Contributor Author

Hi @HorizonNet just following up Is there any other changes you would like me to make to this PR?

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 98 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 349 master passed
+1 compile 27 master passed
+1 checkstyle 31 master passed
+1 shadedjars 388 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 23 master passed
0 spotbugs 62 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 60 master passed
_ Patch Compile Tests _
+1 mvninstall 360 the patch passed
+1 compile 29 the patch passed
+1 javac 29 the patch passed
+1 checkstyle 31 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 388 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1082 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 24 the patch passed
+1 findbugs 72 the patch passed
_ Other Tests _
+1 unit 208 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3626
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/7/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 9743acbe6a39 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / aa9679d
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/7/testReport/
Max. process+thread count 293 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/7/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 77 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 361 master passed
+1 compile 30 master passed
+1 checkstyle 33 master passed
+1 shadedjars 406 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 25 master passed
0 spotbugs 63 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 60 master passed
_ Patch Compile Tests _
+1 mvninstall 358 the patch passed
+1 compile 26 the patch passed
+1 javac 26 the patch passed
+1 checkstyle 32 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 388 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1109 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 26 the patch passed
+1 findbugs 71 the patch passed
_ Other Tests _
+1 unit 211 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3649
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/8/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d0fb5826b182 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 7f68591
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/8/testReport/
Max. process+thread count 290 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/8/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 74 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 258 master passed
+1 compile 24 master passed
+1 checkstyle 27 master passed
+1 shadedjars 282 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 52 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 49 master passed
_ Patch Compile Tests _
+1 mvninstall 259 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
+1 checkstyle 26 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 281 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 784 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 28 the patch passed
+1 findbugs 70 the patch passed
_ Other Tests _
+1 unit 194 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
2775
Subsystem Report/Notes
Docker Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/1/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 8a61696549f8 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 7f68591
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/1/testReport/
Max. process+thread count 260 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 159 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 406 master passed
+1 compile 21 master passed
+1 checkstyle 23 master passed
+1 shadedjars 267 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 18 master passed
0 spotbugs 50 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 48 master passed
_ Patch Compile Tests _
+1 mvninstall 278 the patch passed
+1 compile 25 the patch passed
+1 javac 25 the patch passed
+1 checkstyle 25 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 283 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 729 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 19 the patch passed
+1 findbugs 54 the patch passed
_ Other Tests _
+1 unit 170 hbase-common in the patch passed.
+1 asflicense 9 The patch does not generate ASF License warnings.
2886
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/2/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4f5746856f68 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 9615c64
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/2/testReport/
Max. process+thread count 287 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 64 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 1 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 329 master passed
+1 compile 27 master passed
+1 checkstyle 31 master passed
+1 shadedjars 345 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 27 master passed
0 spotbugs 64 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 61 master passed
_ Patch Compile Tests _
+1 mvninstall 313 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
+1 checkstyle 30 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 348 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1005 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 23 the patch passed
+1 findbugs 65 the patch passed
_ Other Tests _
+1 unit 191 hbase-common in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
3279
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f3335a3cd83b 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 0e34dcb
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/testReport/
Max. process+thread count 292 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 58 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 247 master passed
+1 compile 19 master passed
+1 checkstyle 22 master passed
+1 shadedjars 260 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 18 master passed
0 spotbugs 47 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 45 master passed
_ Patch Compile Tests _
+1 mvninstall 242 the patch passed
+1 compile 21 the patch passed
+1 javac 21 the patch passed
+1 checkstyle 22 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 254 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 740 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 18 the patch passed
+1 findbugs 52 the patch passed
_ Other Tests _
+1 unit 162 hbase-common in the patch passed.
+1 asflicense 9 The patch does not generate ASF License warnings.
2485
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b037029ef1a6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 06f5c43
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/testReport/
Max. process+thread count 287 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/4/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 133 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 331 master passed
+1 compile 28 master passed
+1 checkstyle 31 master passed
+1 shadedjars 332 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 24 master passed
0 spotbugs 63 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 60 master passed
_ Patch Compile Tests _
+1 mvninstall 299 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
+1 checkstyle 29 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 332 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 974 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 28 the patch passed
+1 findbugs 69 the patch passed
_ Other Tests _
+1 unit 201 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3332
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux bbc53801038b 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 06f5c43
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/testReport/
Max. process+thread count 257 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet reviewed Jul 23, 2019
View reviewed changes
Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor NIT. Remaining stuff LGTM.

hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteRangeUtils.java Outdated Show resolved Hide resolved
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestClasses.java Outdated Show resolved Hide resolved
@EricHetti EricHetti force-pushed the add-diffblue-tests-2 branch from 6f0496f to 6bd6e08 Compare July 23, 2019 12:02
@EricHetti
Copy link
Contributor Author

Left a minor NIT. Remaining stuff LGTM.

Hi @HorizonNet I have replaced the imports with static imports as requested :)

HorizonNet
HorizonNet approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending QA.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 57 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 314 master passed
+1 compile 21 master passed
+1 checkstyle 24 master passed
+1 shadedjars 291 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 52 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 49 master passed
_ Patch Compile Tests _
+1 mvninstall 326 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
-1 checkstyle 26 hbase-common: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 267 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 901 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 56 the patch passed
_ Other Tests _
+1 unit 180 hbase-common in the patch passed.
+1 asflicense 13 The patch does not generate ASF License warnings.
2966
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 228466ca3d2c 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / e74d501
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/6/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
Copy link
Contributor

@Braavos96 There are two Checkstyle warnings related to the import order. Could you please resolve them and then we should be ready to merge.

@EricHetti EricHetti force-pushed the add-diffblue-tests-2 branch from 6bd6e08 to d4989bf Compare July 23, 2019 14:25
@EricHetti
Copy link
Contributor Author

Hi @HorizonNet I have changed the order of the static assert imports

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 56 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 336 master passed
+1 compile 22 master passed
+1 checkstyle 24 master passed
+1 shadedjars 269 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 18 master passed
0 spotbugs 45 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 42 master passed
_ Patch Compile Tests _
+1 mvninstall 291 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
-1 checkstyle 24 hbase-common: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 290 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1016 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 19 the patch passed
+1 findbugs 54 the patch passed
_ Other Tests _
+1 unit 177 hbase-common in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
3074
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/7/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 7d618202a105 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / e74d501
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/7/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/7/testReport/
Max. process+thread count 293 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/7/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
Copy link
Contributor

@Braavos96 Imports are still in the wrong order. If I remember correctly they should come first before any other imports. You can also check that by running mvn checkstyle:check locally for the module.

@EricHetti
HBASE-22677 Add unit tests for org.apache.hadoop.hbase.util.ByteRange…
c2fe8ff 
….Utils and Classes

These tests were written using Diffblue Cover.
@EricHetti EricHetti force-pushed the add-diffblue-tests-2 branch from d4989bf to c2fe8ff Compare July 23, 2019 15:56
@EricHetti
Copy link
Contributor Author

@Braavos96 Imports are still in the wrong order. If I remember correctly they should come first before any other imports. You can also check that by running mvn checkstyle:check locally for the module.

Hi @HorizonNet I moved the static imports to the top. I also tried the command mvn checkstyle:check and it showed a few modules are failing.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 289 master passed
+1 compile 22 master passed
+1 checkstyle 25 master passed
+1 shadedjars 270 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 48 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 46 master passed
_ Patch Compile Tests _
+1 mvninstall 295 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
-1 checkstyle 24 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedjars 275 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 907 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 54 the patch passed
_ Other Tests _
+1 unit 183 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
2861
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/30/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e3ba91881e16 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 11f30de
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/30/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/30/testReport/
Max. process+thread count 289 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/30/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 88 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 469 master passed
+1 compile 20 master passed
+1 checkstyle 26 master passed
+1 shadedjars 274 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 50 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 48 master passed
_ Patch Compile Tests _
+1 mvninstall 348 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
-1 checkstyle 26 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 307 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1025 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 21 the patch passed
+1 findbugs 58 the patch passed
_ Other Tests _
+1 unit 182 hbase-common in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
3363
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/31/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 707702c619ca 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / f68cda3
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/31/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/31/testReport/
Max. process+thread count 289 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/31/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 88 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 333 master passed
+1 compile 24 master passed
+1 checkstyle 26 master passed
+1 shadedjars 299 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 54 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 52 master passed
_ Patch Compile Tests _
+1 mvninstall 335 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
-1 checkstyle 27 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 304 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1019 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 21 the patch passed
+1 findbugs 63 the patch passed
_ Other Tests _
+1 unit 177 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3251
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/32/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 34d0fb9275f5 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 0c80d5b
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/32/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/32/testReport/
Max. process+thread count 258 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/32/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 293 master passed
+1 compile 23 master passed
+1 checkstyle 22 master passed
+1 shadedjars 257 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 18 master passed
0 spotbugs 45 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 44 master passed
_ Patch Compile Tests _
-1 mvninstall 86 root in the patch failed.
+1 compile 21 the patch passed
+1 javac 21 the patch passed
-1 checkstyle 21 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 260 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 73 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 146 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 222 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 18 the patch passed
+1 findbugs 56 the patch passed
_ Other Tests _
+1 unit 172 hbase-common in the patch passed.
+1 asflicense 10 The patch does not generate ASF License warnings.
1634
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/33/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1dd787b48970 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / c286a31
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/33/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/33/artifact/out/diff-checkstyle-hbase-common.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/33/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/33/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/33/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/33/testReport/
Max. process+thread count 288 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/33/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@EricHetti
Copy link
Contributor Author

Hi @HorizonNet is there any other changes to be made to this PR?

@HorizonNet
Copy link
Contributor

@Braavos96 Yes, the build is still failing (see above).

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 369 master passed
+1 compile 40 master passed
+1 checkstyle 47 master passed
+1 shadedjars 302 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 19 master passed
0 spotbugs 46 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 43 master passed
_ Patch Compile Tests _
+1 mvninstall 287 the patch passed
+1 compile 21 the patch passed
+1 javac 21 the patch passed
-1 checkstyle 23 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 260 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 888 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 18 the patch passed
+1 findbugs 52 the patch passed
_ Other Tests _
+1 unit 170 hbase-common in the patch passed.
+1 asflicense 10 The patch does not generate ASF License warnings.
2936
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/34/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4633d40d0377 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 124fa34
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/34/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/34/testReport/
Max. process+thread count 292 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/34/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 144 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 480 master passed
+1 compile 27 master passed
+1 checkstyle 35 master passed
+1 shadedjars 365 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 29 master passed
0 spotbugs 67 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 65 master passed
_ Patch Compile Tests _
+1 mvninstall 452 the patch passed
+1 compile 27 the patch passed
+1 javac 27 the patch passed
-1 checkstyle 31 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 362 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1360 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 28 the patch passed
+1 findbugs 80 the patch passed
_ Other Tests _
+1 unit 205 hbase-common in the patch passed.
+1 asflicense 14 The patch does not generate ASF License warnings.
4210
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/35/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 297684cbdafd 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / e3a54e7
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/35/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/35/testReport/
Max. process+thread count 258 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/35/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
-1 mvninstall 19 root in master failed.
+1 compile 27 master passed
+1 checkstyle 22 master passed
+1 shadedjars 284 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 49 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 46 master passed
_ Patch Compile Tests _
-1 mvninstall 15 root in the patch failed.
+1 compile 21 the patch passed
+1 javac 21 the patch passed
-1 checkstyle 23 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 274 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 11 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 24 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 35 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 53 the patch passed
_ Other Tests _
+1 unit 187 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
1207
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d8c5f9273d3b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 4a61c8b
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/diff-checkstyle-hbase-common.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/36/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 63 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 319 master passed
+1 compile 21 master passed
+1 checkstyle 23 master passed
+1 shadedjars 283 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 18 master passed
0 spotbugs 52 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 50 master passed
_ Patch Compile Tests _
+1 mvninstall 321 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
-1 checkstyle 24 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 262 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 947 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 21 the patch passed
+1 findbugs 56 the patch passed
_ Other Tests _
+1 unit 184 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3027
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/37/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f7a48993be71 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 4a61c8b
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/37/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/37/testReport/
Max. process+thread count 289 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/37/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 55 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 384 master passed
+1 compile 27 master passed
+1 checkstyle 29 master passed
+1 shadedjars 348 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 24 master passed
0 spotbugs 62 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 59 master passed
_ Patch Compile Tests _
+1 mvninstall 376 the patch passed
+1 compile 26 the patch passed
+1 javac 26 the patch passed
-1 checkstyle 30 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 344 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1199 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 25 the patch passed
+1 findbugs 68 the patch passed
_ Other Tests _
+1 unit 210 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3665
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/39/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a5d2e0b57227 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 373c2dc
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/39/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/39/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/39/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 37 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 291 master passed
+1 compile 21 master passed
+1 checkstyle 21 master passed
+1 shadedjars 273 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 18 master passed
0 spotbugs 49 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 46 master passed
_ Patch Compile Tests _
+1 mvninstall 296 the patch passed
+1 compile 21 the patch passed
+1 javac 21 the patch passed
-1 checkstyle 23 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 272 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 919 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 56 the patch passed
_ Other Tests _
+1 unit 186 hbase-common in the patch passed.
+1 asflicense 13 The patch does not generate ASF License warnings.
2876
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/40/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f527e1b5570c 4.4.0-157-generic #185-Ubuntu SMP Tue Jul 23 09:17:01 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 586e177
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/40/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/40/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/40/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 94 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
-1 mvninstall 284 root in master failed.
+1 compile 26 master passed
+1 checkstyle 35 master passed
+1 shadedjars 381 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 29 master passed
0 spotbugs 76 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 70 master passed
_ Patch Compile Tests _
-1 mvninstall 185 root in the patch failed.
+1 compile 26 the patch passed
+1 javac 26 the patch passed
-1 checkstyle 29 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 382 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 122 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 259 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 394 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 24 the patch passed
+1 findbugs 68 the patch passed
_ Other Tests _
+1 unit 209 hbase-common in the patch passed.
+1 asflicense 13 The patch does not generate ASF License warnings.
2346
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f209fa9b38e1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 9a4a8ef
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/artifact/out/diff-checkstyle-hbase-common.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/testReport/
Max. process+thread count 292 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/41/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 38 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 1 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 282 master passed
+1 compile 20 master passed
+1 checkstyle 22 master passed
+1 shadedjars 261 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 53 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 50 master passed
_ Patch Compile Tests _
+1 mvninstall 283 the patch passed
+1 compile 21 the patch passed
+1 javac 21 the patch passed
-1 checkstyle 22 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 260 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 889 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 19 the patch passed
+1 findbugs 57 the patch passed
_ Other Tests _
+1 unit 171 hbase-common in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
2782
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/42/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b85737291bd2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / caa0535
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/42/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/42/testReport/
Max. process+thread count 286 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/42/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 70 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 325 master passed
+1 compile 21 master passed
+1 checkstyle 26 master passed
+1 shadedjars 292 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 48 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 45 master passed
_ Patch Compile Tests _
+1 mvninstall 322 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
-1 checkstyle 27 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 295 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1001 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 19 the patch passed
+1 findbugs 54 the patch passed
_ Other Tests _
+1 unit 175 hbase-common in the patch passed.
+1 asflicense 11 The patch does not generate ASF License warnings.
3108
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/43/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e033f69c5f73 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 24b970e
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/43/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/43/testReport/
Max. process+thread count 260 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/43/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xcangCRM
Copy link
Contributor

+1
@HorizonNet Are you planning merging this one? thanks

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 90 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 386 master passed
+1 compile 23 master passed
+1 checkstyle 27 master passed
+1 shadedjars 296 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 21 master passed
0 spotbugs 53 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 51 master passed
_ Patch Compile Tests _
+1 mvninstall 319 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
-1 checkstyle 26 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 295 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1001 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 62 the patch passed
+1 findbugs 74 the patch passed
_ Other Tests _
+1 unit 180 hbase-common in the patch passed.
+1 asflicense 10 The patch does not generate ASF License warnings.
3326
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/44/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 57db74295901 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 4829c18
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/44/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/44/testReport/
Max. process+thread count 256 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/44/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@xcangCRM
Copy link
Contributor

@Braavos96
good work. could you please fix the minor check-style issue that hadoop-qa reported before we merge it.

@HorizonNet
Copy link
Contributor

@xcangCRM I'm doing it, as soon as the last Checkstyle issue is resolved (see my comments and build output above).

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 88 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 332 master passed
+1 compile 25 master passed
+1 checkstyle 31 master passed
+1 shadedjars 310 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 22 master passed
0 spotbugs 58 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 54 master passed
_ Patch Compile Tests _
+1 mvninstall 333 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
-1 checkstyle 27 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedjars 293 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1054 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 57 the patch passed
_ Other Tests _
+1 unit 177 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3269
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/45/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1ac957eda11e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 35acf3c
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/45/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/45/testReport/
Max. process+thread count 258 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/45/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 184 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 345 master passed
+1 compile 22 master passed
+1 checkstyle 25 master passed
+1 shadedjars 299 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 47 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 46 master passed
_ Patch Compile Tests _
+1 mvninstall 298 the patch passed
+1 compile 24 the patch passed
+1 javac 24 the patch passed
-1 checkstyle 26 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 296 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1031 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 55 the patch passed
_ Other Tests _
+1 unit 183 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
3298
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/46/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 34d821b2c872 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 8cfc46d
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/46/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/46/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/46/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Aug 1, 2019

Please finish this @HorizonNet ? Thanks.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 84 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
-1 mvninstall 79 root in master failed.
+1 compile 19 master passed
+1 checkstyle 20 master passed
+1 shadedjars 259 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 17 master passed
0 spotbugs 46 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 43 master passed
_ Patch Compile Tests _
-1 mvninstall 79 root in the patch failed.
+1 compile 20 the patch passed
+1 javac 20 the patch passed
-1 checkstyle 21 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 256 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 52 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 104 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 157 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 17 the patch passed
+1 findbugs 51 the patch passed
_ Other Tests _
+1 unit 168 hbase-common in the patch passed.
+1 asflicense 9 The patch does not generate ASF License warnings.
1369
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 33eb0c36e5b5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 237229c
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/diff-checkstyle-hbase-common.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/47/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 187 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 389 master passed
+1 compile 21 master passed
+1 checkstyle 24 master passed
+1 shadedjars 263 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 22 master passed
0 spotbugs 54 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 53 master passed
_ Patch Compile Tests _
+1 mvninstall 328 the patch passed
+1 compile 23 the patch passed
+1 javac 23 the patch passed
-1 checkstyle 24 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 287 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 895 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 20 the patch passed
+1 findbugs 62 the patch passed
_ Other Tests _
+1 unit 198 hbase-common in the patch passed.
+1 asflicense 13 The patch does not generate ASF License warnings.
3194
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/48/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 375240ab7d6b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / 7e6684b
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/48/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/48/testReport/
Max. process+thread count 292 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/48/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 294 master passed
+1 compile 20 master passed
+1 checkstyle 25 master passed
+1 shadedjars 275 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 18 master passed
0 spotbugs 49 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 46 master passed
_ Patch Compile Tests _
+1 mvninstall 287 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
-1 checkstyle 23 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 274 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 938 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 21 the patch passed
+1 findbugs 53 the patch passed
_ Other Tests _
+1 unit 183 hbase-common in the patch passed.
+1 asflicense 12 The patch does not generate ASF License warnings.
2899
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/49/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2a2f3f4f6df4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / a6f0653
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/49/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/49/testReport/
Max. process+thread count 289 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/49/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 43 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 339 master passed
+1 compile 24 master passed
+1 checkstyle 28 master passed
+1 shadedjars 290 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 22 master passed
0 spotbugs 57 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 53 master passed
_ Patch Compile Tests _
+1 mvninstall 326 the patch passed
+1 compile 24 the patch passed
+1 javac 24 the patch passed
-1 checkstyle 26 hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 295 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1028 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 24 the patch passed
+1 findbugs 63 the patch passed
_ Other Tests _
+1 unit 187 hbase-common in the patch passed.
+1 asflicense 13 The patch does not generate ASF License warnings.
3181
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/50/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 3b3f73f3f25c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / abb60fa
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/50/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/50/testReport/
Max. process+thread count 291 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/50/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
Copy link
Contributor

@Apache9 I added a commit, which should resolve the last Checkstyle issue. Let's wait for QA.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 125 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+1 mvninstall 344 master passed
+1 compile 20 master passed
+1 checkstyle 22 master passed
+1 shadedjars 269 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 20 master passed
0 spotbugs 50 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 49 master passed
_ Patch Compile Tests _
+1 mvninstall 358 the patch passed
+1 compile 22 the patch passed
+1 javac 22 the patch passed
+1 checkstyle 23 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 287 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1034 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 19 the patch passed
+1 findbugs 55 the patch passed
_ Other Tests _
+1 unit 171 hbase-common in the patch passed.
+1 asflicense 9 The patch does not generate ASF License warnings.
3218
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/51/artifact/out/Dockerfile
GITHUB PR #374
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 941161ae3036 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-374/out/precommit/personality/provided.sh
git revision master / abb60fa
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/51/testReport/
Max. process+thread count 290 (vs. ulimit of 10000)
modules C: hbase-common U: hbase-common
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-374/51/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet merged commit d0e5ea1 into apache:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorizonNet HorizonNet HorizonNet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EricHetti @Apache-HBase @HorizonNet @xcangCRM @Apache9