HBASE-22610 [BucketCache] Rename hbase.offheapcache.minblocksize. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A small comment, i am not sure if these are the required changes for this ticket. But still kindly review when anyone has time. I tried to understand what else i can do but couldnt make other changes. |
|
Usually, we don't actual remove an old attribute, the way we prefer is marking the old attribute deprecated, then introduce a new one, and LOG warn message and remind them of the new one when user uses the old attribute. |
|
@Reidddddd |
|
@SyedMurtazaHassan There must be some in codebase, expecting your next pull request. |
|
@Reidddddd For example here is my understanding; Then further in the code BLOCKCACHE_BLOCKSIZE_KEY was used in a variable named blockSize. Now this variable will also be deprecated to something like blockSizeNew and even further in the code blockSize is used in a variable name bucketCache which will also be deprecated to bucketCacheNew. Is my understanding correct? All the related variables will also be deprecated right? |
|
💔 -1 overall
This message was automatically generated. |
|
Please refer to HBASE-22598, it is a typical example. Codes are better than words. |
|
💔 -1 overall
This message was automatically generated. |
…recated old attribute and introduced a new one
|
@Reidddddd |
…oved unnecessary import
|
💔 -1 overall
This message was automatically generated. |
|
LGTM，will commit tomorrow if no further comment from other members. |
Reidddddd
requested changes
Jul 22, 2019
| @@ -17,9 +17,6 @@ | |||
| */ | |||
| package org.apache.hadoop.hbase.io.hfile; | |||
|
|
|||
| import static org.apache.hadoop.hbase.HConstants.BUCKET_CACHE_IOENGINE_KEY; | |||
| import static org.apache.hadoop.hbase.HConstants.BUCKET_CACHE_SIZE_KEY; | |||
There was a problem hiding this comment.
Why this two configs got deleted?
There was a problem hiding this comment.
I accidentally included import static org.apache.hadoop.hbase.HConstants.* and removed the above two ones and didnt notice that. But now it is clean. Thanks.
There was a problem hiding this comment.
Please find the latest commit with the changes.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Reidddddd
approved these changes
Jul 23, 2019
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.