HBASE-26622 Update error-prone to 2.10 #3979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Long time no see @madrob Seems there is something wrong while building with error prone enabled? |
|
Yes, the latest version doesn’t work with java 8. Still should fix the other bugs tho |
|
Maybe we could change the pre commit compile stage to use java11 with --release=8? |
ndimiduk
requested changes
Jan 5, 2022
| @@ -1102,10 +1102,11 @@ private int calculateHashForKey(Cell cell) { | |||
| */ | |||
| @Override | |||
| public KeyValue clone() throws CloneNotSupportedException { | |||
| super.clone(); | |||
| @@ -68,11 +68,6 @@ | |||
| <activation> | |||
| <activeByDefault>false</activeByDefault> | |||
| </activation> | |||
| <properties> | |||
There was a problem hiding this comment.
Since this check is run by precommit testing only, I'm fine with bumping this check over to JDK11. Please make sure that test-patch is calling it from the jdk11 incantation instead of the jdk8 incantation.
Doesn't work, #3974 |
Per my read of https://errorprone.info/docs/installation#jdk-8, 2.10.0 is the last version with support for JDK8. |
|
@madrob I applied this patch but reverted your changes to Please revert the change to If you want me to take it over, let me know. Thanks for the drive-by 👍 |
|
Also, the checkstyle violation reported by the build bot is valid, https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3979/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
|
Fair Nick, if you can find the time |
madrob
commented
Jan 12, 2022
| System.arraycopy(this.bytes, this.offset, b, 0, this.length); | ||
| KeyValue ret = new KeyValue(b, 0, b.length); | ||
| KeyValue ret = (KeyValue) super.clone(); | ||
| ret.bytes = new byte[this.length]; |
There was a problem hiding this comment.
Maybe simpler to use Arrays.copyOfRange here?
|
Resolved via #4133 |
|
Thanks for getting us started, @madrob ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-26622
Tested via
mvn package -DskipTests -PerrorProne- it probably won't build with Java 8, but it's an opt-in profile so I'm not worried about strict compatibility. Did not run unit tests.There are (still? newly?) hundreds of warnings that y'all can sort through as follow-on work.