-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pom.xml #4041
Update pom.xml #4041
Conversation
Make it so assembly >> A typo error causing confusion.
Thank you for trying to fix 'typo' but I do not think it is a typo? From my understanding, the comment means Make it(set skipAssembly to true), so assembly:single does nothing in here |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
I agree with Duo's evaluation that this wasn't a typo. I also think the current phrasing in confusing. @acgoliyan would you mind rephrasing this as something like "we do not want invocations of 'assembly:single' to do anything in this module."? |
Make it so assembly >> A typo error causing confusion.