Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22759 Add user info to AUDITLOG events when doing grant/revoke (master) #428

Merged
merged 3 commits into from
Aug 7, 2019

Conversation

anmolnar
Copy link
Contributor

Add audit logger to grant() and revoke() methods of MasterRpcServices.
master version

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 145 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 464 master passed
+1 compile 75 master passed
+1 checkstyle 99 master passed
+1 shadedjars 363 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 48 master passed
0 spotbugs 315 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 312 master passed
_ Patch Compile Tests _
+1 mvninstall 427 the patch passed
+1 compile 75 the patch passed
+1 javac 75 the patch passed
+1 checkstyle 99 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 353 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1418 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 46 the patch passed
+1 findbugs 312 the patch passed
_ Other Tests _
-1 unit 14534 hbase-server in the patch failed.
+1 asflicense 35 The patch does not generate ASF License warnings.
19357
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/1/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 76cf1366ad5d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 11f30de
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/1/testReport/
Max. process+thread count 4577 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 155 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 483 master passed
+1 compile 75 master passed
+1 checkstyle 102 master passed
+1 shadedjars 358 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 49 master passed
0 spotbugs 298 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 294 master passed
_ Patch Compile Tests _
+1 mvninstall 428 the patch passed
+1 compile 81 the patch passed
+1 javac 81 the patch passed
+1 checkstyle 105 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 379 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1345 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 45 the patch passed
+1 findbugs 314 the patch passed
_ Other Tests _
-1 unit 1766 hbase-server in the patch failed.
+1 asflicense 15 The patch does not generate ASF License warnings.
6532
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestScanner
hadoop.hbase.regionserver.TestBlocksScanned
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/2/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4c077dda3b1e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / f68cda3
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/2/testReport/
Max. process+thread count 670 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 62 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 415 master passed
+1 compile 75 master passed
+1 checkstyle 100 master passed
+1 shadedjars 371 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 49 master passed
0 spotbugs 334 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 331 master passed
_ Patch Compile Tests _
+1 mvninstall 395 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
+1 checkstyle 109 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 357 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1244 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 63 the patch passed
+1 findbugs 349 the patch passed
_ Other Tests _
-1 unit 18029 hbase-server in the patch failed.
+1 asflicense 37 The patch does not generate ASF License warnings.
22534
Reason Tests
Failed junit tests hadoop.hbase.master.TestMasterShutdown
hadoop.hbase.client.TestFromClientSide3
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/3/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 7d3042942128 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 0c80d5b
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/3/testReport/
Max. process+thread count 4592 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 10 #428 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/4/console
versions git=2.7.4
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 43 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 85 root in master failed.
-1 compile 25 hbase-server in master failed.
+1 checkstyle 70 master passed
+1 shadedjars 256 branch has no errors when building our shaded downstream artifacts.
-1 javadoc 28 hbase-server in master failed.
0 spotbugs 322 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 36 hbase-server in master failed.
_ Patch Compile Tests _
-1 mvninstall 82 root in the patch failed.
-1 compile 34 hbase-server in the patch failed.
-1 javac 34 hbase-server in the patch failed.
+1 checkstyle 70 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 263 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 73 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 144 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 215 The patch causes 10 errors with Hadoop v3.1.2.
-1 javadoc 29 hbase-server in the patch failed.
-1 findbugs 34 hbase-server in the patch failed.
_ Other Tests _
-1 unit 29 hbase-server in the patch failed.
+1 asflicense 9 The patch does not generate ASF License warnings.
1379
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 0fd9448bb96f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / e3a54e7
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/branch-compile-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/branch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-compile-hbase-server.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-javac-3.1.2.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/testReport/
Max. process+thread count 87 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/6/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 69 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 328 master passed
+1 compile 58 master passed
+1 checkstyle 88 master passed
+1 shadedjars 290 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 35 master passed
0 spotbugs 287 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 284 master passed
_ Patch Compile Tests _
+1 mvninstall 329 the patch passed
+1 compile 64 the patch passed
+1 javac 64 the patch passed
+1 checkstyle 91 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 299 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1030 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 40 the patch passed
+1 findbugs 294 the patch passed
_ Other Tests _
-1 unit 1737 hbase-server in the patch failed.
+1 asflicense 13 The patch does not generate ASF License warnings.
5470
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestDateTieredCompactionPolicyOverflow
TEST-null
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/5/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5b0c1f3ba72c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 124fa34
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/5/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/5/testReport/
Max. process+thread count 672 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 200 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 449 master passed
+1 compile 62 master passed
+1 checkstyle 91 master passed
+1 shadedjars 339 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 38 master passed
0 spotbugs 289 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 287 master passed
_ Patch Compile Tests _
+1 mvninstall 382 the patch passed
+1 compile 65 the patch passed
+1 javac 65 the patch passed
+1 checkstyle 98 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 339 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1164 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 37 the patch passed
-1 findbugs 42 hbase-server in the patch failed.
_ Other Tests _
-1 unit 43 hbase-server in the patch failed.
+1 asflicense 11 The patch does not generate ASF License warnings.
4079
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/8/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 982f49711a34 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 4a61c8b
Default Java 1.8.0_181
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/8/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/8/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/8/testReport/
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/8/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 58 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 375 master passed
+1 compile 69 master passed
+1 checkstyle 92 master passed
+1 shadedjars 355 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 45 master passed
0 spotbugs 449 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 47 hbase-server in master failed.
_ Patch Compile Tests _
+1 mvninstall 389 the patch passed
+1 compile 73 the patch passed
+1 javac 73 the patch passed
+1 checkstyle 95 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 351 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1200 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 43 the patch passed
+1 findbugs 324 the patch passed
_ Other Tests _
-1 unit 16311 hbase-server in the patch failed.
+1 asflicense 32 The patch does not generate ASF License warnings.
20306
Reason Tests
Failed junit tests hadoop.hbase.client.TestFromClientSide
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/10/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d8ac0b9c4287 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 373c2dc
Default Java 1.8.0_181
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/10/artifact/out/branch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/10/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/10/testReport/
Max. process+thread count 4772 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/10/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@petersomogyi petersomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there are additional events in MasterRpcServices class that would require similar audit logs? Those could be covered in a different issue, no need to modify this commit.

@@ -2584,6 +2586,11 @@ public GrantResponse grant(RpcController controller, GrantRequest request)
if (master.cpHost != null) {
master.cpHost.postGrant(perm, mergeExistingPermissions);
}
User caller = RpcServer.getRequestUser().orElse(null);
if (AUDITLOG.isTraceEnabled()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With parameterized logging in slf4j we don't need isTraceEnabled or isDebugEnabled checks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll remove it.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 83 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 330 master passed
+1 compile 59 master passed
+1 checkstyle 90 master passed
+1 shadedjars 301 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 41 master passed
0 spotbugs 272 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 270 master passed
_ Patch Compile Tests _
+1 mvninstall 337 the patch passed
+1 compile 59 the patch passed
+1 javac 59 the patch passed
+1 checkstyle 87 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 295 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1017 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 278 the patch passed
_ Other Tests _
-1 unit 14066 hbase-server in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
17772
Reason Tests
Failed junit tests hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/14/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 15691e8c2893 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 24b970e
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/14/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/14/testReport/
Max. process+thread count 4428 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/14/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 138 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 436 master passed
+1 compile 73 master passed
+1 checkstyle 99 master passed
+1 shadedjars 374 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 47 master passed
0 spotbugs 333 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 330 master passed
_ Patch Compile Tests _
+1 mvninstall 414 the patch passed
+1 compile 79 the patch passed
+1 javac 79 the patch passed
+1 checkstyle 101 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 354 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1227 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 35 the patch passed
+1 findbugs 245 the patch passed
_ Other Tests _
-1 unit 13390 hbase-server in the patch failed.
+1 asflicense 25 The patch does not generate ASF License warnings.
17779
Reason Tests
Failed junit tests hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/15/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 99cb5757572b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 4829c18
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/15/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/15/testReport/
Max. process+thread count 4488 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/15/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 91 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 342 master passed
+1 compile 60 master passed
+1 checkstyle 90 master passed
+1 shadedjars 311 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 34 master passed
0 spotbugs 283 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 282 master passed
_ Patch Compile Tests _
+1 mvninstall 327 the patch passed
+1 compile 58 the patch passed
+1 javac 58 the patch passed
+1 checkstyle 86 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 297 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1086 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 37 the patch passed
+1 findbugs 299 the patch passed
_ Other Tests _
-1 unit 13563 hbase-server in the patch failed.
+1 asflicense 26 The patch does not generate ASF License warnings.
17442
Reason Tests
Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaSameHosts
hadoop.hbase.master.TestMasterRepairMode
hadoop.hbase.master.TestSplitRegionWhileRSCrash
hadoop.hbase.master.TestMasterNotCarryTable
hadoop.hbase.master.TestDLSFSHLog
hadoop.hbase.master.balancer.TestBalancerStatusTagInJMXMetrics
hadoop.hbase.master.balancer.TestFavoredNodeTableImport
hadoop.hbase.master.TestCloseAnOpeningRegion
hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicasWithoutZKCoordinated
hadoop.hbase.master.procedure.TestCloneSnapshotProcedure
hadoop.hbase.master.balancer.TestRegionLocationFinder
hadoop.hbase.master.procedure.TestSCPWithoutMeta
hadoop.hbase.master.procedure.TestEnableTableProcedure
hadoop.hbase.TestJMXListener
hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency
hadoop.hbase.replication.regionserver.TestDrainReplicationQueuesForStandBy
hadoop.hbase.master.TestLoadProcedureError
hadoop.hbase.tool.TestCanaryTool
hadoop.hbase.master.TestMasterMetricsWrapper
hadoop.hbase.master.procedure.TestCreateNamespaceProcedure
hadoop.hbase.master.procedure.TestMasterObserverPostCalls
hadoop.hbase.master.procedure.TestDisableTableProcedure
hadoop.hbase.master.TestClusterRestartSplitWithoutZk
hadoop.hbase.TestLocalHBaseCluster
hadoop.hbase.master.TestMigrateNamespaceTable
hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash
hadoop.hbase.master.procedure.TestIgnoreUnknownFamily
hadoop.hbase.master.procedure.TestModifyTableProcedure
hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicas
hadoop.hbase.replication.regionserver.TestSyncReplicationShipperQuit
hadoop.hbase.master.assignment.TestRegionBypass
hadoop.hbase.master.TestRetainAssignmentOnRestartSplitWithoutZk
hadoop.hbase.master.procedure.TestProcedurePriority
hadoop.hbase.replication.TestReplicationDroppedTables
hadoop.hbase.master.procedure.TestReopenTableRegionsProcedureBackoff
hadoop.hbase.replication.regionserver.TestReplicator
hadoop.hbase.master.TestServerCrashProcedureCarryingMetaStuck
hadoop.hbase.master.procedure.TestSCPWithMeta
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.master.balancer.TestFavoredStochasticBalancerPickers
hadoop.hbase.master.procedure.TestDeleteTableProcedure
hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/16/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a71279617459 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 35acf3c
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/16/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/16/testReport/
Max. process+thread count 4474 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/16/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 76 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 329 master passed
+1 compile 56 master passed
+1 checkstyle 87 master passed
+1 shadedjars 306 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 40 master passed
0 spotbugs 254 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 251 master passed
_ Patch Compile Tests _
+1 mvninstall 341 the patch passed
+1 compile 59 the patch passed
+1 javac 59 the patch passed
+1 checkstyle 87 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 306 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1096 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 35 the patch passed
+1 findbugs 259 the patch passed
_ Other Tests _
+1 unit 13084 hbase-server in the patch passed.
+1 asflicense 26 The patch does not generate ASF License warnings.
16859
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/17/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 3ae1e4667567 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 8cfc46d
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/17/testReport/
Max. process+thread count 4363 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/17/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 32 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 323 master passed
+1 compile 59 master passed
+1 checkstyle 88 master passed
+1 shadedjars 316 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 44 master passed
0 spotbugs 278 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 276 master passed
_ Patch Compile Tests _
+1 mvninstall 346 the patch passed
+1 compile 80 the patch passed
+1 javac 80 the patch passed
+1 checkstyle 109 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 318 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1039 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 39 the patch passed
+1 findbugs 292 the patch passed
_ Other Tests _
+1 unit 8961 hbase-server in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
12766
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/18/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 30cf60deaca1 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 237229c
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/18/testReport/
Max. process+thread count 4236 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/18/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 61 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 369 master passed
+1 compile 73 master passed
+1 checkstyle 92 master passed
+1 shadedjars 349 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 65 master passed
0 spotbugs 410 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 409 master passed
_ Patch Compile Tests _
+1 mvninstall 395 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
+1 checkstyle 94 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 373 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1318 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 43 the patch passed
+1 findbugs 330 the patch passed
_ Other Tests _
+1 unit 16003 hbase-server in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
20515
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/19/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6a224a551655 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 7e6684b
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/19/testReport/
Max. process+thread count 4608 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/19/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anmolnar
Copy link
Contributor Author

anmolnar commented Aug 2, 2019

@petersomogyi Good question. We're talking about an almost 3000-line file, so potentially yes, but I have to take a closer look.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 213 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 413 master passed
+1 compile 52 master passed
+1 checkstyle 75 master passed
+1 shadedjars 265 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 36 master passed
0 spotbugs 248 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 245 master passed
_ Patch Compile Tests _
+1 mvninstall 284 the patch passed
+1 compile 51 the patch passed
+1 javac 51 the patch passed
+1 checkstyle 71 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 263 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 897 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 31 the patch passed
+1 findbugs 258 the patch passed
_ Other Tests _
-1 unit 16059 hbase-server in the patch failed.
+1 asflicense 40 The patch does not generate ASF License warnings.
19615
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/20/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux cc7711733bbe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / a6f0653
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/20/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/20/testReport/
Max. process+thread count 4637 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/20/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 33 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 331 master passed
+1 compile 55 master passed
+1 checkstyle 87 master passed
+1 shadedjars 300 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 34 master passed
0 spotbugs 255 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 253 master passed
_ Patch Compile Tests _
+1 mvninstall 316 the patch passed
+1 compile 56 the patch passed
+1 javac 56 the patch passed
+1 checkstyle 88 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 290 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 990 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 265 the patch passed
_ Other Tests _
+1 unit 8654 hbase-server in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
12193
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/21/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux c9f6db7afe9d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / abb60fa
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/21/testReport/
Max. process+thread count 4335 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/21/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 187 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 342 master passed
+1 compile 62 master passed
+1 checkstyle 93 master passed
+1 shadedjars 300 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 38 master passed
0 spotbugs 268 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 266 master passed
_ Patch Compile Tests _
+1 mvninstall 352 the patch passed
+1 compile 61 the patch passed
+1 javac 61 the patch passed
+1 checkstyle 92 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 303 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1068 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 37 the patch passed
+1 findbugs 282 the patch passed
_ Other Tests _
-1 unit 13640 hbase-server in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
17566
Reason Tests
Failed junit tests hadoop.hbase.master.procedure.TestSCPWithoutMeta
hadoop.hbase.wal.TestWALSplitCompressed
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
hadoop.hbase.regionserver.TestRegionFavoredNodes
hadoop.hbase.regionserver.TestOpenSeqNumUnexpectedIncrease
hadoop.hbase.master.balancer.TestFavoredNodeTableImport
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService
hadoop.hbase.regionserver.TestScannerWithCorruptHFile
hadoop.hbase.regionserver.TestQosFunction
hadoop.hbase.security.access.TestAccessController2
hadoop.hbase.regionserver.TestClearRegionBlockCache
hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
hadoop.hbase.wal.TestWALFiltering
hadoop.hbase.wal.TestWALOpenAfterDNRollingStart
hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver
hadoop.hbase.regionserver.TestRemoveRegionMetrics
hadoop.hbase.security.access.TestTablePermissions
hadoop.hbase.master.procedure.TestSCPWithMeta
hadoop.hbase.master.balancer.TestStochasticLoadBalancerRegionReplicaReplicationGreaterThanNumNodes
hadoop.hbase.regionserver.TestCompactSplitThread
hadoop.hbase.master.procedure.TestCreateTableProcedureMuitipleRegions
hadoop.hbase.master.balancer.TestRegionLocationFinder
hadoop.hbase.security.access.TestAccessController
hadoop.hbase.master.TestDLSFSHLog
hadoop.hbase.security.visibility.TestVisibilityLabelsOpWithDifferentUsersNoACL
hadoop.hbase.regionserver.TestCompactionWithCoprocessor
hadoop.hbase.TestIOFencing
hadoop.hbase.master.procedure.TestModifyTableProcedure
hadoop.hbase.master.balancer.TestFavoredStochasticBalancerPickers
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.regionserver.TestTags
hadoop.hbase.master.procedure.TestReopenTableRegionsProcedureInfiniteLoop
hadoop.hbase.regionserver.TestEncryptionRandomKeying
hadoop.hbase.regionserver.TestCompactionFileNotFound
hadoop.hbase.TestRegionRebalancing
hadoop.hbase.regionserver.TestRegionMove
hadoop.hbase.master.procedure.TestProcedurePriority
hadoop.hbase.master.procedure.TestEnableTableProcedure
hadoop.hbase.master.procedure.TestIgnoreUnknownFamily
hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL
hadoop.hbase.regionserver.TestRegionOpen
hadoop.hbase.wal.TestWrongMetaWALFileName
hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack
hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient
hadoop.hbase.wal.TestSyncReplicationWALProvider
hadoop.hbase.regionserver.TestLogRoller
hadoop.hbase.regionserver.TestHRegionFileSystem
hadoop.hbase.regionserver.TestNewVersionBehaviorFromClientSide
hadoop.hbase.mob.compactions.TestPartitionedMobCompactor
hadoop.hbase.regionserver.TestRegionServerHostname
hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/22/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e9a970401e53 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / d0e5ea1
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/22/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/22/testReport/
Max. process+thread count 4645 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/22/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 275 master passed
+1 compile 52 master passed
+1 checkstyle 68 master passed
+1 shadedjars 257 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 32 master passed
0 spotbugs 324 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 34 hbase-server in master failed.
_ Patch Compile Tests _
+1 mvninstall 282 the patch passed
+1 compile 52 the patch passed
+1 javac 52 the patch passed
+1 checkstyle 68 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 256 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 873 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 32 the patch passed
+1 findbugs 243 the patch passed
_ Other Tests _
+1 unit 7966 hbase-server in the patch passed.
+1 asflicense 25 The patch does not generate ASF License warnings.
10899
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/23/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 11db5ea67387 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / ff96485
Default Java 1.8.0_181
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/23/artifact/out/branch-findbugs-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/23/testReport/
Max. process+thread count 4266 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/23/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 75 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 148 root in master failed.
-1 compile 33 hbase-server in master failed.
+1 checkstyle 75 master passed
+1 shadedjars 275 branch has no errors when building our shaded downstream artifacts.
-1 javadoc 20 hbase-server in master failed.
0 spotbugs 323 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 26 hbase-server in master failed.
_ Patch Compile Tests _
-1 mvninstall 75 root in the patch failed.
-1 compile 26 hbase-server in the patch failed.
-1 javac 26 hbase-server in the patch failed.
+1 checkstyle 72 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 265 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 41 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 81 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 120 The patch causes 10 errors with Hadoop v3.1.2.
-1 javadoc 17 hbase-server in the patch failed.
-1 findbugs 27 hbase-server in the patch failed.
_ Other Tests _
-1 unit 27 hbase-server in the patch failed.
+1 asflicense 10 The patch does not generate ASF License warnings.
1357
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 2406dcb0d75c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 8411668
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/branch-compile-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/branch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-compile-hbase-server.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-javac-3.1.2.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/testReport/
Max. process+thread count 87 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/29/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 71 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 356 master passed
+1 compile 52 master passed
+1 checkstyle 75 master passed
+1 shadedjars 295 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 32 master passed
0 spotbugs 256 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 254 master passed
_ Patch Compile Tests _
+1 mvninstall 322 the patch passed
+1 compile 52 the patch passed
+1 javac 52 the patch passed
+1 checkstyle 72 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 289 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 955 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 31 the patch passed
+1 findbugs 250 the patch passed
_ Other Tests _
-1 unit 16650 hbase-server in the patch failed.
+1 asflicense 38 The patch does not generate ASF License warnings.
20188
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/24/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1d2ec6f5aa50 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / f6ece8d
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/24/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/24/testReport/
Max. process+thread count 4938 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/24/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 65 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 403 master passed
+1 compile 70 master passed
+1 checkstyle 100 master passed
+1 shadedjars 362 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 43 master passed
0 spotbugs 321 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 319 master passed
_ Patch Compile Tests _
+1 mvninstall 388 the patch passed
+1 compile 72 the patch passed
+1 javac 72 the patch passed
+1 checkstyle 99 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 362 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1199 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 42 the patch passed
+1 findbugs 330 the patch passed
_ Other Tests _
-1 unit 16819 hbase-server in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
21172
Reason Tests
Failed junit tests hadoop.hbase.replication.TestReplicationWithTags
hadoop.hbase.replication.master.TestRecoverStandbyProcedure
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.replication.TestMultiSlaveReplication
hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedWithRecovery
hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.replication.TestRemoveFromSerialReplicationPeer
hadoop.hbase.replication.TestReplicationStatusBothNormalAndRecoveryLagging
hadoop.hbase.replication.TestReplicationDroppedTables
hadoop.hbase.replication.TestReplicationStatusAfterLagging
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/25/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6b6ac5c78fc0 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 66a2fc5
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/25/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/25/testReport/
Max. process+thread count 4603 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/25/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 53 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 356 root in master failed.
+1 compile 58 master passed
+1 checkstyle 78 master passed
+1 shadedjars 295 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 33 master passed
0 spotbugs 232 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 230 master passed
_ Patch Compile Tests _
-1 mvninstall 282 root in the patch failed.
+1 compile 54 the patch passed
+1 javac 54 the patch passed
+1 checkstyle 75 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 273 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 225 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 502 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 784 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 36 the patch passed
+1 findbugs 242 the patch passed
_ Other Tests _
+1 unit 15519 hbase-server in the patch passed.
+1 asflicense 36 The patch does not generate ASF License warnings.
18470
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/26/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux d5b614be2b0b 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / b021c36
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/26/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/26/artifact/out/patch-mvninstall-root.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/26/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/26/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/26/artifact/out/patch-javac-3.1.2.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/26/testReport/
Max. process+thread count 5141 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/26/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 87 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 327 master passed
+1 compile 59 master passed
+1 checkstyle 87 master passed
+1 shadedjars 304 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 40 master passed
0 spotbugs 299 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 297 master passed
_ Patch Compile Tests _
+1 mvninstall 327 the patch passed
+1 compile 60 the patch passed
+1 javac 60 the patch passed
+1 checkstyle 84 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 303 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1013 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 41 the patch passed
+1 findbugs 309 the patch passed
_ Other Tests _
-1 unit 14636 hbase-server in the patch failed.
+1 asflicense 25 The patch does not generate ASF License warnings.
18394
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/27/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 5cff48ab1433 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / b021c36
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/27/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/27/testReport/
Max. process+thread count 4594 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/27/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 121 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 365 master passed
+1 compile 58 master passed
+1 checkstyle 87 master passed
+1 shadedjars 276 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 39 master passed
0 spotbugs 289 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 286 master passed
_ Patch Compile Tests _
+1 mvninstall 334 the patch passed
+1 compile 62 the patch passed
+1 javac 62 the patch passed
+1 checkstyle 79 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 284 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1155 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 256 the patch passed
_ Other Tests _
-1 unit 16007 hbase-server in the patch failed.
+1 asflicense 43 The patch does not generate ASF License warnings.
19921
Reason Tests
Failed junit tests hadoop.hbase.regionserver.wal.TestFSHLog
hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedNewOp
hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
hadoop.hbase.replication.TestReplicationEmptyWALRecovery
hadoop.hbase.replication.TestReplicationDroppedTables
hadoop.hbase.client.TestClientScannerRPCTimeout
hadoop.hbase.regionserver.wal.TestLogRolling
hadoop.hbase.replication.TestReplicationKillMasterRSWithSeparateOldWALs
hadoop.hbase.TestHBaseTestingUtility
hadoop.hbase.replication.TestSyncReplicationActive
hadoop.hbase.replication.TestSerialReplication
hadoop.hbase.regionserver.TestScannerWithBulkload
hadoop.hbase.regionserver.TestCompactionArchiveIOException
hadoop.hbase.regionserver.TestCompactionFileNotFound
hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleWAL
hadoop.hbase.replication.TestRemoveFromSerialReplicationPeer
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.regionserver.wal.TestProtobufLog
hadoop.hbase.client.TestSnapshotCloneIndependence
hadoop.hbase.replication.TestReplicationStatusBothNormalAndRecoveryLagging
hadoop.hbase.client.TestMobSnapshotFromClient
hadoop.hbase.client.TestCloneSnapshotFromClientAfterSplittingRegion
hadoop.hbase.replication.TestSerialReplicationFailover
hadoop.hbase.regionserver.TestFSErrorsExposed
hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.regionserver.TestClearRegionBlockCache
hadoop.hbase.replication.TestSyncReplicationStandbyKillRS
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.regionserver.TestJoinedScanners
hadoop.hbase.regionserver.TestPriorityRpc
hadoop.hbase.regionserver.TestHdfsSnapshotHRegion
hadoop.hbase.regionserver.TestRegionServerAbortTimeout
hadoop.hbase.replication.TestSerialSyncReplication
hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleWAL
hadoop.hbase.regionserver.TestRegionReplicasWithRestartScenarios
hadoop.hbase.regionserver.TestCompactingToCellFlatMapMemStore
hadoop.hbase.client.TestMobCloneSnapshotFromClientAfterSplittingRegion
TEST-null
hadoop.hbase.regionserver.wal.TestWALReplayCompressed
hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.regionserver.TestTags
hadoop.hbase.regionserver.TestCompactSplitThread
hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController
hadoop.hbase.regionserver.TestDeleteMobTable
hadoop.hbase.regionserver.TestRegionServerAbort
hadoop.hbase.replication.TestReplicationSyncUpTool
hadoop.hbase.client.TestRestoreSnapshotFromClientSimple
hadoop.hbase.regionserver.TestCompactionState
hadoop.hbase.TestMovedRegionsCleaner
hadoop.hbase.replication.TestReplicationStatusAfterLagging
hadoop.hbase.replication.TestReplicationDisableInactivePeer
hadoop.hbase.replication.TestReplicationProcedureRetry
hadoop.hbase.regionserver.wal.TestAsyncLogRolling
hadoop.hbase.regionserver.TestOpenSeqNumUnexpectedIncrease
hadoop.hbase.regionserver.TestPerColumnFamilyFlush
hadoop.hbase.client.TestAdmin2
hadoop.hbase.client.TestAsyncRegionLocator
hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable
hadoop.hbase.replication.multiwal.TestReplicationKillMasterRSCompressedWithMultipleAsyncWAL
hadoop.hbase.regionserver.TestHRegionFileSystem
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/28/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 1a8ee00a16d3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 8411668
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/28/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/28/testReport/
Max. process+thread count 4786 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/28/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 115 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 405 master passed
+1 compile 78 master passed
+1 checkstyle 108 master passed
+1 shadedjars 363 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 46 master passed
0 spotbugs 312 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 309 master passed
_ Patch Compile Tests _
+1 mvninstall 369 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
+1 checkstyle 98 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 350 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1140 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 44 the patch passed
+1 findbugs 295 the patch passed
_ Other Tests _
-1 unit 13053 hbase-server in the patch failed.
+1 asflicense 33 The patch does not generate ASF License warnings.
17370
Reason Tests
Failed junit tests hadoop.hbase.master.TestGetLastFlushedSequenceId
hadoop.hbase.security.access.TestWithDisabledAuthorization
hadoop.hbase.coprocessor.TestCoprocessorStop
hadoop.hbase.filter.TestColumnRangeFilter
hadoop.hbase.master.TestMirroringTableStateManager
hadoop.hbase.filter.TestMultiRowRangeFilter
hadoop.hbase.master.procedure.TestSCP
hadoop.hbase.TestRegionLoad
hadoop.hbase.master.TestMasterMetrics
hadoop.hbase.master.TestMasterRestartAfterDisablingTable
hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd
hadoop.hbase.io.encoding.TestBufferedDataBlockEncoder
hadoop.hbase.io.encoding.TestEncodedSeekers
hadoop.hbase.filter.TestFilterListOnMini
hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors
hadoop.hbase.TestGlobalMemStoreSize
hadoop.hbase.master.procedure.TestProcedurePriority
hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicasWithoutZKCoordinated
hadoop.hbase.master.procedure.TestModifyTableProcedure
TEST-null
hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
hadoop.hbase.master.procedure.TestReopenTableRegionsProcedureBackoff
hadoop.hbase.io.encoding.TestDataBlockEncoders
hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash
hadoop.hbase.master.TestCatalogJanitorCluster
hadoop.hbase.filter.TestFilterWrapper
hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry
hadoop.hbase.filter.TestScanRowPrefix
hadoop.hbase.master.TestRollingRestart
hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient
hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
hadoop.hbase.master.TestMaster
hadoop.hbase.master.TestMetaShutdownHandler
hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes
hadoop.hbase.fs.TestBlockReorderBlockLocation
hadoop.hbase.master.TestMigrateNamespaceTable
hadoop.hbase.coprocessor.TestNegativeMemStoreSizeWithSlowCoprocessor
hadoop.hbase.TestMultiVersions
hadoop.hbase.master.TestCatalogJanitorInMemoryStates
hadoop.hbase.io.encoding.TestChangingEncoding
hadoop.hbase.coprocessor.TestRegionObserverInterface
hadoop.hbase.security.access.TestNamespaceCommands
hadoop.hbase.TestJMXConnectorServer
hadoop.hbase.master.TestDLSFSHLog
hadoop.hbase.master.locking.TestLockManager
hadoop.hbase.master.TestDLSAsyncFSWAL
hadoop.hbase.security.access.TestAccessController2
hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter
hadoop.hbase.coprocessor.TestIncrementTimeRange
hadoop.hbase.coprocessor.TestWALObserver
hadoop.hbase.master.TestServerCrashProcedureCarryingMetaStuck
hadoop.hbase.master.TestClusterRestartFailover
hadoop.hbase.coprocessor.TestRegionObserverBypass
hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver
hadoop.hbase.master.procedure.TestSCPWithoutZKCoordinated
hadoop.hbase.master.TestMetaAssignmentWithStopMaster
hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObserver
hadoop.hbase.master.locking.TestLockProcedure
hadoop.hbase.master.TestTableStateManager
hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt
hadoop.hbase.master.TestMasterFailover
hadoop.hbase.master.procedure.TestModifyNamespaceProcedure
hadoop.hbase.master.TestMasterRepairMode
hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService
hadoop.hbase.security.access.TestAccessController3
hadoop.hbase.security.access.TestScanEarlyTermination
hadoop.hbase.master.procedure.TestSCPWithoutMetaWithoutZKCoordinated
hadoop.hbase.TestMetaTableAccessor
hadoop.hbase.master.TestRegionPlacement2
hadoop.hbase.coprocessor.TestMasterObserverToModifyTableSchema
hadoop.hbase.master.TestMasterFailoverBalancerPersistence
hadoop.hbase.master.TestSplitRegionWhileRSCrash
hadoop.hbase.master.TestMasterFileSystemWithWALDir
hadoop.hbase.TestAcidGuaranteesWithEagerPolicy
hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS
hadoop.hbase.master.TestClusterRestart
hadoop.hbase.filter.TestFilterWithScanLimits
hadoop.hbase.coprocessor.TestCoprocessorMetrics
hadoop.hbase.fs.TestBlockReorderMultiBlocks
hadoop.hbase.master.TestGetReplicationLoad
hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/30/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6e3cf56104f4 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / da114ac
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/30/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/30/testReport/
Max. process+thread count 4603 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/30/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 96 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 328 master passed
+1 compile 60 master passed
+1 checkstyle 93 master passed
+1 shadedjars 303 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 36 master passed
0 spotbugs 278 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 276 master passed
_ Patch Compile Tests _
+1 mvninstall 333 the patch passed
+1 compile 61 the patch passed
+1 javac 61 the patch passed
+1 checkstyle 89 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 306 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1029 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 37 the patch passed
+1 findbugs 280 the patch passed
_ Other Tests _
+1 unit 14638 hbase-server in the patch passed.
+1 asflicense 33 The patch does not generate ASF License warnings.
18406
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/31/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 6c291d197925 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 3f524ab
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/31/testReport/
Max. process+thread count 4776 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/31/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 65 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 365 master passed
+1 compile 70 master passed
+1 checkstyle 98 master passed
+1 shadedjars 351 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 43 master passed
0 spotbugs 316 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 314 master passed
_ Patch Compile Tests _
+1 mvninstall 379 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
+1 checkstyle 92 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 349 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1189 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 43 the patch passed
+1 findbugs 319 the patch passed
_ Other Tests _
-1 unit 16715 hbase-server in the patch failed.
+1 asflicense 35 The patch does not generate ASF License warnings.
20971
Reason Tests
Failed junit tests hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.master.assignment.TestOpenRegionProcedureHang
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/32/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 8e5117f27b98 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / ad3674f
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/32/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/32/testReport/
Max. process+thread count 4904 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/32/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 104 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 18 root in master failed.
-1 compile 55 hbase-server in master failed.
+1 checkstyle 95 master passed
+1 shadedjars 310 branch has no errors when building our shaded downstream artifacts.
-1 javadoc 38 hbase-server in master failed.
0 spotbugs 393 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 44 hbase-server in master failed.
_ Patch Compile Tests _
-1 mvninstall 11 root in the patch failed.
-1 compile 43 hbase-server in the patch failed.
-1 javac 43 hbase-server in the patch failed.
+1 checkstyle 92 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 303 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 9 The patch causes 7 errors with Hadoop v2.8.5.
-1 hadoopcheck 18 The patch causes 7 errors with Hadoop v2.9.2.
-1 hadoopcheck 27 The patch causes 7 errors with Hadoop v3.1.2.
-1 javadoc 31 hbase-server in the patch failed.
-1 findbugs 37 hbase-server in the patch failed.
_ Other Tests _
-1 unit 39 hbase-server in the patch failed.
+1 asflicense 9 The patch does not generate ASF License warnings.
1322
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4d08813ac48e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 0867714
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/branch-compile-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/branch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-compile-hbase-server.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-javac-3.1.2.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/testReport/
Max. process+thread count 77 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/33/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@anmolnar
Copy link
Contributor Author

anmolnar commented Aug 6, 2019

@petersomogyi I added the remote address to this patch too, so I think the if condition makes sense now.

@petersomogyi
Copy link
Contributor

@petersomogyi I added the remote address to this patch too, so I think the if condition makes sense now.

Right, it makes sense this way.

Copy link
Contributor

@petersomogyi petersomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending QA

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 150 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 32 root in master failed.
-1 compile 69 hbase-server in master failed.
+1 checkstyle 100 master passed
+1 shadedjars 393 branch has no errors when building our shaded downstream artifacts.
-1 javadoc 44 hbase-server in master failed.
0 spotbugs 482 Used deprecated FindBugs config; considering switching to SpotBugs.
-1 findbugs 43 hbase-server in master failed.
_ Patch Compile Tests _
-1 mvninstall 12 root in the patch failed.
-1 compile 41 hbase-server in the patch failed.
-1 javac 41 hbase-server in the patch failed.
-1 checkstyle 101 hbase-server: The patch generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 365 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 12 The patch causes 7 errors with Hadoop v2.8.5.
-1 hadoopcheck 25 The patch causes 7 errors with Hadoop v2.9.2.
-1 hadoopcheck 36 The patch causes 7 errors with Hadoop v3.1.2.
-1 javadoc 39 hbase-server in the patch failed.
-1 findbugs 45 hbase-server in the patch failed.
_ Other Tests _
-1 unit 49 hbase-server in the patch failed.
+1 asflicense 12 The patch does not generate ASF License warnings.
1617
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ccc0b9840b96 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 3b0013d
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/branch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/branch-compile-hbase-server.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/branch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/branch-findbugs-hbase-server.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-mvninstall-root.txt
compile https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-compile-hbase-server.txt
javac https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-compile-hbase-server.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/diff-checkstyle-hbase-server.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-javac-3.1.2.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-javadoc-hbase-server.txt
findbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-findbugs-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/testReport/
Max. process+thread count 86 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/36/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 134 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 mvninstall 502 root in master failed.
+1 compile 71 master passed
+1 checkstyle 98 master passed
+1 shadedjars 371 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 43 master passed
0 spotbugs 321 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 315 master passed
_ Patch Compile Tests _
-1 mvninstall 361 root in the patch failed.
+1 compile 59 the patch passed
+1 javac 59 the patch passed
-1 checkstyle 80 hbase-server: The patch generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 282 patch has no errors when building our shaded downstream artifacts.
-1 hadoopcheck 310 The patch causes 10 errors with Hadoop v2.8.5.
-1 hadoopcheck 656 The patch causes 10 errors with Hadoop v2.9.2.
-1 hadoopcheck 1000 The patch causes 10 errors with Hadoop v3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 268 the patch passed
_ Other Tests _
-1 unit 17392 hbase-server in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
21125
Reason Tests
Failed junit tests hadoop.hbase.client.TestCloneSnapshotFromClientNormal
hadoop.hbase.client.TestAsyncTableAdminApi3
hadoop.hbase.master.assignment.TestRegionReplicaSplit
hadoop.hbase.snapshot.TestMobRestoreSnapshotHelper
hadoop.hbase.master.assignment.TestSCPGetRegionsRace
hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster
hadoop.hbase.master.procedure.TestModifyTableProcedure
hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash
hadoop.hbase.quotas.TestSuperUserQuotaPermissions
hadoop.hbase.master.TestMasterAbortAndRSGotKilled
hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
hadoop.hbase.master.assignment.TestRegionStateStore
hadoop.hbase.master.procedure.TestSplitWALProcedure
hadoop.hbase.client.TestAdmin2
hadoop.hbase.master.TestRegionPlacement2
hadoop.hbase.fs.TestBlockReorderBlockLocation
hadoop.hbase.master.cleaner.TestReplicationBarrierCleaner
hadoop.hbase.snapshot.TestSnapshotClientRetries
hadoop.hbase.quotas.TestLowLatencySpaceQuotas
hadoop.hbase.master.assignment.TestReportOnlineRegionsRace
hadoop.hbase.master.assignment.TestMasterAbortWhileMergingTable
hadoop.hbase.master.assignment.TestRegionAssignedToMultipleRegionServers
hadoop.hbase.master.TestMasterFileSystem
hadoop.hbase.master.TestDLSFSHLog
hadoop.hbase.master.assignment.TestReportRegionStateTransitionFromDeadServer
hadoop.hbase.snapshot.TestFlushSnapshotFromClient
hadoop.hbase.master.TestMasterRepairMode
hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure
TEST-null
hadoop.hbase.master.procedure.TestSCPWithoutMetaWithReplicas
hadoop.hbase.master.TestMetaAssignmentWithStopMaster
hadoop.hbase.master.assignment.TestSplitTableRegionProcedure
hadoop.hbase.master.assignment.TestModifyTableWhileMerging
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient
hadoop.hbase.master.TestMasterRestartAfterDisablingTable
hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
hadoop.hbase.master.TestSplitLogManager
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 3cc960519962 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 0867714
Default Java 1.8.0_181
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/artifact/out/branch-mvninstall-root.txt
mvninstall https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/artifact/out/patch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/artifact/out/diff-checkstyle-hbase-server.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/artifact/out/patch-javac-2.8.5.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/artifact/out/patch-javac-2.9.2.txt
hadoopcheck https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/artifact/out/patch-javac-3.1.2.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/testReport/
Max. process+thread count 4902 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/34/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 98 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 329 master passed
+1 compile 59 master passed
+1 checkstyle 95 master passed
+1 shadedjars 307 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 37 master passed
0 spotbugs 276 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 273 master passed
_ Patch Compile Tests _
+1 mvninstall 339 the patch passed
+1 compile 61 the patch passed
+1 javac 61 the patch passed
-1 checkstyle 93 hbase-server: The patch generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 302 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1035 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 37 the patch passed
+1 findbugs 279 the patch passed
_ Other Tests _
-1 unit 16624 hbase-server in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
20447
Reason Tests
Failed junit tests hadoop.hbase.client.TestAsyncRegionAdminApi2
hadoop.hbase.tool.TestBulkLoadHFiles
hadoop.hbase.tool.TestSecureBulkLoadHFiles
Subsystem Report/Notes
Docker Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/35/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux eddba0c055cc 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / eef8e14
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/35/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/35/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/35/testReport/
Max. process+thread count 4842 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/35/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 99 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 363 master passed
+1 compile 63 master passed
+1 checkstyle 98 master passed
+1 shadedjars 304 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 38 master passed
0 spotbugs 290 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 288 master passed
_ Patch Compile Tests _
+1 mvninstall 340 the patch passed
+1 compile 65 the patch passed
+1 javac 65 the patch passed
-1 checkstyle 92 hbase-server: The patch generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 302 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1043 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 38 the patch passed
+1 findbugs 285 the patch passed
_ Other Tests _
+1 unit 15048 hbase-server in the patch passed.
+1 asflicense 27 The patch does not generate ASF License warnings.
18919
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/37/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 4f9ad94c6324 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / 9d82716
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/37/artifact/out/diff-checkstyle-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/37/testReport/
Max. process+thread count 5065 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/37/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 73 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 mvninstall 382 master passed
+1 compile 58 master passed
+1 checkstyle 78 master passed
+1 shadedjars 275 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 37 master passed
0 spotbugs 241 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 239 master passed
_ Patch Compile Tests _
+1 mvninstall 340 the patch passed
+1 compile 58 the patch passed
+1 javac 58 the patch passed
-1 checkstyle 74 hbase-server: The patch generated 2 new + 11 unchanged - 0 fixed = 13 total (was 11)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 268 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1017 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 244 the patch passed
_ Other Tests _
-1 unit 14371 hbase-server in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
17958
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/38/artifact/out/Dockerfile
GITHUB PR #428
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 10f8ffca4340 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-428/out/precommit/personality/provided.sh
git revision master / f02f741
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/38/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/38/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/38/testReport/
Max. process+thread count 4871 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-428/38/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@petersomogyi
Copy link
Contributor

@anmolnar please fix the checkstyle issue. I'll merge the PR after that.

@anmolnar
Copy link
Contributor Author

anmolnar commented Aug 7, 2019

@petersomogyi done.

@petersomogyi petersomogyi merged commit 07c6bb1 into apache:master Aug 7, 2019
@anmolnar anmolnar deleted the HBASE-22759_master branch August 8, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants