Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while th… #4333

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Apr 9, 2022

…read is interrupted

@Apache9 Apache9 self-assigned this Apr 9, 2022
@Apache9
Copy link
Contributor Author

Apache9 commented Apr 9, 2022

Since this is usually used in UT I think a better way is to just throw the exception out and let the callers deal with it.

Some modified classes are marked IA.LimitedPrivate, so it is not suitable to be backported to branch-2.4. I think either we just ignore this change on branch-2.4 or we prepare a special patch for branch-2.4. But in fact I do not know what is the suitable way to fix this without throwing exception out, as if the thread is interrupted, Thread.sleep will be useless too...

@busbey FYI. This is why we eat all the spaces on some jenkins node.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 3m 42s master passed
+1 💚 compile 4m 9s master passed
+1 💚 checkstyle 1m 4s master passed
+1 💚 spotbugs 2m 45s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 17s the patch passed
+1 💚 compile 4m 2s the patch passed
+1 💚 javac 4m 2s the patch passed
+1 💚 checkstyle 1m 2s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 17m 15s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 spotbugs 3m 1s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 20s The patch does not generate ASF License warnings.
49m 29s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4333
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 7a0f6329c70e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3ae0d90
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-server hbase-testing-util U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 0s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 2m 16s master passed
+1 💚 compile 0m 45s master passed
+1 💚 shadedjars 3m 44s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 35s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 1m 59s the patch passed
+1 💚 compile 0m 44s the patch passed
+1 💚 javac 0m 44s the patch passed
+1 💚 shadedjars 3m 46s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 29s the patch passed
_ Other Tests _
+1 💚 unit 183m 42s hbase-server in the patch passed.
+1 💚 unit 1m 20s hbase-testing-util in the patch passed.
202m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4333
Optional Tests javac javadoc unit shadedjars compile
uname Linux fdea91a1a1b9 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3ae0d90
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/testReport/
Max. process+thread count 3369 (vs. ulimit of 30000)
modules C: hbase-server hbase-testing-util U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for branch
+1 💚 mvninstall 4m 14s master passed
+1 💚 compile 1m 13s master passed
+1 💚 shadedjars 4m 37s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 4s the patch passed
+1 💚 compile 1m 24s the patch passed
+1 💚 javac 1m 24s the patch passed
+1 💚 shadedjars 5m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 46s the patch passed
_ Other Tests _
+1 💚 unit 207m 40s hbase-server in the patch passed.
+1 💚 unit 1m 32s hbase-testing-util in the patch passed.
234m 43s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4333
Optional Tests javac javadoc unit shadedjars compile
uname Linux a339efc8ac50 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3ae0d90
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/testReport/
Max. process+thread count 2702 (vs. ulimit of 30000)
modules C: hbase-server hbase-testing-util U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@ddupg ddupg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9 Apache9 merged commit 8247b7c into apache:master Apr 13, 2022
Apache9 added a commit that referenced this pull request Apr 13, 2022
…read is interrupted (#4333)

Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c)
Apache9 added a commit that referenced this pull request Apr 13, 2022
…read is interrupted (#4333)

Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c)
Apache9 added a commit that referenced this pull request Apr 13, 2022
…read is interrupted (#4333)

Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c)
Apache9 added a commit that referenced this pull request Apr 13, 2022
…while thread is interrupted (#4333)"

This reverts commit c10e4bd.
Apache9 added a commit that referenced this pull request Apr 13, 2022
…while thread is interrupted (#4333)"

This reverts commit 29ce27c.
Apache9 added a commit that referenced this pull request Apr 13, 2022
…while thread is interrupted (#4333)"

This reverts commit f8b2ac0.
Apache9 added a commit that referenced this pull request Apr 13, 2022
…while thread is interrupted (#4333)"

This reverts commit 8247b7c.
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…read is interrupted (apache#4333)

Signed-off-by: Xin Sun <ddupgs@gmail.com>
(cherry picked from commit 8247b7c)
(cherry picked from commit c10e4bd)
Change-Id: I3816ce2364a96fb7ca4cd2fe6090a239677b31cb
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…while thread is interrupted (apache#4333)"

This reverts commit c10e4bd.

(cherry picked from commit 1fc1866)
Change-Id: I5b90b9ebe1ff9ded85b68513f3c931b061e46642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants