-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while th… #4333
Conversation
…read is interrupted
Since this is usually used in UT I think a better way is to just throw the exception out and let the callers deal with it. Some modified classes are marked IA.LimitedPrivate, so it is not suitable to be backported to branch-2.4. I think either we just ignore this change on branch-2.4 or we prepare a special patch for branch-2.4. But in fact I do not know what is the suitable way to fix this without throwing exception out, as if the thread is interrupted, Thread.sleep will be useless too... @busbey FYI. This is why we eat all the spaces on some jenkins node. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
…read is interrupted (apache#4333) Signed-off-by: Xin Sun <ddupgs@gmail.com> (cherry picked from commit 8247b7c) (cherry picked from commit c10e4bd) Change-Id: I3816ce2364a96fb7ca4cd2fe6090a239677b31cb
…while thread is interrupted (apache#4333)" This reverts commit c10e4bd. (cherry picked from commit 1fc1866) Change-Id: I5b90b9ebe1ff9ded85b68513f3c931b061e46642
…read is interrupted