Revert "HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit …

…while thread is interrupted (apache#4333)" This reverts commit c10e4bd. (cherry picked from commit 1fc1866) Change-Id: I5b90b9ebe1ff9ded85b68513f3c931b061e46642
vinayakphegde · Apr 14, 2022 · a3e86d7 · a3e86d7
1 parent 706d305
commit a3e86d7
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 23 deletions.
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
@@ -300,7 +300,7 @@ public Configuration getConfiguration() {
    * Wait for the specified region server to stop. Removes this thread from list of running threads.
    * @return Name of region server that just went down.
    */
-  public String waitOnRegionServer(int serverNumber) throws InterruptedException {
+  public String waitOnRegionServer(int serverNumber) {
     JVMClusterUtil.RegionServerThread regionServerThread = this.regionThreads.get(serverNumber);
     return waitOnRegionServer(regionServerThread);
   }
@@ -309,11 +309,14 @@ public String waitOnRegionServer(int serverNumber) throws InterruptedException {
    * Wait for the specified region server to stop. Removes this thread from list of running threads.
    * @return Name of region server that just went down.
    */
-  public String waitOnRegionServer(JVMClusterUtil.RegionServerThread rst)
-    throws InterruptedException {
+  public String waitOnRegionServer(JVMClusterUtil.RegionServerThread rst) {
     while (rst.isAlive()) {
-      LOG.info("Waiting on " + rst.getRegionServer().toString());
-      rst.join();
+      try {
+        LOG.info("Waiting on " + rst.getRegionServer().toString());
+        rst.join();
+      } catch (InterruptedException e) {
+        e.printStackTrace();
+      }
     }
     regionThreads.remove(rst);
     return rst.getName();
@@ -369,7 +372,7 @@ public List<JVMClusterUtil.MasterThread> getLiveMasters() {
    * Wait for the specified master to stop. Removes this thread from list of running threads.
    * @return Name of master that just went down.
    */
-  public String waitOnMaster(int serverNumber) throws InterruptedException {
+  public String waitOnMaster(int serverNumber) {
     JVMClusterUtil.MasterThread masterThread = this.masterThreads.get(serverNumber);
     return waitOnMaster(masterThread);
   }
@@ -378,10 +381,14 @@ public String waitOnMaster(int serverNumber) throws InterruptedException {
    * Wait for the specified master to stop. Removes this thread from list of running threads.
    * @return Name of master that just went down.
    */
-  public String waitOnMaster(JVMClusterUtil.MasterThread masterThread) throws InterruptedException {
+  public String waitOnMaster(JVMClusterUtil.MasterThread masterThread) {
     while (masterThread.isAlive()) {
-      LOG.info("Waiting on " + masterThread.getMaster().getServerName().toString());
-      masterThread.join();
+      try {
+        LOG.info("Waiting on " + masterThread.getMaster().getServerName().toString());
+        masterThread.join();
+      } catch (InterruptedException e) {
+        e.printStackTrace();
+      }
     }
     masterThreads.remove(masterThread);
     return masterThread.getName();

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java
@@ -19,7 +19,6 @@
 package org.apache.hadoop.hbase;
 
 import java.io.IOException;
-import java.io.InterruptedIOException;
 import java.security.PrivilegedAction;
 import java.util.ArrayList;
 import java.util.HashSet;
@@ -309,11 +308,7 @@ public void resumeRegionServer(ServerName serverName) throws IOException {
   @Override
   public void waitForRegionServerToStop(ServerName serverName, long timeout) throws IOException {
     //ignore timeout for now
-    try {
-      waitOnRegionServer(getRegionServerIndex(serverName));
-    } catch (InterruptedException e) {
-      throw (InterruptedIOException) new InterruptedIOException().initCause(e);
-    }
+    waitOnRegionServer(getRegionServerIndex(serverName));
   }
 
   @Override
@@ -409,11 +404,7 @@ public void stopMaster(ServerName serverName) throws IOException {
   @Override
   public void waitForMasterToStop(ServerName serverName, long timeout) throws IOException {
     //ignore timeout for now
-    try {
-      waitOnMaster(getMasterIndex(serverName));
-    } catch (InterruptedException e) {
-      throw (InterruptedIOException) new InterruptedIOException().initCause(e);
-    }
+    waitOnMaster(getMasterIndex(serverName));
   }
 
   /**
@@ -544,7 +535,7 @@ public JVMClusterUtil.RegionServerThread resumeRegionServer(int serverNumber) {
    * @param serverNumber
    * @return Name of region server that just went down.
    */
-  public String waitOnRegionServer(final int serverNumber) throws InterruptedException {
+  public String waitOnRegionServer(final int serverNumber) {
     return this.hbaseCluster.waitOnRegionServer(serverNumber);
   }
 
@@ -655,7 +646,7 @@ public JVMClusterUtil.MasterThread stopMaster(int serverNumber,
    * @param serverNumber
    * @return Name of master that just went down.
    */
-  public String waitOnMaster(final int serverNumber) throws InterruptedException {
+  public String waitOnMaster(final int serverNumber) {
     return this.hbaseCluster.waitOnMaster(serverNumber);
   }
 

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetricsWrapper.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterMetricsWrapper.java
@@ -59,7 +59,7 @@ public static void teardown() throws Exception {
   }
 
   @Test
-  public void testInfo() throws InterruptedException {
+  public void testInfo() {
     HMaster master = TEST_UTIL.getHBaseCluster().getMaster();
     MetricsMasterWrapperImpl info = new MetricsMasterWrapperImpl(master);
     assertEquals(