-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22631 assign failed may make gced parent region appear again #456
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks good. My concern is same as that put on the JIRA by Wellington et al., how does this fix the issue do you think? A UT might be hard? Were you able to deploy your fix? Did it help? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, does this change in line position make enough of a difference, enough to fix your issue? THanks.
🎊 +1 overall
This message was automatically generated. |
@saintstack Thank you for your comment. |
💔 -1 overall
This message was automatically generated. |
Thanks for the extra details, yuhuiyang. So the issue seems to be that this region was supposedly deleted already, as we could see the GCRegionProcedure has completed success for that region, but then it comes back when a given RS crashes and an SCP is submitted to it. Is it possible to share this Master log file, together with the tempt20 RS log file, covering this period between "2019-06-26 10:40" and "2019-06-26 10:42"? I suspect this might be same issue as the one addressed in HBASE-21843, where RS holding meta crashes, then meta wal edits are skipped in the wal replay, which misses some recent updates to meta. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The proposed change is quite simple, and we are not sure yet the problem is a new unsolved issue. To avoid confusion and forked discussions, am closing this PR for now. Let's keep discussing it on the jira only, for now. |
No description provided.