Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22808 HBCK Report showed the offline regions which belong to di… #465

Merged
merged 1 commit into from
Aug 8, 2019
Merged

HBASE-22808 HBCK Report showed the offline regions which belong to di… #465

merged 1 commit into from
Aug 8, 2019

Conversation

infraio
Copy link
Contributor

@infraio infraio commented Aug 8, 2019

…sabled table

saintstack
saintstack approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit to fix on commit?

hbase-server/src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java Outdated
@@ -672,6 +672,11 @@ private void checkServer(byte [] metaTableRow, RegionLocations locations) {
if (sn == null) {
continue;
}
// skip the offline regions which belong to disabled table.
if (services.getTableStateManager()
.isTableState(location.getRegion().getTable(), TableState.State.DISABLED)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I see. I didn't see it in my reproduction of the issue.

Could be DISABLED or DISABLING. Thats what we check in other places IIRC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already a method which call isTableDisabled. Let me change to use that one.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 140 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 487 master passed
+1 compile 75 master passed
+1 checkstyle 103 master passed
+1 shadedjars 370 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 52 master passed
0 spotbugs 301 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 298 master passed
_ Patch Compile Tests _
+1 mvninstall 418 the patch passed
+1 compile 82 the patch passed
+1 javac 82 the patch passed
+1 checkstyle 103 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 367 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1386 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 45 the patch passed
+1 findbugs 342 the patch passed
_ Other Tests _
-1 unit 14351 hbase-server in the patch failed.
+1 asflicense 32 The patch does not generate ASF License warnings.
19168
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/artifact/out/Dockerfile
GITHUB PR #465
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux f597cb0e13d3 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-465/out/precommit/personality/provided.sh
git revision master / 547cec4
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/testReport/
Max. process+thread count 4714 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@infraio infraio merged commit 9250977 into apache:master Aug 8, 2019
@infraio infraio deleted the HBASE-22808 branch August 8, 2019 08:57
asfgit pushed a commit that referenced this pull request Aug 8, 2019
@infraio
HBASE-22808 HBCK Report showed the offline regions which belong to di…
796cbf9 
…sabled table (#465)

Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 8, 2019
@infraio
HBASE-22808 HBCK Report showed the offline regions which belong to di…
1a59987 
…sabled table (#465)

Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 8, 2019
@infraio
HBASE-22808 HBCK Report showed the offline regions which belong to di…
a5d981c 
…sabled table (#465)

Signed-off-by: Stack <stack@apache.org>
asfgit pushed a commit that referenced this pull request Aug 8, 2019
@infraio
HBASE-22808 HBCK Report showed the offline regions which belong to di…
d99dccc 
…sabled table (#465)

Signed-off-by: Stack <stack@apache.org>
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 120 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 mvninstall 379 master passed
+1 compile 55 master passed
+1 checkstyle 75 master passed
+1 shadedjars 271 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 39 master passed
0 spotbugs 258 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 250 master passed
_ Patch Compile Tests _
+1 mvninstall 307 the patch passed
+1 compile 57 the patch passed
+1 javac 57 the patch passed
+1 checkstyle 74 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 272 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 964 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 34 the patch passed
+1 findbugs 267 the patch passed
_ Other Tests _
-1 unit 17883 hbase-server in the patch failed.
+1 asflicense 131 The patch does not generate ASF License warnings.
21602
Reason Tests
Failed junit tests hadoop.hbase.client.TestFromClientSide
hadoop.hbase.master.TestAssignmentManagerMetrics
hadoop.hbase.client.TestSnapshotTemporaryDirectory
hadoop.hbase.namespace.TestNamespaceAuditor
hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory
hadoop.hbase.replication.TestReplicationKillSlaveRSWithSeparateOldWALs
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/artifact/out/Dockerfile
GITHUB PR #465
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b016921e2d3f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-465/out/precommit/personality/provided.sh
git revision master / 547cec4
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/testReport/
Max. process+thread count 4972 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-465/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

chenxu14 pushed a commit to chenxu14/hbase that referenced this pull request Aug 12, 2019
@infraio @chenxu14
HBASE-22808 HBCK Report showed the offline regions which belong to di…
aa31394 
…sabled table (apache#465)

Signed-off-by: Stack <stack@apache.org>
infraio added a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@infraio
HBASE-22808 HBCK Report showed the offline regions which belong to di…
6c33d34 
…sabled table (apache#465)

Signed-off-by: Stack <stack@apache.org>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@infraio
HBASE-22808 HBCK Report showed the offline regions which belong to di…
f1cca41 
…sabled table (apache#465)

Signed-off-by: Stack <stack@apache.org>
(cherry picked from commit 1a59987)

Change-Id: I3ebdfc5d8ea5075d09a2cb462800b16341ff70b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infraio @Apache-HBase @saintstack