HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be land before #4666 so the patch there will be cleaner. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
anmolnar
approved these changes
Aug 4, 2022
Comment on lines
+281
to
+289
| .handler(new ChannelInitializer<Channel>() { | ||
|
|
||
| @Override | ||
| protected void initChannel(Channel ch) throws Exception { | ||
| ch.pipeline().addLast(BufferCallBeforeInitHandler.NAME, | ||
| new BufferCallBeforeInitHandler()); | ||
| } | ||
| }).localAddress(rpcClient.localAddr).remoteAddress(remoteAddr).connect() | ||
| .addListener(new ChannelFutureListener() { |
There was a problem hiding this comment.
nit: You don't need to do this change in this PR. This is only needed for the TLS stuff.
There was a problem hiding this comment.
I need to use this as I need to specify the handler name. The handler method for Bootstrap can not specify handler name.
pom.xml
Outdated
| @@ -26,7 +26,7 @@ | |||
| (in particular, if you are doing it for the first time), instead do | |||
| 'mvn package'. If you are interested in the full story, see | |||
| https://issues.apache.org/jira/browse/HBASE-6795. | |||
|
|
|||
| for triggering UTs | |||
There was a problem hiding this comment.
This one makes me confused: you got a successful build before adding this.
There was a problem hiding this comment.
The pre commit job for HBase is a bit 'intelligent' so it will only run the UTs in the module you touched in PR. But most IPC related UTs are in the hbase-server module, so I have to touch the pom file in the root dir so it will run all the UTs.
The failed UTs are not related. Some UTs in HBase are flaky, it is a long story...
There was a problem hiding this comment.
And I will revert this commit when merging, no worry.
meszibalu
approved these changes
Aug 4, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
pushed a commit
to HubSpot/hbase
that referenced
this pull request
Apr 2, 2023
…st (apache#4676) Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit fb529e2) Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
bbeaudreault
pushed a commit
to HubSpot/hbase
that referenced
this pull request
Apr 4, 2023
…st (apache#4676) Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit fb529e2) Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
bbeaudreault
added a commit
to HubSpot/hbase
that referenced
this pull request
Apr 7, 2023
* HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty handler (apache#4624) * HBASE-27185 Addendum fix TestShadeSaslAuthenticationProvider * HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (apache#4676) * HBASE-26666 Add native TLS encryption support to RPC server/client (apache#4666) * HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code (apache#4682) * HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler (apache#4705) * HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (apache#4751) * HBASE-27346 Autodetect key/truststore file type from file extension (apache#4757) * HBASE-27280 Add mutual authentication support to TLS (apache#4796) * HBASE-27673 Fix mTLS client hostname verification (apache#5066) * HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) (apache#4897) * HBASE-27779 Make X509Util config constants public * HBASE-27578 Upgrade hbase-thirdparty to 4.1.4 (apache#4985)
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…st (apache#4676) Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit fb529e2) Conflicts: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java (cherry picked from commit 1094b15) Change-Id: Iff314c026f3842cceedb5a11505dcc586747835c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.