HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler #4705

Apache9 · 2022-08-14T16:42:48Z

No description provided.

Apache-HBase · 2022-08-14T17:22:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 21s	master passed
+1 💚	compile	3m 9s	master passed
+1 💚	checkstyle	0m 46s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 8s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	3m 5s	the patch passed
+1 💚	javac	3m 5s	the patch passed
+1 💚	checkstyle	0m 44s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 45s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		36m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4705
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 79561110f545 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73759be`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client hbase-asyncfs hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-14T20:20:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 41s	master passed
+1 💚	compile	1m 16s	master passed
+1 💚	shadedjars	3m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	shadedjars	3m 53s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 21s	hbase-client in the patch passed.
+1 💚	unit	0m 58s	hbase-asyncfs in the patch passed.
-1 ❌	unit	192m 21s	hbase-server in the patch failed.
		214m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4705
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fa56447178e4 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73759be`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/testReport/
Max. process+thread count	2653 (vs. ulimit of 30000)
modules	C: hbase-client hbase-asyncfs hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-14T20:34:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 29s	master passed
+1 💚	compile	1m 12s	master passed
+1 💚	shadedjars	3m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 17s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	shadedjars	3m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 4s	hbase-client in the patch passed.
+1 💚	unit	1m 15s	hbase-asyncfs in the patch passed.
-1 ❌	unit	206m 57s	hbase-server in the patch failed.
		229m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4705
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0f3f4ce4f3db 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73759be`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/testReport/
Max. process+thread count	2348 (vs. ulimit of 30000)
modules	C: hbase-client hbase-asyncfs hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-15T04:44:00Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	3m 58s	master passed
+1 💚	checkstyle	0m 56s	master passed
+1 💚	spotless	0m 49s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 33s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 9s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	3m 35s	the patch passed
+1 💚	javac	3m 34s	the patch passed
+1 💚	checkstyle	1m 0s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 39s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotless	0m 52s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 59s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		43m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4705
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 8b7d8f74777f 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73759be`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-client hbase-asyncfs hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-15T07:31:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s	master passed
+1 💚	compile	1m 11s	master passed
+1 💚	shadedjars	3m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	3m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 20s	hbase-client in the patch passed.
+1 💚	unit	1m 0s	hbase-asyncfs in the patch passed.
+1 💚	unit	189m 29s	hbase-server in the patch passed.
		211m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4705
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 73dab9c332f3 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73759be`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/2/testReport/
Max. process+thread count	2648 (vs. ulimit of 30000)
modules	C: hbase-client hbase-asyncfs hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-08-15T07:40:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 43s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	shadedjars	3m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 9s	hbase-client in the patch passed.
+1 💚	unit	0m 55s	hbase-asyncfs in the patch passed.
+1 💚	unit	199m 4s	hbase-server in the patch passed.
		220m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4705
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 034d63980efe 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73759be`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/2/testReport/
Max. process+thread count	2823 (vs. ulimit of 30000)
modules	C: hbase-client hbase-asyncfs hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4705/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-08-15T07:41:07Z

@anmolnar @bbeaudreault PTAL.

Thanks.

anmolnar

+1
Although I don't understand every single bit of this change, it looks good to me.
I believe the key is to replace addFirst() calls by something that refers to tha actual pipeline.

Apache9 · 2022-08-16T01:31:34Z

+1 Although I don't understand every single bit of this change, it looks good to me. I believe the key is to replace addFirst() calls by something that refers to tha actual pipeline.

Yes, we need preserve the original order of the handler other than SslHandler while keep SslHandler at the first place.

bbeaudreault

lgtm

…er (#4705) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Reviewed-by: Andor Molnár <andor@cloudera.com> (cherry picked from commit 2b9d368) Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestNettyTlsIPCRejectPlainText.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestTlsWithKerberos.java

…er (apache#4705) Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Reviewed-by: Andor Molnár <andor@cloudera.com> (cherry picked from commit 2b9d368) Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestNettyTlsIPCRejectPlainText.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestTlsWithKerberos.java

* HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty handler (apache#4624) * HBASE-27185 Addendum fix TestShadeSaslAuthenticationProvider * HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (apache#4676) * HBASE-26666 Add native TLS encryption support to RPC server/client (apache#4666) * HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code (apache#4682) * HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler (apache#4705) * HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (apache#4751) * HBASE-27346 Autodetect key/truststore file type from file extension (apache#4757) * HBASE-27280 Add mutual authentication support to TLS (apache#4796) * HBASE-27673 Fix mTLS client hostname verification (apache#5066) * HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) (apache#4897) * HBASE-27779 Make X509Util config constants public * HBASE-27578 Upgrade hbase-thirdparty to 4.1.4 (apache#4985)

…er (apache#4705) Change[3/4] for: Backporting of changes related to HBASE-27279. This commit does not contain secrets Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> Reviewed-by: Andor Molnár <andor@cloudera.com> (cherry picked from commit 2b9d368) Change-Id: Ic51f73d5a0b7b92f137eb2be2aec8014bac7eff2

Apache9 self-assigned this Aug 14, 2022

HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler

cb48140

Apache9 force-pushed the HBASE-27279 branch from 2e66d19 to cb48140 Compare August 15, 2022 03:50

Apache9 requested a review from bbeaudreault August 15, 2022 07:40

anmolnar approved these changes Aug 15, 2022

View reviewed changes

bbeaudreault approved these changes Aug 16, 2022

View reviewed changes

Apache9 merged commit 2b9d368 into apache:master Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler #4705

HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler #4705

Apache9 commented Aug 14, 2022

Apache-HBase commented Aug 14, 2022

Apache-HBase commented Aug 14, 2022

Apache-HBase commented Aug 14, 2022

Apache-HBase commented Aug 15, 2022

Apache-HBase commented Aug 15, 2022

Apache-HBase commented Aug 15, 2022

Apache9 commented Aug 15, 2022

anmolnar left a comment

Apache9 commented Aug 16, 2022

bbeaudreault left a comment

HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler #4705

HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler #4705

Conversation

Apache9 commented Aug 14, 2022

Apache-HBase commented Aug 14, 2022

Apache-HBase commented Aug 14, 2022

Apache-HBase commented Aug 14, 2022

Apache-HBase commented Aug 15, 2022

Apache-HBase commented Aug 15, 2022

Apache-HBase commented Aug 15, 2022

Apache9 commented Aug 15, 2022

anmolnar left a comment

Choose a reason for hiding this comment

Apache9 commented Aug 16, 2022

bbeaudreault left a comment

Choose a reason for hiding this comment