HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2 #4787

Apache9 · 2022-09-15T07:02:19Z

No description provided.

Apache-HBase · 2022-09-15T07:45:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 52s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	3m 23s	master passed
+1 💚	checkstyle	0m 41s	master passed
+1 💚	spotless	1m 2s	branch has no errors when running spotless:check.
-1 ❌	spotbugs	2m 0s	hbase-server in master has 28 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	3m 6s	the patch passed
-0 ⚠️	javac	3m 6s	hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚	checkstyle	0m 40s	hbase-server: The patch generated 0 new + 38 unchanged - 4 fixed = 38 total (was 42)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 33s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 49s	patch has no errors when running spotless:check.
-1 ❌	spotbugs	2m 1s	hbase-server generated 1 new + 3 unchanged - 25 fixed = 4 total (was 28)
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		39m 47s

Reason	Tests
FindBugs	module:hbase-server
	instanceof will always return true for all non-null values in org.apache.hadoop.hbase.regionserver.HMobStore.readCell(List, String, Cell, boolean, long, boolean), since all java.io.IOException are instances of java.io.IOException At HMobStore.java:for all non-null values in org.apache.hadoop.hbase.regionserver.HMobStore.readCell(List, String, Cell, boolean, long, boolean), since all java.io.IOException are instances of java.io.IOException At HMobStore.java:[line 444]

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux bad377900f55 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `00aba9c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-15T11:06:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 52s	master passed
+1 💚	compile	0m 42s	master passed
+1 💚	shadedjars	4m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 42s	the patch passed
+1 💚	javac	0m 42s	the patch passed
+1 💚	shadedjars	4m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	220m 51s	hbase-server in the patch failed.
		240m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fe1784cebef7 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `00aba9c`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/testReport/
Max. process+thread count	2637 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-15T11:13:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	shadedjars	3m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
-1 ❌	unit	229m 49s	hbase-server in the patch failed.
		248m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9c008acbac46 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `00aba9c`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/testReport/
Max. process+thread count	2478 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-15T12:07:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	6m 13s	master passed
+1 💚	checkstyle	1m 1s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
-1 ❌	spotbugs	7m 5s	root in master has 48 extant spotbugs warnings.
-1 ❌	spotbugs	1m 18s	hbase-server in master has 28 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	6m 11s	the patch passed
-0 ⚠️	javac	6m 11s	root generated 1 new + 708 unchanged - 1 fixed = 709 total (was 709)
+1 💚	checkstyle	1m 2s	root: The patch generated 0 new + 44 unchanged - 5 fixed = 44 total (was 49)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	7m 53s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 26s	hbase-server generated 0 new + 0 unchanged - 28 fixed = 0 total (was 28)
+1 💚	spotbugs	7m 12s	root generated 0 new + 20 unchanged - 28 fixed = 20 total (was 48)
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		52m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
uname	Linux 2e7d834439cd 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `460bb47`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/2/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/2/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count	139 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-09-15T13:29:47Z

For MS_EXPOSE_REP, there is a related issue in spotbugs spotbugs/spotbugs#1747, but seems there is no response from the maintainer yet.

Apache-HBase · 2022-09-15T16:05:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	7m 26s	master passed
+1 💚	checkstyle	1m 5s	master passed
+1 💚	spotless	0m 46s	branch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 29s	hbase-common in master has 6 extant spotbugs warnings.
-1 ❌	spotbugs	0m 17s	hbase-metrics in master has 1 extant spotbugs warnings.
-1 ❌	spotbugs	0m 44s	hbase-client in master has 10 extant spotbugs warnings.
-1 ❌	spotbugs	1m 36s	hbase-server in master has 28 extant spotbugs warnings.
-1 ❌	spotbugs	0m 28s	hbase-testing-util in master has 1 extant spotbugs warnings.
-1 ❌	spotbugs	0m 28s	hbase-rest in master has 2 extant spotbugs warnings.
-1 ❌	spotbugs	9m 7s	root in master has 48 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	7m 15s	the patch passed
-0 ⚠️	javac	7m 15s	root generated 1 new + 708 unchanged - 1 fixed = 709 total (was 709)
+1 💚	checkstyle	1m 8s	root: The patch generated 0 new + 48 unchanged - 5 fixed = 48 total (was 53)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	8m 44s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 42s	hbase-common generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	spotbugs	0m 24s	hbase-metrics generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 58s	hbase-client generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
+1 💚	spotbugs	1m 46s	hbase-server generated 0 new + 0 unchanged - 28 fixed = 0 total (was 28)
+1 💚	spotbugs	0m 38s	hbase-testing-util generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 40s	hbase-rest generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 💚	spotbugs	9m 2s	root generated 0 new + 0 unchanged - 48 fixed = 0 total (was 48)
		_ Other Tests _
+1 💚	asflicense	1m 31s	The patch does not generate ASF License warnings.
		69m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
uname	Linux 9224436fb727 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `460bb47`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-common-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-metrics-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-client-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-testing-util-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-rest-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/branch-spotbugs-root-warnings.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count	139 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-client hbase-server hbase-testing-util hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-15T19:07:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	1m 56s	master passed
+1 💚	shadedjars	3m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 36s	the patch passed
+1 💚	compile	1m 53s	the patch passed
+1 💚	javac	1m 53s	the patch passed
+1 💚	shadedjars	3m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 30s	the patch passed
		_ Other Tests _
-1 ❌	unit	223m 35s	root in the patch failed.
		251m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ff3386ba68f0 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `460bb47`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/testReport/
Max. process+thread count	2649 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-client hbase-server hbase-testing-util hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-15T22:34:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	1m 43s	master passed
+1 💚	shadedjars	4m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 8s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	1m 44s	the patch passed
+1 💚	javac	1m 44s	the patch passed
+1 💚	shadedjars	4m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 15s	the patch passed
		_ Other Tests _
-1 ❌	unit	429m 3s	root in the patch failed.
		459m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 16c01830b8d2 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `460bb47`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/testReport/
Max. process+thread count	3607 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-client hbase-server hbase-testing-util hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-16T05:13:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	4m 27s	master passed
+1 💚	checkstyle	1m 29s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
-1 ❌	spotbugs	0m 42s	hbase-client in master has 10 extant spotbugs warnings.
-1 ❌	spotbugs	0m 29s	hbase-common in master has 6 extant spotbugs warnings.
-1 ❌	spotbugs	0m 15s	hbase-metrics in master has 1 extant spotbugs warnings.
-1 ❌	spotbugs	0m 24s	hbase-rest in master has 2 extant spotbugs warnings.
-1 ❌	spotbugs	1m 17s	hbase-server in master has 28 extant spotbugs warnings.
-1 ❌	spotbugs	0m 24s	hbase-testing-util in master has 1 extant spotbugs warnings.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 14s	the patch passed
+1 💚	compile	4m 23s	the patch passed
-0 ⚠️	javac	2m 12s	hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚	checkstyle	0m 14s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	0m 7s	The patch passed checkstyle in hbase-metrics
+1 💚	checkstyle	0m 16s	The patch passed checkstyle in hbase-client
+1 💚	checkstyle	0m 32s	hbase-server: The patch generated 0 new + 44 unchanged - 5 fixed = 44 total (was 49)
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-testing-util
+1 💚	checkstyle	0m 9s	The patch passed checkstyle in hbase-rest
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	7m 58s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 36s	hbase-common generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	spotbugs	0m 24s	hbase-metrics generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 47s	hbase-client generated 0 new + 0 unchanged - 10 fixed = 0 total (was 10)
+1 💚	spotbugs	1m 25s	hbase-server generated 0 new + 0 unchanged - 28 fixed = 0 total (was 28)
+1 💚	spotbugs	0m 29s	hbase-testing-util generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
+1 💚	spotbugs	0m 32s	hbase-rest generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
		_ Other Tests _
+1 💚	asflicense	0m 55s	The patch does not generate ASF License warnings.
		43m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile xml
uname	Linux 230cf6433718 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `460bb47`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-client-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-common-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-metrics-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-rest-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-testing-util-warnings.html
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-client hbase-server hbase-testing-util hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-16T08:43:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 41s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	1m 58s	master passed
+1 💚	shadedjars	4m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 31s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s	the patch passed
+1 💚	compile	1m 59s	the patch passed
+1 💚	javac	1m 59s	the patch passed
+1 💚	shadedjars	4m 25s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 52s	hbase-common in the patch passed.
+1 💚	unit	0m 16s	hbase-metrics in the patch passed.
+1 💚	unit	1m 17s	hbase-client in the patch passed.
-1 ❌	unit	218m 30s	hbase-server in the patch failed.
+1 💚	unit	2m 19s	hbase-testing-util in the patch passed.
+1 💚	unit	4m 30s	hbase-rest in the patch passed.
		253m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 76d4640999b4 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `460bb47`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/testReport/
Max. process+thread count	2669 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-client hbase-server hbase-testing-util hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-16T09:58:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 2s	master passed
+1 💚	compile	3m 30s	master passed
+1 💚	shadedjars	5m 51s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 19s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	3m 13s	the patch passed
+1 💚	javac	3m 13s	the patch passed
+1 💚	shadedjars	5m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	2m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 17s	hbase-common in the patch passed.
+1 💚	unit	0m 23s	hbase-metrics in the patch passed.
+1 💚	unit	1m 56s	hbase-client in the patch passed.
-1 ❌	unit	281m 52s	hbase-server in the patch failed.
+1 💚	unit	1m 57s	hbase-testing-util in the patch passed.
+1 💚	unit	3m 30s	hbase-rest in the patch passed.
		328m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4787
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 72a96ba22623 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `460bb47`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/testReport/
Max. process+thread count	2659 (vs. ulimit of 30000)
modules	C: hbase-common hbase-metrics hbase-client hbase-server hbase-testing-util hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4787/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil

I believe the latest UT failures are unrelated. Have seen the same on other PRs.

Apache9 · 2022-09-16T13:52:42Z

Let me check the TestTags test. It failed for both jdk8 and jdk11.

Apache9 · 2022-09-16T14:54:30Z

Tried several times, TestTags passed for me locally. Looking at the code, I guess the problem is the 'no condition check' Thread.sleep. Maybe the problem is our build machine is under high load and slow.

Let me merge to solve the spotbugs for master branch and keep an eye on the flaky dashboard.

Thanks @wchevreuil for reviewing!

….2 (apache#4787) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

….2 (#4787) (#4789) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

….2 (apache#4787) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

….2 (#4787) (#4790) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

….2 (apache#4787) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

….2 (#4787) (#4791) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

….2 (apache#4787) (apache#4791) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> (cherry picked from commit 82f9664) Change-Id: I952c8570be1af44824e3e8f531c9eb8cb1101810

Apache9 self-assigned this Sep 15, 2022

Apache9 force-pushed the HBASE-27373 branch from aee63e3 to e3669a5 Compare September 15, 2022 14:41

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2

42db6e9

Apache9 force-pushed the HBASE-27373 branch from e3669a5 to 42db6e9 Compare September 16, 2022 04:22

wchevreuil approved these changes Sep 16, 2022

View reviewed changes

wchevreuil mentioned this pull request Sep 16, 2022

HBASE-27370 Avoid decompressing blocks when reading from bucket cache… #4781

Merged

Apache9 merged commit 6f0761a into apache:master Sep 16, 2022

Apache9 added a commit to Apache9/hbase that referenced this pull request Sep 16, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

46d5d30

….2 (apache#4787) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Apache9 added a commit to Apache9/hbase that referenced this pull request Sep 17, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

aa1a93f

….2 (apache#4787) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Apache9 added a commit that referenced this pull request Sep 18, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

9fb3aee

….2 (#4787) (#4789) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Apache9 added a commit to Apache9/hbase that referenced this pull request Sep 18, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

150a80f

….2 (apache#4787) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Apache9 mentioned this pull request Sep 18, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7… #4790

Merged

Apache9 added a commit to Apache9/hbase that referenced this pull request Sep 18, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

43873e6

….2 (apache#4787) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Apache9 added a commit that referenced this pull request Sep 18, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

ca86eea

….2 (#4787) (#4790) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Apache9 added a commit to Apache9/hbase that referenced this pull request Sep 19, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

8a1fc38

….2 (apache#4787) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Apache9 added a commit that referenced this pull request Sep 19, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7…

82f9664

….2 (#4787) (#4791) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2 #4787

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2 #4787

Apache9 commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache9 commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 16, 2022

Apache-HBase commented Sep 16, 2022

Apache-HBase commented Sep 16, 2022

wchevreuil left a comment

Apache9 commented Sep 16, 2022

Apache9 commented Sep 16, 2022

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2 #4787

HBASE-27373 Fix new spotbugs warnings after upgrading spotbugs to 4.7.2 #4787

Conversation

Apache9 commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache9 commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 15, 2022

Apache-HBase commented Sep 16, 2022

Apache-HBase commented Sep 16, 2022

Apache-HBase commented Sep 16, 2022

wchevreuil left a comment

Choose a reason for hiding this comment

Apache9 commented Sep 16, 2022

Apache9 commented Sep 16, 2022