Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27406 Make "/prometheus" endpoint accessible from HBase UI #4833

Merged
merged 1 commit into from
Oct 20, 2022
Merged

HBASE-27406 Make "/prometheus" endpoint accessible from HBase UI #4833

merged 1 commit into from
Oct 20, 2022

Conversation

lucakovacs
Copy link
Contributor

Before this change, Prometheus metrics were only accessible via the '/prometheus' endpoint.

I made changes in the UI, so instead of Metrics Dump there's a dropdown menu called Metrics with the JMX and Prometheus metrics.

I also included the metrics description, so there are four endpoints available from there:

  • JMX
  • JMX with description
  • Prometheus
  • Prometheus with description

Apache JIRA: https://issues.apache.org/jira/browse/HBASE-27406

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 18s master passed
+1 💚 spotless 0m 38s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 2s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 36s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
8m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4833
Optional Tests dupname asflicense javac spotless
uname Linux 801624ec7a90 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b68229c
Default Java Temurin-1.8.0_345-b01
Max. process+thread count 64 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 56s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for branch
+1 💚 mvninstall 2m 20s master passed
+1 💚 javadoc 1m 1s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 javadoc 1m 0s the patch passed
_ Other Tests _
+1 💚 unit 213m 13s hbase-server in the patch passed.
+1 💚 unit 8m 43s hbase-thrift in the patch passed.
+1 💚 unit 3m 26s hbase-rest in the patch passed.
234m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4833
Optional Tests javac javadoc unit
uname Linux 0c890954de29 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b68229c
Default Java Temurin-1.8.0_345-b01
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/testReport/
Max. process+thread count 2657 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 28s master passed
+1 💚 javadoc 1m 15s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 16s the patch passed
+1 💚 javadoc 1m 19s the patch passed
_ Other Tests _
+1 💚 unit 238m 14s hbase-server in the patch passed.
+1 💚 unit 7m 12s hbase-thrift in the patch passed.
+1 💚 unit 4m 22s hbase-rest in the patch passed.
262m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4833
Optional Tests javac javadoc unit
uname Linux 0d9ffc01c3e5 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / b68229c
Default Java Eclipse Adoptium-11.0.16.1+1
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/testReport/
Max. process+thread count 2737 (vs. ulimit of 30000)
modules C: hbase-server hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

anmolnar
anmolnar approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@meszibalu meszibalu merged commit dffc8e0 into apache:master Oct 20, 2022
asfgit pushed a commit that referenced this pull request Oct 20, 2022
@lucakovacs @meszibalu
HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833)
a31b148 
Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@lucakovacs
HBASE-27406 Make /prometheus endpoint accessible from HBase UI (apach…
c23f541 
…e#4833)

Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
(cherry picked from commit a31b148)
Change-Id: Id24f0f4215fe5bd46a5ace61ae33c5ee9c1ecebb
@PDavid PDavid mentioned this pull request Dec 12, 2024
Merged
PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 12, 2024
@lucakovacs @PDavid
HBASE-27406 Make /prometheus endpoint accessible from HBase UI (apach…
137c6dc 
…e#4833)

Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
@PDavid PDavid mentioned this pull request Dec 13, 2024
Merged
NihalJain pushed a commit that referenced this pull request Jan 8, 2025
@PDavid
HBASE-29028 Backport missing UI patches to branch-2.5 (#6542)
526bad7 
* HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833)

Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)

* HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer (#5215)
Other changes:
- Ensure info server stops during stop()
- Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693)
- Add hostname in the landing page instead of just port similar to other web UIs

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a683fcf)

* HBASE-18382 add transport type info into Thrift UI (#880)

Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
(cherry picked from commit 82e155e)

* HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732)
- Fixes the way logLevel page renders in UI

Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit ede4ccd)

* HBASE-24624 Optimize table.jsp code (#1963)

Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
(cherry picked from commit 9ad16aa)

* HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)

* HBASE-27309 Add major compact table or region operation on master web table page (#4793)

Co-authored-by: zhengsicheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit eb6b274)

* HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 3caaf2d)

* HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (#5620)

Co-authored-by: Haosen Chen <haosenchen@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit e3a0174)

* HBASE-20452 Master UI: Table merge button should validate required fields before submit

Signed-off-by: tedyu <yuzhihong@gmail.com>
(cherry picked from commit 6ce1136)

* HBASE-29028 Removed Prometheus links from navbar as the feature (HBASE-20904) is not even supported by backend.

---------

Co-authored-by: Luca Kovács <kovacs.luca.agota@gmail.com>
Co-authored-by: Nihal Jain <nihaljain@apache.org>
Co-authored-by: Beata Sudi <bea0113@users.noreply.github.com>
Co-authored-by: xincunSong <365724453@qq.com>
Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com>
Co-authored-by: SiCheng-Zheng <643463623@qq.com>
Co-authored-by: Peng Lu <lupeng_nwpu@qq.com>
Co-authored-by: haosen chen <99318736+haosenchen@users.noreply.github.com>
Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com>

Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolnar anmolnar anmolnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucakovacs @Apache-HBase @anmolnar @meszibalu